Re: [PATCHES] relscan.h split

2008-06-14 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Also, it seemed like some of those .c files had no business poking into >> the scan structs anyway; particularly contrib. Did you check whether >> the inclusions could be avoided? > Not really, unless we were to provide something a r

Re: [PATCHES] relscan.h split

2008-06-14 Thread Alvaro Herrera
Tom Lane wrote: > Perhaps a better idea would be to put the opaque-pointer typedefs into > heapam.h and genam.h respectively, and then see where you could remove > inclusions of relscan.h. Hmm, this seems to be closely equivalent. Patch attached. I also moved SysScanDescData from genam.h to rel

Re: [PATCHES] relscan.h split

2008-06-12 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > I propose the following patch which moves the struct definitions to a > separate new header relscan_internal.h. This seems a little bizarre, seeing that there is almost nothing in relscan.h except those structs. Perhaps a better idea would be to put th

[PATCHES] relscan.h split

2008-06-12 Thread Alvaro Herrera
Hi, relscan.h is very widely used -- in particular it is included by some headers that want the IndexScanDesc and HeapScanDesc definitions in prototypes. However, most of the time they are just passing the struct through; they don't need to see the actual Heap/IndexScanDescData definitions. I pr