Re: [PATCHES] temporal version of generate_series()

2008-05-04 Thread Tom Lane
H.Harada [EMAIL PROTECTED] writes: Here's the sync and updated patch. It contains strict in catalog as well. Applied with some revisions --- I added a timestamptz version; it didn't seem very appropriate to have only a timestamp version. You can't just pick a convenient-looking OID, you must

Re: [PATCHES] temporal version of generate_series()

2008-05-04 Thread H . Harada
2008/5/5 Tom Lane [EMAIL PROTECTED]: Applied with some revisions --- I added a timestamptz version; it didn't seem very appropriate to have only a timestamp version. You can't just pick a convenient-looking OID, you must use one that the unused_oids script reports as free. I didn't

Re: [PATCHES] temporal version of generate_series()

2008-05-01 Thread H . Harada
2008/5/1 Pavel Stehule [EMAIL PROTECTED]: Hello why you don't use polymorphic types? Ah, good idea. I didn't think we could fix the third argument to interval but anyelement. For a temporal version, it's reasonable. Also, the name generate_time_series is better than before? Hitoshi Harada

Re: [PATCHES] temporal version of generate_series()

2008-05-01 Thread H . Harada
2008/5/1 H. Harada [EMAIL PROTECTED]: 2008/5/1 Pavel Stehule [EMAIL PROTECTED]: Hello why you don't use polymorphic types? Ah, good idea. I didn't think we could fix the third argument to interval but anyelement. For a temporal version, it's reasonable. I was thinking about it

Re: [PATCHES] temporal version of generate_series()

2008-05-01 Thread Pavel Stehule
2008/5/1 H. Harada [EMAIL PROTECTED]: 2008/5/1 H. Harada [EMAIL PROTECTED]: 2008/5/1 Pavel Stehule [EMAIL PROTECTED]: Hello why you don't use polymorphic types? Ah, good idea. I didn't think we could fix the third argument to interval but anyelement. For a temporal version, it's

Re: [PATCHES] temporal version of generate_series()

2008-04-30 Thread H . Harada
Here's the sync and updated patch. It contains strict in catalog as well. Hitoshi Harada 2008/4/24 H. Harada [EMAIL PROTECTED]: 2008/4/23 Alvaro Herrera [EMAIL PROTECTED]: H.Harada escribió: # This is my first time to send a patch. If I did something wrong, I appreciate your

Re: [PATCHES] temporal version of generate_series()

2008-04-30 Thread Pavel Stehule
Hello why you don't use polymorphic types? like: create or replace function generate_time_series(anyelement, anyelement, interval, OUT result anyelement) returns setof anyelement as $$ begin result := $1; while (result = $2) loop return next; result := result + $3; end loop;

[PATCHES] temporal version of generate_series()

2008-04-23 Thread H . Harada
I found a TODO item Add temporal versions of generate_series() and wrote patch for generate_series(timestamp, timestamp, interval). I just copied it from int4.c to timestamp.c and fit the data types in timestamp and interval. I wonder if we need ones for timestamptz and time?? If so, the

Re: [PATCHES] temporal version of generate_series()

2008-04-23 Thread Alvaro Herrera
H.Harada escribió: # This is my first time to send a patch. If I did something wrong, I appreciate your pointing me out. Brace positioning is off w.r.t. our conventions -- please fix that and resubmit. I have added this patch to the May commitfest. -- Alvaro Herrera

Re: [PATCHES] temporal version of generate_series()

2008-04-23 Thread H . Harada
2008/4/23 Alvaro Herrera [EMAIL PROTECTED]: H.Harada escribió: # This is my first time to send a patch. If I did something wrong, I appreciate your pointing me out. Brace positioning is off w.r.t. our conventions -- please fix that and resubmit. Here's updated version. Thanks for