[PATCHES] thread safety testing fix
When checking for thread safety with src/tools/thread/thread_test.c, the mktemp function wants an argument that contains 6 X, while the current version only supplies 5 X which will fail on my SuSE 8.1. Patch attached. Regards, Andreas Index: thread_test.c === RCS file: /projects/cvsroot/pgsql-server/src/tools/thread/thread_test.c,v retrieving revision 1.29 diff -u -r1.29 thread_test.c --- thread_test.c 27 Apr 2004 19:51:12 - 1.29 +++ thread_test.c 28 May 2004 11:39:00 - @@ -64,8 +64,8 @@ void func_call_1(void); void func_call_2(void); -#defineTEMP_FILENAME_1 /tmp/thread_test.1.X -#defineTEMP_FILENAME_2 /tmp/thread_test.2.X +#defineTEMP_FILENAME_1 /tmp/thread_test.1.XX +#defineTEMP_FILENAME_2 /tmp/thread_test.2.XX char *temp_filename_1; char *temp_filename_2; ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings
Re: [PATCHES] thread safety testing fix
Andreas Pflug [EMAIL PROTECTED] writes: When checking for thread safety with src/tools/thread/thread_test.c, the mktemp function wants an argument that contains 6 X, while the current version only supplies 5 X which will fail on my SuSE 8.1. Patch attached. Isn't this going to break platforms that only want 5 X's ? regards, tom lane ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] thread safety testing fix
Tom Lane wrote: Andreas Pflug [EMAIL PROTECTED] writes: When checking for thread safety with src/tools/thread/thread_test.c, the mktemp function wants an argument that contains 6 X, while the current version only supplies 5 X which will fail on my SuSE 8.1. Patch attached. Isn't this going to break platforms that only want 5 X's ? Probably not., any additional X will just be ignored. AFAICS all platforms want at least 6 X anyway. Regards, Andreas ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send unregister YourEmailAddressHere to [EMAIL PROTECTED])
Re: [PATCHES] thread safety testing fix
Tom Lane wrote: Andreas Pflug [EMAIL PROTECTED] writes: When checking for thread safety with src/tools/thread/thread_test.c, the mktemp function wants an argument that contains 6 X, while the current version only supplies 5 X which will fail on my SuSE 8.1. Patch attached. Isn't this going to break platforms that only want 5 X's ? My BSD/OS doesn't specify a specific number of X's, but it does use an example with six, so six should be fine. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 8: explain analyze is your friend