[PATCHES] Minor verbosity increase for analyze

2003-07-31 Thread Mark Kirkwood
Attached is a (very small) patch to make analyze display some interesting info in verbose mode about the analyzed relation (pages, rows per block and rows ). This is all available in the statistics catalog but I have found it useful to see it appear as you run... mods to :

[PATCHES] Check for failed memory allocations in libpq

2003-07-31 Thread Dave Allen
Attached is a patch (against 7.3.4) to check the return values of some calls (malloc, realloc, etc.) for failed memory allocations in libpq. -- Dave Allen [EMAIL PROTECTED] --- postgresql-7.3.4-orig/src/interfaces/libpq/fe-exec.cWed Sep 4 13:31:47 2002 +++

Re: [PATCHES] Minor verbosity increase for analyze

2003-07-31 Thread Mark Kirkwood
After browsing this list, I thought I would re-submit this in a more standard form. In addition I corrected a couple of things (integer cast for the number of rows, and capitalization in the comment) regards Mark --- src/backend/commands/analyze.c.orig 2003-07-31 20:49:22.0 -0400 +++

Re: [PATCHES] ruleutils with pretty-print option

2003-07-31 Thread Andreas Pflug
Tom Lane wrote: Applied with some editorializing. In particular, I don't believe the original did the right thing with (a - (b - c)). Oops, missed that case... But now, we have (a + ( b + c)) again. A patch that removes parentheses for + and * is appended. Regards, Andfdsa

[Fwd: Re: [PATCHES] ruleutils with pretty-print option]

2003-07-31 Thread Andreas Pflug
Now the patch is *really* appended :-) Tom Lane wrote: Applied with some editorializing. In particular, I don't believe the original did the right thing with (a - (b - c)). Oops, missed that case... But now, we have (a + ( b + c)) again. A patch that removes parentheses for + and * is

Re: [PATCHES] Proof-of-concept for initdb-time shared_buffers selection

2003-07-31 Thread Manfred Koizar
On Fri, 04 Jul 2003 15:29:37 -0400, Tom Lane [EMAIL PROTECTED] wrote: The attached patch shows how initdb can dynamically determine reasonable shared_buffers and max_connections settings that will work on the current machine. Can't this be done on postmaster startup? I think of two GUC variables

Re: [Fwd: Re: [PATCHES] ruleutils with pretty-print option]

2003-07-31 Thread Andreas Pflug
Tom Lane wrote: Now the patch is *really* appended :-) And rejected. Ok, the ckeck for node being the first child already does the trick for standard l-t-r evaluation. You cannot assume that an operator is commutative or associative just because it has a name you think ought to be. (For

Re: [PATCHES] Check for failed memory allocations in libpq

2003-07-31 Thread Tom Lane
Dave Allen [EMAIL PROTECTED] writes: Attached is a patch (against 7.3.4) to check the return values of some calls (malloc, realloc, etc.) for failed memory allocations in libpq. You sure you aren't just trading one misbehavior for another? The change in PQmakeEmptyPGresult, for example, just

Re: [Fwd: Re: [PATCHES] ruleutils with pretty-print option]

2003-07-31 Thread Tom Lane
Andreas Pflug [EMAIL PROTECTED] writes: Now the patch is *really* appended :-) And rejected. You cannot assume that an operator is commutative or associative just because it has a name you think ought to be. (For a counter-example, it's well known that floating-point addition is not

Re: [Fwd: Re: [PATCHES] ruleutils with pretty-print option]

2003-07-31 Thread Andreas Pflug
Tom Lane wrote: Andreas Pflug [EMAIL PROTECTED] writes: Well, to me it's not well-known that floating-point addition is not associative, do I need to re-learn my math? regression=# select (1.0::float8 + (-1.0::float8)) + 1.0e-20::float8; ?column? -- 1e-20 (1 row) regression=#

Re: [Fwd: Re: [PATCHES] ruleutils with pretty-print option]

2003-07-31 Thread Manfred Koizar
On Thu, 31 Jul 2003 16:30:17 +0200, Andreas Pflug [EMAIL PROTECTED] wrote: Well, to me it's not well-known that floating-point addition is not associative This is a case of theory vs. practice mismatch: In theory addition is associative, in practice there is only limited storage available for a

Re: [PATCHES] ruleutils with pretty-print option

2003-07-31 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: I didn't like the functions ending in _ext. I renamed them to _pp for pretty print. Patch attached and applied. Seems to be shy a catversion bump; since you have just made an incompatible change in the internal-function-names

Re: [Fwd: Re: [PATCHES] ruleutils with pretty-print option]

2003-07-31 Thread Tom Lane
Andreas Pflug [EMAIL PROTECTED] writes: Well, to me it's not well-known that floating-point addition is not associative, do I need to re-learn my math? regression=# select (1.0::float8 + (-1.0::float8)) + 1.0e-20::float8; ?column? -- 1e-20 (1 row) regression=# select 1.0::float8

Re: [PATCHES] ruleutils with pretty-print option

2003-07-31 Thread Bruce Momjian
Would you send over the patch --- it was missing. --- Andreas Pflug wrote: Tom Lane wrote: Applied with some editorializing. In particular, I don't believe the original did the right thing with (a - (b - c)).

Re: [PATCHES] updateable cursors

2003-07-31 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: This has been saved for the 7.5 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 Saved for? It's not gonna be acceptable in its current form for 7.5, either. I saved the patch plus your comments about it, so we can

Re: [PATCHES] updateable cursors

2003-07-31 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: This has been saved for the 7.5 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 Saved for? It's not gonna be acceptable in its current form for 7.5, either. regards, tom lane ---(end of

[PATCHES] preload libraries patch [was: [GENERAL] hexadecimal to decimal]

2003-07-31 Thread Joe Conway
Tom Lane wrote: It seems entirely sensible to me for the postmaster to choke on invalid settings in postgresql.conf. Better than failing to mention the problem at all, anyway. 2) do you want a patch that exports plperl_init_all() (and I guess similar init functions in pltcl and plpython)? Yeah,

Re: [PATCHES] preload libraries patch [was: [GENERAL] hexadecimal to decimal]

2003-07-31 Thread Joe Conway
Tom Lane wrote: As coded, this will cause pltcl to try to execute the unknown-module load on every pltcl function call :-(. You really need two bits of state if you are going to have separate postmaster-time and backend-time initialization. Hmmm, I see your point :(. Sorry about that! Will fix

Re: [PATCHES] Check for failed memory allocations in libpq

2003-07-31 Thread Dave Allen
Apologies if I missed anything, but I thought I fixed any callers of PQmakeEmptyPQresult that weren't already checking (parseInput and getRowDescriptions were the only ones). I of course can't fix any applications I don't have the source for, but if I missed something in libpq, I'd be more than

Re: [PATCHES] Autoconf test for incompatible version of flex

2003-07-31 Thread Tom Lane
[ followup to old message ] Greg Stark [EMAIL PROTECTED] writes: This patch adds an autoconf test to check for the new incompatible version of flex. Peter E. claims that CVS tip does work with flex 2.5.31 --- so we shouldn't need this patch anymore. regards, tom lane

Re: [PATCHES] Check for failed memory allocations in libpq

2003-07-31 Thread Tom Lane
Dave Allen [EMAIL PROTECTED] writes: You sure you aren't just trading one misbehavior for another? Apologies if I missed anything, but I thought I fixed any callers of PQmakeEmptyPQresult that weren't already checking (parseInput and getRowDescriptions were the only ones). Well, I'm

[PATCHES] Russian NLS Update: libpq-ru.po

2003-07-31 Thread Serguei Mokhov
Fixed fuzzy transtlations and translated new strigns for 7.4.x. libpq-ru.po libpq-ru.po Description: Binary data ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]

[PATCHES] Added comments to postgresql.conf file

2003-07-31 Thread Troels Arvin
I suggest that the following patch be applied. It adds a few more comments to postgresql.conf. (I always forget what the magic numbers 0 through 2 means for the syslog option.) By the way: The virtual_host parameter is a bad name for that particular option, I think. Virtual host signals that

[PATCHES] Russian NLS Update: psql

2003-07-31 Thread Serguei Mokhov
Attached a complete translation of psql. -s psql-ru.zip psql-ru.zip Description: Zip compressed data ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL

[PATCHES] contrib regression test update

2003-07-31 Thread Joe Conway
Quoting behavior changed in the message that produces, e.g.: NOTICE: type seg is not yet defined This patch updates all the contrib regression tests for the change. Please apply. Thanks, Joe Index: contrib/btree_gist/expected/btree_gist.out

Re: [PATCHES] contrib regression test update

2003-07-31 Thread Tom Lane
Joe Conway [EMAIL PROTECTED] writes: Quoting behavior changed in the message that produces, e.g.: NOTICE: type seg is not yet defined This patch updates all the contrib regression tests for the change. Looks like I noticed that about five minutes before you did ;-). Sorry about the