Re: [PATCHES] ISO 8601 'Time Intervals' of the 'format with time-unit deignators'

2003-09-08 Thread andrew
Is there a way of producing as well as reading this format? Or did I miss something? cheers andrew Ron Mayer said: Short summary: This patch allows ISO 8601 time intervals using the format with time-unit designators to specify postgresql intervals. Below I have (A) What these time

Re: [PATCHES] Minor lmgr code cleanup

2003-09-08 Thread Manfred Koizar
On Mon, 8 Sep 2003 00:51:45 -0400 (EDT), Bruce Momjian [EMAIL PROTECTED] wrote: This has been saved for the 7.5 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 Here is the combined patch. Prior patches in this thread are hereby obsolete. Servus Manfred diff -ruN

Re: [PATCHES] Unixware 713 probs

2003-09-08 Thread Andreas Pflug
Tom Lane wrote: Andreas Pflug [EMAIL PROTECTED] writes: Larry Rosenman wrote: Here's a quickie patch I did to fix it. Patching this or not, if the function's called the backend will SEGV either (at least on my 2.4.20 it does) because a IPV6 address is copied in the memory

[PATCHES] SQLState implementation for V3 Protocol

2003-09-08 Thread Kris Jurka
I've added parsing of the V3 protocol's notice and error messages into its various fields. This replaces the current error message format of: SERRORC42P01Mrelation this_table_doesnt_exist does not existFnamespace.cL193RRangeVarGetRelid with the correct message and allows the programmer to

Re: [PATCHES] mcxt.c

2003-09-08 Thread Gaetano Mendola
Tom Lane [EMAIL PROTECTED] wrote: Mendola Gaetano [EMAIL PROTECTED] writes: A test for null string is missing here: MemoryContextStrdup(MemoryContext context, const char *string) { char *nstr; - - if ( !string ) - { - elog(ERROR, MemoryContextStrdup called with a NULL pointer);

Re: [PATCHES] Minor lmgr code cleanup

2003-09-08 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: This has been saved for the 7.5 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 BTW, that page still calls itself PostgreSQL Items For 7.4. Thanks. Fixed. -- Bruce Momjian|

Re: [PATCHES] Minor lmgr code cleanup

2003-09-08 Thread Bruce Momjian
Manfred, can I get a description for this patch? Thanks. --- Manfred Koizar wrote: On Mon, 8 Sep 2003 00:51:45 -0400 (EDT), Bruce Momjian [EMAIL PROTECTED] wrote: This has been saved for the 7.5 release:

Re: [PATCHES] ISO 8601 Time Intervals of the format with time-unit deignators

2003-09-08 Thread Ron Mayer
Tom wrote: Ron Mayer [EMAIL PROTECTED] writes: Compared to the ISO 8601 time interval specification, the postgresql interval syntax is quite verbose. For example: Postgresql interval: ISO8601 Interval ---

Re: [PATCHES] ISO 8601 'Time Intervals' of the 'format with time-unit deignators'

2003-09-08 Thread Ron Mayer
[EMAIL PROTECTED] wrote: Is there a way of producing as well as reading this format? Or did I miss something? Not yet, but I'd be happy to add it. My immediate problem was having some 'P1Y6M' intervals to load. I posted this much largely because it was useful to me so might help others,

Re: [PATCHES] ISO 8601 Time Intervals of the format with time-unit deignators

2003-09-08 Thread Tom Lane
Ron Mayer [EMAIL PROTECTED] writes: Tom wrote: Er, don't we support that already? Postgresql supports a rather bizzare shorthand that has a similar syntax, but AFAICT, doesn't match ISO 8601 in any way that makes it practical. Well, it's *supposed* to match ISO, AFAICT (the comments in the

Re: [PATCHES] ISO 8601 'Time Intervals' of the 'format with time-unit deignators'

2003-09-08 Thread Tom Lane
Ron Mayer [EMAIL PROTECTED] writes: Would it be useful if I added a 'datestyle' of 'ISO basic' which would produce the most terse formats ('19980115' for dates, and 'P1Y1M' for intervals)? I don't really care for using that name for it --- for one thing, you couldn't do set datestyle

Re: [PATCHES] ISO 8601 Time Intervals of the format with time-unit

2003-09-08 Thread Bruce Momjian
This has been saved for the 7.5 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 Feel free to submit an updated patch that rips out the old syntax, as discussed, or replace this patch with a more comprehensive one.

Re: [PATCHES] ISO 8601 Time Intervals of the format with time-unit

2003-09-08 Thread Bruce Momjian
Tom Lane wrote: Perhaps one could argue that the postgres shorthand should follow the ISO conventions, but I'd not want to break backward compatability, incase someone out there is using '1H30M' and expecting minutes instead of months. I doubt anyone is using it, because it's

Re: [PATCHES] ISO 8601 Time Intervals of the format with time-unit deignators

2003-09-08 Thread Ron Mayer
Tom wrote: Ron Mayer [EMAIL PROTECTED] writes: Tom wrote: Er, don't we support that already? ...AFAICT, doesn't match ISO 8601... Well, it's *supposed* to match ISO Unless ISO has put out multiple specs that cover this? Any way to tell if this is the case. 8601's the one I see

Re: [PATCHES] ISO 8601 Time Intervals of the format with time-unit

2003-09-08 Thread Bruce Momjian
Ron Mayer wrote: If I'm breaking backward compatability anyway, I'd be happy to tweak things like this one too. Unless, of course someone can give me a reason why we want fractional years rounded to months, but fractional months are rounded to fractions of a second. Ron Mayer. PS:

Re: [PATCHES] ISO 8601 'Time Intervals' of the 'format with time-unit

2003-09-08 Thread Peter Eisentraut
Tom Lane writes: Ron Mayer [EMAIL PROTECTED] writes: Would it be useful if I added a 'datestyle' of 'ISO basic' which would produce the most terse formats ('19980115' for dates, and 'P1Y1M' for intervals)? I don't really care for using that name for it --- for one thing, you couldn't do

Re: [PATCHES] ISO 8601 'Time Intervals' of the 'format with time-unit

2003-09-08 Thread Peter Eisentraut
Tom Lane writes: Yes, but by the same token iso8601 isn't specific enough either. Several of the other input formats we support have at least as good a claim on that name. The only input formats we support are along the lines of @ 1 year 2 mons 3 days 4 hours 5 mins 6 secs @ 1 year 2 mons 3

Re: [PATCHES] ISO 8601 'Time Intervals' of the 'format with time-unit deignators'

2003-09-08 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Tom Lane writes: Yes, but by the same token iso8601 isn't specific enough either. Several of the other input formats we support have at least as good a claim on that name. The only input formats we support are along the lines of @ 1 year 2 mons 3

Re: [PATCHES] mcxt.c

2003-09-08 Thread Neil Conway
On Mon, 2003-09-08 at 11:09, Gaetano Mendola wrote: Tom Lane [EMAIL PROTECTED] wrote: I see no value at all in an assert. The code will dump core just fine with or without an assert ... Right but an assert can display information about the file and line number without debug the

Re: [PATCHES] [HACKERS] Index creation takes for ever

2003-09-08 Thread Zeugswetter Andreas SB SD
I don't think so, because the patch does nothing to keep the sort order once the index is initially created. As Tom mentioned, we might not want to keep the tid's in order after the index is created because he wants the most recent tid's first, so the expired ones migrate to the end.

Re: [PATCHES] [HACKERS] Index creation takes for ever

2003-09-08 Thread Manfred Koizar
On Mon, 8 Sep 2003 11:31:05 +0200, Zeugswetter Andreas SB SD [EMAIL PROTECTED] wrote: As Tom mentioned, we might not want to keep the tid's in order after the index is created because he wants the most recent tid's first, so the expired ones migrate to the end. But on average this argument