Re: [PATCHES] Regression test for stats collector

2003-09-12 Thread Manfred Koizar
On Thu, 11 Sep 2003 23:17:13 -0400 (EDT), Bruce Momjian [EMAIL PROTECTED] wrote: The stats collector is on by default (of course, that doesn't apply to make installcheck...) By doing appropriate changes to your installation I guess you can break almost every test ;-) Oh I see now, nice. I

Re: [PATCHES] Regression test for stats collector

2003-09-12 Thread Bruce Momjian
Neil Conway wrote: On Thu, 2003-09-11 at 11:58, Bruce Momjian wrote: Uh, how do you force the stats collector to 'on' before the test is run? The stats collector is on by default (of course, that doesn't apply to make installcheck...) Oh I see now, nice. I didn't realize you could turn

Re: [PATCHES] WIN32_CONSOLE usage

2003-09-12 Thread Bruce Momjian
Christoph Dalitz wrote: @Bruce: --- Could you please already remove the WIN32_CONSOLE and OemToChar/CharToOem stuff from psql? Sorry for the inconvenience generated by my ignorance. Removed. Thanks. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL

[PATCHES] tsearch pfree error

2003-09-12 Thread Nigel J. Andrews
I haven't seen a notice that Bruce noticed this patch I sent across general as part of a rambling thread of mine. There again, I'm not exactly up to date with all my email so could easily have missed it. However, in light of the beta3 notice I'm sending it to the correct list now. Fixes simple

Re: [PATCHES] tsearch pfree error

2003-09-12 Thread Nigel J. Andrews
On Fri, 12 Sep 2003, Bruce Momjian wrote: I hadn't seen this --- not sure why. Probably because it was in a rambling thread consisting mostly of posts by myself. Thanks for applying it chaps. Nigel (Sheesh, all this fuss for a one character change :) ---(end of

Re: [PATCHES] tsearch pfree error

2003-09-12 Thread Bruce Momjian
Nigel J. Andrews wrote: On Fri, 12 Sep 2003, Bruce Momjian wrote: I hadn't seen this --- not sure why. Probably because it was in a rambling thread consisting mostly of posts by myself. Thanks for applying it chaps. I might have assumed the tsearch guys had it handled now that they

Re: [PATCHES] tsearch pfree error

2003-09-12 Thread Bruce Momjian
I hadn't seen this --- not sure why. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. ---

Re: [PATCHES] Reorganization of spinlock defines

2003-09-12 Thread Bruce Momjian
Peter Eisentraut wrote: Bruce Momjian writes: o adds a configure option --without-spinlocks to allow non-spinlock compiles --disable-spinlocks please. I can make the change, but --without seemed to more closely match because it was like readline where you didn't have it, and

Re: [PATCHES] tsearch pfree error

2003-09-12 Thread Nigel J. Andrews
On Fri, 12 Sep 2003, Bruce Momjian wrote: ... I might have assumed the tsearch guys had it handled now that they have CVS access. Good point. I'd completely forgotten I was also expecting them to pick it up, principally because it needs to be applied to the version for running with a 7.3

Re: [HACKERS] [PATCHES] Reorganization of spinlock defines

2003-09-12 Thread Bruce Momjian
Tom Lane wrote: Larry Rosenman [EMAIL PROTECTED] writes: Bruce sent me a copy of the patch, and it BREAKS UnixWare (If y'all= =20 care). Unfixably? Or just a small oversight? I'm actually not worried about platforms that are actively being tested. It's the stuff that hasn't