Re: [PATCHES] Clarify libpq docs

2004-01-26 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Please don't put tabs in SGML files. That's a new one on me. Why should we avoid tabs? The existing files are certainly full of them. regards, tom lane ---(end of broadcast)---

Re: [PATCHES] pltcl - Cache lookup for attribute error - version

2004-01-26 Thread Bruce Momjian
Jan Wieck wrote: Tom Lane wrote: Jan Wieck [EMAIL PROTECTED] writes: When assigning a tuple to an array, PL/Tcl creates one extra array element .tupno telling the SPI_tuptable index of the result tuple. I think I originally planned to have more of these critters ... but probably

Re: [PATCHES] pltcl - Cache lookup for attribute error - version

2004-01-26 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Jan, if I understand correctly, I agree with Tom. It seems strange to add a restriction on indentifiers in pl/tcl that doesn't exist in any of the other interfaces. It's already done --- CVS tip checks specifically for .tupno and not for anything else.

Re: [PATCHES] Clarify libpq docs

2004-01-26 Thread Peter Eisentraut
Tom Lane wrote: Peter Eisentraut [EMAIL PROTECTED] writes: Please don't put tabs in SGML files. That's a new one on me. Why should we avoid tabs? The existing files are certainly full of them. Those are just the files that I haven't edited recently and gave the old M-x untabify

Re: [PATCHES] appendStringInfoString() micro-opt

2004-01-26 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: I'm not objecting to your doing it, exactly, just suggesting that there are better things to spend your time on. Of course, if it makes the code clearer, that is a win in itself. Sure, but I can't see that there's any gain in

Re: [PATCHES] Clarify libpq docs

2004-01-26 Thread Neil Conway
Gavin Sherry [EMAIL PROTECTED] writes: The attached patch clarifies (or, rather, makes explicit) to readers how to handle memory management for char pointers returned by libpq functions. Patch applied. I expanded the tabs in that file to 4 spaces, per the discussion. I also noticed and fixed a

Re: [PATCHES] win32 patch: processCancelRequest/reaper (+ various minor

2004-01-26 Thread Bruce Momjian
Patch applied. Thanks. (No, no one calls SendPostmasterSignal that doesn't have the postmaster as a parent.) --- Claudio Natoli wrote: For application to HEAD, pending community review. Briefly, [all] Removed

Re: [PATCHES] trivial typos

2004-01-26 Thread Bruce Momjian
Patch applied. Thanks. --- Alvaro Herrera wrote: Attached is a patch that fixes some trivial typos and alignment. Please apply. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Siempre hay que alimentar a los dioses,