Re: [PATCHES] pg_generate_sequence and info_schema patch (Was: SELECT

2004-02-04 Thread Christopher Kings-Lynne
I think you can provide a precise specification without losing simplicity of explanation. Maybe something like When step is positive, zero rows are returned if start stop. Conversely, when step is negative, zero rows are returned if start stop. It is an error for step to be zero.

[PATCHES] win32 signals, part 4

2004-02-04 Thread Magnus Hagander
Ok, here we go again. Taking into account Claudios comments on the previous patch, as well as some more fooling around here of my own, here's a fourth (and final?) one. If there are no further comments from Claudio or anyone else, I feel this is now ready to be applied. Differences from last

Re: [PATCHES] [pgsql-hackers-win32] win32 signals, part 4

2004-02-04 Thread Magnus Hagander
Ok, so apparantly I was supposed to attach a file there. //Magnus -Original Message- From: Magnus Hagander Sent: den 4 februari 2004 23:09 To: [EMAIL PROTECTED] Cc: pgsql-hackers-win32; Claudio Natoli Subject: [pgsql-hackers-win32] win32 signals, part 4 Ok, here we go again. Taking

[PATCHES] temp patch for win32 readdir issue

2004-02-04 Thread Magnus Hagander
Ok, so I know this is pretty ugly. But there is a bug in mingw (current release - it's fixed in the snapshot version) with regards to readdir() (see previous mails on win32-hackers). Basically, it doesn't set errno correctly. This patch will catch this error with regards to the readdir(), wrap a

Re: [PATCHES] pg_generate_sequence and info_schema patch (Was: SELECT

2004-02-04 Thread Joe Conway
Christopher Kings-Lynne wrote: Having something that generates a list of dates would be handy, however I guess you can do it with the current series generator by adding that many day intervals to a base date... Seems to work: regression=# select current_date + s.a as dates from

Re: [PATCHES] temp patch for win32 readdir issue

2004-02-04 Thread Magnus Hagander
Oops. Naturally, if this is accepted, the same change needs to be done in xlog.c. I can update the patch if you want me to, or you can jus tmanually copy the code over :) //Magnus -Original Message- From: Magnus Hagander Sent: den 4 februari 2004 23:44 To: [EMAIL PROTECTED] Subject:

Re: [PATCHES] pg_generate_sequence and info_schema patch (Was: SELECT

2004-02-04 Thread Gaetano Mendola
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Joe Conway wrote: | Tom Lane wrote: | | Maybe the best documentation answer is to create a new subsection in the | Functions chapter. This may be our first standard set-returning | function but I bet it will not be the last, so the shortness of the |

Re: [PATCHES] [pgsql-hackers-win32] win32 signals, part 4

2004-02-04 Thread Claudio Natoli
If there are no further comments from Claudio or anyone else, I feel this is now ready to be applied. Code walkthrough looks good. One final minor point to discuss: Is being unable to set a handler for things like CTRL_C_EVENT, CTRL_SHUTDOWN_EVENT etc really a non-fatal error? ISTM

Re: [PATCHES] win32 signals, part 4

2004-02-04 Thread Claudio Natoli
IIRC a separate babysitter thread just to handle message passing is exactly what Katie Ward did for UltraSQL ... the Win32 port done at NuSphere. Glad to see she was right about that. Or Katie and I are both wrong :-P Cheers, Claudio --- Certain disclaimers and policies apply to all

Re: [PATCHES] pg_generate_sequence and info_schema patch (Was: SELECT

2004-02-04 Thread Joe Conway
Gaetano Mendola wrote: select * from generate_series(5,1,-2); I understood on your past posts that instead this result was obtained with: select * from generate_series(5,1,2); ~ generate_series - - ~ 5 ~ 3 ~ 1 (3 rows) Tom objected to the