Re: [PATCHES] Repost: Linking references in documentation

2004-02-17 Thread Neil Conway
Michael Glaesemann [EMAIL PROTECTED] writes: Below is a patch to provide a few links between the former administrator's guide and appropriate reference pages. Patch applied, with some additional changes in the same vein. The actual patch I applied is attached. Thanks for the patch. -Neil

Re: [PATCHES] [pgsql-hackers-win32] win32 setitimer implementation

2004-02-17 Thread Claudio Natoli
Here is a patch that implements setitimer() on win32. With this patch applied, deadlock detection and statement_timeout now works. The file timer.c goes into src/backend/port/win32/. Minor comments: * timer.c has shmem.c in header * I'd suggest Asserts on the remaining 2 limitations

Re: [PATCHES] [pgsql-hackers-win32] win32 setitimer implementation

2004-02-17 Thread Magnus Hagander
Ok, here's an updated timer.c that fixes these concerns and also adds a $postgresql$ header to the file. It also removes the check if value == NULL, since that is now Asserted instead. And it really should never happen based on the places where setitimer is used. The patch stays unchanged, just

Re: [PATCHES] Doing psql's lexing with flex

2004-02-17 Thread Bruce Momjian
Tom Lane wrote: I got interested enough in the psql-with-flex problem to go off and solve it. Attached is a working patch, which I'm now debating whether to apply. Comments solicited... The patch removes about 200 lines of very spaghetti-ish code in mainloop.c. However, it adds an

Re: [PATCHES] Doing psql's lexing with flex

2004-02-17 Thread Neil Conway
Tom Lane [EMAIL PROTECTED] writes: I'm inclined to apply this but I can see where a person not comfortable with flex might feel differently. Opinions? Looks good to me. The psql cleanup is nice, and ISTM that much of the flex code is comments or flex boilerplate anyway, so the actual LOC

Re: [PATCHES] Doing psql's lexing with flex

2004-02-17 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: Tom Lane [EMAIL PROTECTED] writes: I'm inclined to apply this but I can see where a person not comfortable with flex might feel differently. Opinions? Looks good to me. The psql cleanup is nice, and ISTM that much of the flex code is comments or flex

[PATCHES] Crash when calling a pl/pgsql function with no row to pass as an argument

2004-02-17 Thread Chris Campbell
POSTGRESQL BUG REPORT TEMPLATE Your name : Chris Campbell Your email address : [EMAIL

Re: [PATCHES] Doing psql's lexing with flex

2004-02-17 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Am I missing something, or is dollar quoting not in this patch? It is not. If we go this way, then we'd add essentially identical flex patches to backend and psql to implement dollar quoting (plus perhaps a few more lines in psql to support signaling

Re: [PATCHES] Doing psql's lexing with flex

2004-02-17 Thread Peter Eisentraut
Tom Lane wrote: I got interested enough in the psql-with-flex problem to go off and solve it. Attached is a working patch, which I'm now debating whether to apply. Comments solicited... That should teach me a lesson not to leave random comments lying around in the source code. Years later