Re: [PATCHES] [BUGS] BUG #1134: ALTER USER ... RENAME breaks md5

2004-04-27 Thread Fabien COELHO
Dear Bruce, > Yes, the problem is that we used the username for the salt, just like > FreeBSD does for its MD5 passwords. Not that I know of on FreeBSD? shell> uname -a FreeBSD palo-alto2.ensmp.fr 4.9-STABLE FreeBSD 4.9-STABLE #5: Mon Mar 1 21:31:30 CET 2004 [EMAIL PROTECTED]:/usr/src/sys

Re: [PATCHES] [BUGS] BUG #1134: ALTER USER ... RENAME breaks md5

2004-04-27 Thread Bruce Momjian
Fabien COELHO wrote: > > Dear Bruce, > > > Yes, the problem is that we used the username for the salt, just like > > FreeBSD does for its MD5 passwords. > > Not that I know of on FreeBSD? > > shell> uname -a > FreeBSD palo-alto2.ensmp.fr 4.9-STABLE FreeBSD 4.9-STABLE #5: Mon Mar 1 21:31:30 >

Re: [PATCHES] ALTER TABLE...SET WITHOUT CLUSTER

2004-04-27 Thread Bruce Momjian
Christopher Kings-Lynne wrote: > > This patch imlements the TODO that calls for the ability to turn off all > > clustering on a table. > > > > Syntax is ALTER TABLE ... SET WITHOUT CLUSTER; > > > > Doc patch plus regression test is included. > > OK, I have a problem here. This is the new gramm

Re: [PATCHES] ALTER TABLE...SET WITHOUT CLUSTER

2004-04-27 Thread Christopher Kings-Lynne
Even changing the syntax to "qualified_name DROP CLUSTER" doesn't work due to the existence of "relation_expr DROP ...". I have an idea. Change the code to use relation_expr, then throw an error from gram.y if $$->inhOpt != INH_DEFAULT. Yeah, that was the plan. I have been too busy (or too lazy

Re: [PATCHES] [HACKERS] compile warning in CVS HEAD

2004-04-27 Thread Bruce Momjian
Where are we on this patch? There was concern about the malloc() but that can be fixed. --- Andrew Dunstan wrote: > > Patch attached. Also adds a malloc() check that Neil wanted. > > cheers > > andrew > > Tom Lane wrote

Re: [PATCHES] [HACKERS] compile warning in CVS HEAD

2004-04-27 Thread Bruce Momjian
OK, I talked to Andrew via IM and he says it is fixed in CVS. --- Andrew Dunstan wrote: > > Patch attached. Also adds a malloc() check that Neil wanted. > > cheers > > andrew > > Tom Lane wrote: > > >Andrew Dunstan <[EM

[PATCHES] Patch for GUC custom variables

2004-04-27 Thread Thomas Hallgren
Below is my patch addressing the TODO list item "Allow external interfaces to extend the GUC variable set ". It's outlined after the suggestions made by Tom Lane and Joe Conway in this thread: http://archives.postgresql.org/pgsql-hackers/2004-02/msg00229.php Description: A new string variable 'c

Re: [PATCHES] [BUGS] BUG #1134: ALTER USER ... RENAME breaks md5

2004-04-27 Thread Alvaro Herrera
On Tue, Apr 27, 2004 at 09:37:50AM +0200, Fabien COELHO wrote: > Even of the salt is based on the login, the point is that it is stored > separatly, so the system does not rely on the login string to check the > password. > > The only other scheme which requires the user password somehow is the H

[PATCHES] Thread test improvement

2004-04-27 Thread Bruce Momjian
With Peter's help, I have changed the way I do thread testing from configure to be much cleaner. Patch attached and applied. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Rober

Re: [PATCHES] Basic subtransaction facility

2004-04-27 Thread Alvaro Herrera
I wrote ten seconds ago: > This version does. This patch includes both patches I > posted and a few more changes, and does the following: I mean this one. -- Alvaro Herrera () "¿Qué importan los años? Lo que realmente importa es comprobar que a fin de cuentas la mejor edad de la vida es estar

Re: [PATCHES] Basic subtransaction facility

2004-04-27 Thread Alvaro Herrera
On Mon, Apr 26, 2004 at 11:30:16PM -0400, Bruce Momjian wrote: > > Alvaro, where are we on this patch. I think the suggestion was to > throw FATAL rather than add a new error level. > > Is this ready to be applied? I forgot to verify if it worked correctly with #undef SUBTRANSACTIONS --- it di

[PATCHES] Dollar quoting docs, round 1

2004-04-27 Thread David Fetter
Kind people, Please find attached a diff to the SGML docs that attempts to go over the new dollar quoting feature. In eager anticipation of comments & feedback, I remain, Your Humble Servant, D -- David Fetter [EMAIL PROTECTED] http://fetter.org/ phone: +1 510 893 6100 mobile: +1 415 235 3778

[PATCHES] SECURITY DEFINER not being propagated...

2004-04-27 Thread Sean Chittenden
This one's simple enough to reproduce (see SQL script below), but, there are some comments in src/backend/catalog/namespace.c that seem questionable and incorrect: ## BEGIN ## /* * First, do permission check to see if we are authorized to make temp * tables. We us

Re: [PATCHES] Basic subtransaction facility

2004-04-27 Thread Bruce Momjian
[ Tom will review.] Description from previous patch added to patched queue too. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. -

Re: [PATCHES] SECURITY DEFINER not being propagated...

2004-04-27 Thread Tom Lane
Sean Chittenden <[EMAIL PROTECTED]> writes: > This one's simple enough to reproduce (see SQL script below), but, > there are some comments in src/backend/catalog/namespace.c that seem > questionable and incorrect: The proposed patch reverts a change deliberately applied in namespace.c rev 1.15 (

Re: [PATCHES] Dollar quoting docs, round 1

2004-04-27 Thread Peter Eisentraut
David Fetter wrote: > Kind people, > > Please find attached a diff to the SGML docs that attempts to go over > the new dollar quoting feature. I think we should just use $$ in each case. Otherwise it might look more complicated than before. ---(end of broadcast)