On Thu, Apr 29, 2004 at 11:21:53PM +0100, Simon Riggs wrote:
> ...my patch building experience is less than some might
> expect so there are various possible annoyances here. I am on hand to
> help and to learn by my mistakes.
I see you attached one patch for every file ... this works, but is err
On Thu, Apr 29, 2004 at 09:58:49PM -0400, Alvaro Herrera wrote:
> Note that sometimes I do things incrementally, so I do "incremental
> diffs" by commands like
> cd /home/alvherre/CVS/pgsql/source
> diff -cr --exclude-from=ignore-diff 01xact 02blahblah
^^^
Note that this should be -Ncr --
I have added this to CVS under src/timezone and have integrated this into
configure.
However, I am getting a compile error, probably because my OS has a
timezone function defined in time.h:
gcc -O2 -fno-strict-aliasing -Wall -Wmissing-prototypes
-Wmissing-declarations -O1
Neil Conway <[EMAIL PROTECTED]> writes:
> The attached patch implements the width_bucket() function (as specified
> by Section 6.27 of the SQL2003 standard, in particular page 250 in my
> copy).
Other than "it's in SQL2003", what's the point of implementing this?
It seems like a mighty marginal
Bruce Momjian <[EMAIL PROTECTED]> writes:
> /usr/include/time.h:104: `pg_timezone' redeclared as different kind of
> symbol
Your really defines "pg_timezone"?? I'm wondering if this is
an indirect effect of a macro naming collision.
regards, tom lane
---
Other than "it's in SQL2003", what's the point of implementing this?
It seems like a mighty marginal feature ...
I don't see a problem with implementing every function that SQL2003
has...isn't that the point of implementing the standard?
Chris
---(end of broadcast)
On 30-Apr-04, at 1:06 AM, Tom Lane wrote:
Other than "it's in SQL2003", what's the point of implementing this?
No idea, but it doesn't really matter IMHO: it is in SQL2003, it
doesn't interfere with the rest of the system or impose a significant
maintenance burden and it has essentially zero nega
Bruce Momjian wrote:
> I have added this to CVS under src/timezone and have integrated this
> into configure.
I think it would be better to put it under one of the generic
subdirectories, such as src/utils/timezone. We may have to add
additional libraries of this kind in the future, and it woul
Without any rationale as to why CREATE TEMP TABLEs checks the session
user in the archives, could we open this up for discussion again?
Well, let me put it this way: if you want to change the behavior you're
going to have to work much harder than just reverting the prior patch.
IIRC the fundamental
On Wed, 28 Apr 2004 12:02:44 -0400, Alvaro Herrera
<[EMAIL PROTECTED]> wrote:
>In fact, I think we should mark ERROR as aborting the whole transaction
>tree, and create a new level which would abort the innermost
>subtransaction. We would then change whatever is appropiate to the new
>elevel. Doi
Manfred Koizar wrote:
> On Wed, 28 Apr 2004 12:02:44 -0400, Alvaro Herrera
> <[EMAIL PROTECTED]> wrote:
> >In fact, I think we should mark ERROR as aborting the whole transaction
> >tree, and create a new level which would abort the innermost
> >subtransaction. We would then change whatever is app
Bruce Momjian wrote:
> I think his point was that there are some errors that should abort
> the outer transaction too. I think Alvaro mentioned out of memory,
> but that is a FATAL error. Alvaro, what error were you thinking of
> that should abort the outer transaction?
Theoretically, if you abo
Bruce Momjian <[EMAIL PROTECTED]> writes:
> Manfred Koizar wrote:
>> Why? Subtransaction commit propagates an error state to the parent
>> transaction. And if a subtransaction is rolled back the parent can
>> continue cleanly no matter what was the reason for the subtrans abort.
> I think his po
Sean Chittenden <[EMAIL PROTECTED]> writes:
> I think the attached patch addresses both of your concerns.
Perhaps something like this will work, but the patch as given can't
possibly be right (or have been tested with any care):
> + aclresult = pg_namespace_aclcheck(MyDatabaseId, Ge
On Thu, Apr 29, 2004 at 12:26:01AM -0400, Bruce Momjian wrote:
> I don't understand your elog(ERROR) vs. ereport(ERROR) distinction. Was
> that a typo?
Nope. When Tom upgraded the error handling, he changed almost
everything to ereport(), but in the places where there's a violation of
expected
On Thu, Apr 29, 2004 at 02:42:23PM -0400, Tom Lane wrote:
> In general I tend to agree with Manfred's point: if you have reason to
> suspect global corruption of a backend's state then you should do FATAL
> (or possibly PANIC). If you do not suspect this then you ought to just
> ERROR. I do not
On Thu, Apr 29, 2004 at 07:29:07PM +0200, Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > I think his point was that there are some errors that should abort
> > the outer transaction too. I think Alvaro mentioned out of memory,
> > but that is a FATAL error. Alvaro, what error were you thinkin
On Thu, Apr 29, 2004 at 06:42:31PM +0200, Manfred Koizar wrote:
> On Wed, 28 Apr 2004 12:02:44 -0400, Alvaro Herrera
> <[EMAIL PROTECTED]> wrote:
> >In fact, I think we should mark ERROR as aborting the whole transaction
> >tree, and create a new level which would abort the innermost
> >subtransact
Full set of patches, including both earlier reported bugs fixed.
This note was originally posted at Tue, 27 Apr 2004 23:30:39 +0100, but
for some reason hasn't yet appeared on the [HACKERS] list, so I am now
reposting this. Trying PATCHES list now...
Full usage instructions (for TESTING only!)
On Sun, 2004-04-25 at 19:06, Alvaro Herrera wrote:
> Hackers,
>
> This patch adds subtransaction support into the storage manager. Files
> created or dropped inside a subtransaction are correctly dealt with at
> subtransaction commit or abort.
> - pg_clog/pg_subtrans. Need a solution.
>
>
> P
Here's the patch as an attachement instead. The previous one got corrupted.
Pasting a patch into a mail seems to be a really bad idea...
- thomas
Index: doc/src/sgml/runtime.sgml
===
RCS file: /projects/cvsroot/pgsql-server/doc/src/sg
I think the attached patch addresses both of your concerns.
Perhaps something like this will work, but the patch as given can't
possibly be right (or have been tested with any care):
Not tested in the slightest, actually. The attached has been, however
is commented and tested.
A larger problem i
Simon Riggs wrote:
> On Sun, 2004-04-25 at 19:06, Alvaro Herrera wrote:
> > Hackers,
> >
> > This patch adds subtransaction support into the storage manager. Files
> > created or dropped inside a subtransaction are correctly dealt with at
> > subtransaction commit or abort.
>
> > - pg_clog/pg_su
23 matches
Mail list logo
