Re: [PATCHES] pg_autovacuum integration attempt #2

2004-07-12 Thread Peter Eisentraut
Bruce Momjian wrote: I have added this patch plus your later comments to the patch queue. The autovacuum process still uses libpq to send its queries, which is not the idea behind backend integration. Your patch has been added to the PostgreSQL unapplied patches list at:

Re: [PATCHES] pg_autovacuum integration attempt #2

2004-07-12 Thread Andreas Pflug
Peter Eisentraut wrote: Bruce Momjian wrote: I have added this patch plus your later comments to the patch queue. The autovacuum process still uses libpq to send its queries, which is not the idea behind backend integration. Can we consider this a non-fatal bug that has to be solved

[PATCHES] Show tablespace name in pg_tables and pg_indexes

2004-07-12 Thread Klaus Naumann
Hi, the attached patch shows the new column tablespace in the mentioned views. Apply with ~/pgsql$ patch -p1 03_showtblspc.diff Greetings, Klaus -- Full Name : Klaus Naumann | (http://www.mgnet.de/) (Germany) Phone / FAX : ++49/177/7862964 | E-Mail: ([EMAIL PROTECTED])diff -Ncr

Re: [PATCHES] Show tablespace name in pg_tables and pg_indexes

2004-07-12 Thread Klaus Naumann
On Mon, 12 Jul 2004, Klaus Naumann wrote: Hi, sorry, the last patch is buggy which didn't show up in the tests :( Two LEFTs were missing - new patch is attached. Greetings, Klaus Hi, the attached patch shows the new column tablespace in the mentioned views. Apply with ~/pgsql$ patch

Re: [PATCHES] [PATCH] fix libpq mutex initialization for multithreaded

2004-07-12 Thread Bruce Momjian
Patch applied. Thanks. --- Manfred Spraul wrote: Hi, win32 doesn't support a static initializer for mutexes, thus the first user must initialize the lock. The problem are concurrent first users - the

Re: [PATCHES] plperl fixes

2004-07-12 Thread Bruce Momjian
Patch applied. Thanks. --- Andrew Dunstan wrote: The attached patch, which incorporates the previous one sent and currently unapplied regarding spi_internal.c, makes some additional fixes relating to return types,

Re: [PATCHES] pg_autovacuum integration attempt #2

2004-07-12 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: The autovacuum process still uses libpq to send its queries, which is not the idea behind backend integration. Sure, but one step at a time. Getting it auto-launched from the postmaster is already a good increment in usability, and offhand I don't

Re: [PATCHES] add missing options to pg_dumpall

2004-07-12 Thread Bruce Momjian
Patch applied. Thanks. --- Christopher Kings-Lynne wrote: Hi, This patch adds the following options to pg_dumpall, to be passed to pg_dump: -S, --superuser=NAME -O, --no-owner -X disable-dollar-quoting,

Re: [PATCHES] pg_autovacuum integration attempt #2

2004-07-12 Thread Matthew T. O'Connor
Peter Eisentraut wrote: Bruce Momjian wrote: I have added this patch plus your later comments to the patch queue. The autovacuum process still uses libpq to send its queries, which is not the idea behind backend integration. Actually, I intentionally had pg_autovacuum continue to use libpq based

Re: [PATCHES] pg_autovacuum integration attempt #2

2004-07-12 Thread Tom Lane
Matthew T. O'Connor [EMAIL PROTECTED] writes: Actually, I intentionally had pg_autovacuum continue to use libpq based Tom's advise. Please see this thread: http://archives.postgresql.org/pgsql-hackers/2004-03/msg00931.php And more specifically, these follow ups:

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Bruce Momjian
Alvaro, you call GetParentTransactionId(), but I see not definition for it in the code. --- Alvaro Herrera wrote: An untested patch to update the password file. Something that bugged me a lot is that I tried to find the

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Alvaro Herrera
On Mon, Jul 12, 2004 at 12:05:40PM -0400, Bruce Momjian wrote: Alvaro, you call GetParentTransactionId(), but I see not definition for it in the code. Let me include this patch in the next patch I'll submit shortly. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) I suspect most samba

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Bruce Momjian
OK. Also, I would like you to post a list of the open items you have so we can all know the status. --- Alvaro Herrera wrote: On Mon, Jul 12, 2004 at 12:05:40PM -0400, Bruce Momjian wrote: Alvaro, you call

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Bruce Momjian
Patch withdrawn by author. --- Alvaro Herrera wrote: An untested patch to update the password file. Something that bugged me a lot is that I tried to find the format of the file for testing the patch, and I couldn't

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Alvaro, you call GetParentTransactionId(), but I see not definition for it in the code. It looks like Alvaro forgot to include diffs for xact.c in that patch. I imagine what he had in mind was to add such a function to xact.c. I would like to counsel

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Alvaro, you call GetParentTransactionId(), but I see not definition for it in the code. It looks like Alvaro forgot to include diffs for xact.c in that patch. I imagine what he had in mind was to add such a function to xact.c. I

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Bruce Momjian
OK, but why would we document the contents of a file that are not to be modified by the user? --- Alvaro Herrera wrote: On Mon, Jul 12, 2004 at 02:18:40PM -0400, Bruce Momjian wrote: Something that bugged me a lot is

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Alvaro Herrera
On Mon, Jul 12, 2004 at 02:18:40PM -0400, Bruce Momjian wrote: Something that bugged me a lot is that I tried to find the format of the file for testing the patch, and I couldn't find anything anywhere in the docs. Apparently the docs for the file were ripped with the docs for the

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: OK, but why would we document the contents of a file that are not to be modified by the user? Also note that the 7.2 docs are out of date anyway (looks to me like we use spaces not colons as column separators...) regards, tom lane

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Alvaro Herrera
On Mon, Jul 12, 2004 at 02:31:37PM -0400, Bruce Momjian wrote: OK, but why would we document the contents of a file that are not to be modified by the user? But how is the file used? Where do I put the file, what do I put in pg_hba.conf to use the file? Can I have several files, one per

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Bruce Momjian
Alvaro Herrera wrote: On Mon, Jul 12, 2004 at 02:31:37PM -0400, Bruce Momjian wrote: OK, but why would we document the contents of a file that are not to be modified by the user? But how is the file used? Where do I put the file, what do I put in pg_hba.conf to use the file? Can I

[PATCHES] More canonicalization fixes

2004-07-12 Thread Bruce Momjian
I just applied this new version of canonicalize_path(): /* * Make all paths look like Unix */ void canonicalize_path(char *path) { #ifdef WIN32 /* * The Windows command processor will accept suitably quoted

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: But how is the file used? Where do I put the file, what do I put in pg_hba.conf to use the file? Can I have several files, one per pg_hba.conf entry? Can I use multiple files with a single pg_hba.conf entry? What happens if I have a username that

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Alvaro Herrera
On Mon, Jul 12, 2004 at 03:19:43PM -0400, Bruce Momjian wrote: Alvaro Herrera wrote: On Mon, Jul 12, 2004 at 02:31:37PM -0400, Bruce Momjian wrote: OK, but why would we document the contents of a file that are not to be modified by the user? But how is the file used? Where do I

Re: [PATCHES] patch for different join result order on regression test

2004-07-12 Thread Bruce Momjian
Done. --- Andrew Dunstan wrote: Andrew Dunstan wrote: This resultmap patch and regression test result file allow the join regression test to succeed under Mingw. Could someone please add the join result I

Re: [PATCHES] has_tablespace_privilege #2

2004-07-12 Thread Bruce Momjian
Patch applied. Thanks. --- Christopher Kings-Lynne wrote: Sorry - the last version didn't make all the necessary doc changes. Apply this instead. Chris [ application/x-gzip is not supported, skipping... ]

Re: [PATCHES] Include tablespace information in psql \d footers

2004-07-12 Thread Bruce Momjian
Patch applied. Thanks. I removed the display of tablespaces for sequences and toast tables: test= \d test Table public.test Column | Type | Modifiers +-+--- x | integer | test= \d test2

[PATCHES] Remove confusing commented-defaullts from postgresql.conf

2004-07-12 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 NotDashEscaped: You need GnuPG to verify this message I know we never reached a full consensus on hackers about the full solution to the postgresql.conf file, but I think everyone agreed that having commented-out default values was a bad thing,

Re: [PATCHES] Include tablespace information in psql \d footers

2004-07-12 Thread Bruce Momjian
Bruce Momjian wrote: Patch applied. Thanks. I removed the display of tablespaces for sequences and toast tables: test= \d test Table public.test Column | Type | Modifiers +-+--- x | integer |

Re: [PATCHES] Remove confusing commented-defaullts from postgresql.conf

2004-07-12 Thread Bruce Momjian
Uh, it is my understanding that all lines can't be uncommented. Some of the lines have defaults that are computed, like fsync_method. Anyway, we are too busy to consider this for 7.5 unless someone wants to research all these issues.

Re: [PATCHES] pg_dump owner and acl fix #2

2004-07-12 Thread Bruce Momjian
Patch applied. Thanks. Change pg_dump to use ALTER OWNER commands instead of SET SESSION AUTHORIZATION commands by default. Move all GRANT and REVOKE commands to the end of the dump to avoid restore failures in several situations. Bring back --use-set-session-authorization option to get

Re: [PATCHES] Include tablespace information in psql \d footers

2004-07-12 Thread Gavin Sherry
On Mon, 12 Jul 2004, Bruce Momjian wrote: Bruce Momjian wrote: Patch applied. Thanks. I removed the display of tablespaces for sequences and toast tables: test= \d test Table public.test Column | Type | Modifiers +-+--- x

Re: [PATCHES] Remove confusing commented-defaullts from postgresql.conf

2004-07-12 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Uh, it is my understanding that all lines can't be uncommented. Some of the lines have defaults that are computed, like fsync_method. Yes, fsync_method shouldn't be uncommented unless you're prepared to put in the same default value presently computed in