Re: [PATCHES] Epoch to timestamp conversion function patch

2004-08-04 Thread Tom Lane
Michael Glaesemann <[EMAIL PROTECTED]> writes: > Please find attached two patches (one for pg_proc.h and another for > supporting documentation) for two SQL functions: > epoch_to_timestamp(integer) and epoch_to_timestamptz(double precision), > which convert from UNIX epoch to the native PostgreS

Re: [PATCHES] More fixes for pg_dump

2004-08-04 Thread Tom Lane
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > This patch does two things to pg_dump: > * Dumps comments on columns of composite types > * Instead of putting all the OWNER TO commands at the end, it dumps then > after each object. This is WAY more readable and nice. ACLs are still > at

Re: [PATCHES] [BUGS] casting strings to multidimensional arrays yields strange

2004-08-04 Thread Joe Conway
Tom Lane wrote: [ cc'ing pghackers in case anyone wants to object ] Joe Conway <[EMAIL PROTECTED]> writes: I think that even once we support NULL array elements, they should be explicitly requested -- i.e. throwing an error on non-rectangular input is still the right thing to do. I haven't sugges

Re: [PATCHES] [BUGS] casting strings to multidimensional arrays yields strange results

2004-08-04 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > Negative lower bound indicies now work also, and array_out will always > output explicit dimensions for an array with any dimension having a > lower bound of other than one. Seems reasonable to me. > Any thoughts on whether or not to apply this to 7.4?

Re: [PATCHES] [BUGS] casting strings to multidimensional arrays yields strange results

2004-08-04 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > If there are no objections, I'll adjust the appropriate regression > script/expected files and commit tonight. And of course I'll follow up > with documentation updates too. BTW, I believe the plan is to wrap 8.0beta1 tomorrow, so please do get this in to

Re: [PATCHES] [BUGS] casting strings to multidimensional arrays yields strange

2004-08-04 Thread Joe Conway
Tom Lane wrote: Joe Conway <[EMAIL PROTECTED]> writes: If there are no objections, I'll adjust the appropriate regression script/expected files and commit tonight. And of course I'll follow up with documentation updates too. BTW, I believe the plan is to wrap 8.0beta1 tomorrow, so please do get t

Re: [PATCHES] More fixes for pg_dump

2004-08-04 Thread Bruce Momjian
Tom Lane wrote: > Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > > This patch does two things to pg_dump: > > > * Dumps comments on columns of composite types > > > * Instead of putting all the OWNER TO commands at the end, it dumps then > > after each object. This is WAY more readable a

[PATCHES] logger subprocess including win32

2004-08-04 Thread Andreas Pflug
Attached the patch, an orgy in #ifdefs, decorated with various indents and crlf line ends (glad we have pgindent). Remarks: Log_destination for win32 is set to file, because stderr is equivalent to /dev/null for services. This doesn't reflect correctly in postgresql.conf.sample. Log_destinatio

Re: [PATCHES] [HACKERS] compile warnings

2004-08-04 Thread Joe Conway
Joe Conway wrote: Tom Lane wrote: Joe Conway <[EMAIL PROTECTED]> writes: In addition to the ecpg warnings mentioned by Tom, I'm also seeing compile warnings wrt plpython: This is surely not a "must fix tomorrow" issue, but please look into it when you get back from your road trip. I find that simp

Re: [PATCHES] More fixes for pg_dump

2004-08-04 Thread Christopher Kings-Lynne
Applied. I notice though that the line numbers don't seem to match CVS tip, which suggests that you've got some patches still unapplied? If so, Bruce seems to have missed adding them to the patch queue. Hmmm, no... Not sure what happened there. The diff in the committers email seemed fine howe

[PATCHES] Allow semicolons in psql \h strings

2004-08-04 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 NotDashEscaped: You need GnuPG to verify this message A minor itch I finally got around to scratching: allow semicolons at the end of help topics (also bump copyright years (should really be done for all files)) -- Greg Sabino Mullane [EMAIL PROT

[PATCHES] Minor BEFORE DELETE trigger fix

2004-08-04 Thread Gavin Sherry
Attached is a minor patch to make BEFORE DELETE triggers honour tgenabled properly. I know that we cannot, currently, use this feature through a DDL command but just in case someone is updating the catalogs to do it and since it is necessary in order to implement disabling of triggers, I thought I

Re: [PATCHES] Allow semicolons in psql \h strings

2004-08-04 Thread Tom Lane
"Greg Sabino Mullane" <[EMAIL PROTECTED]> writes: > (also bump copyright years (should really be done for all files)) Bruce has a script for that. regards, tom lane ---(end of broadcast)--- TIP 3: if posting/reading through

Re: [PATCHES] [BUGS] casting strings to multidimensional arrays yields strange results

2004-08-04 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > OK, this is done, but there is still an ugly bug in there (i.e. was > there prior to my just committed changes and still exists) somewhere > that I noticed while modifying domain.sql. Namely, if you forget to put > a delimiter inbetween subarrays in a mul

Re: [PATCHES] [BUGS] casting strings to multidimensional arrays yields strange

2004-08-04 Thread Joe Conway
Tom Lane wrote: I had pretty much come to the conclusion that the array_in code should be thrown away and rewritten from the ground up --- whoever wrote it originally had no calling as a programmer :-(. I didn't look at the details of your patch, but I have little faith in half measures in this ar

Re: [PATCHES] [BUGS] casting strings to multidimensional arrays yields strange results

2004-08-04 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > While looking at it the last day or so, I started to think it might be > better to use bison to parse array literals -- or is that a bad idea? Offhand it doesn't seem like a super-appropriate tool. Once you get past the lexical details like quoting, the s

Re: [PATCHES] Epoch to timestamp conversion function patch

2004-08-04 Thread Michael Glaesemann
On Aug 5, 2004, at 2:03 AM, Tom Lane wrote: I'd suggest just one function epoch_to_timestamp that actually yields timestamptz, and then if casting the result to timestamp is needed it'll happen automatically. That makes sense. Chris mentioned the possibility of using the MySQL FROM_UNIXTIME() syn

Re: [PATCHES] [BUGS] casting strings to multidimensional arrays yields strange

2004-08-04 Thread Joe Conway
Tom Lane wrote: Joe Conway <[EMAIL PROTECTED]> writes: While looking at it the last day or so, I started to think it might be better to use bison to parse array literals -- or is that a bad idea? Offhand it doesn't seem like a super-appropriate tool. Once you get past the lexical details like quo