Re: [PATCHES] Win32 tablespace

2004-08-08 Thread markir
It was, next update got it! Of course I found the src/utils issue then However, with the patch for that applied I can confirm a successful build! (create/drop tablespace works too) regards Mark Quoting Bruce Momjian <[EMAIL PROTECTED]>: > > Nope, you need Makefile 1.15. Must be a lag. >

Re: [PATCHES] Win32 tablespace

2004-08-08 Thread Andreas Pflug
[EMAIL PROTECTED] wrote: (create/drop tablespace works too) I can *not* confirm this; after configure; make clean; make; make install I got "tablespace not supported". pg_config.h lacks HAVE_SYMLINK=1. Regards, Andreas ---(end of broadcast)--- TIP 8

Re: [PATCHES] Win32 tablespace

2004-08-08 Thread markir
Interesting, After repeating 'make distclean;./configure --without-zlib' I have a pg_config.h *with* HAVE_SYMLINK=1. (To cover all the bases, adding in zlib support still results in HAVE_SYMLINK=1 for me) At this point, sleeping seems quite attractive... regards Mark Quoting Andreas Pflug <[E

Re: [PATCHES] Win32 fix for pg_dumpall

2004-08-08 Thread Andrew Dunstan
Bruce Momjian wrote: /* + * Sometime the child returns "\r\n", which doesn't match + * our version string. The backend uses + * setvbuf(stdout, NULL, _IONBF, 0), but pg_dump doesn't + * so we have to fix it here. + */ + if (strlen(line) >= 2 && + line[strlen(line)

Re: [PATCHES] Win32 tablespace

2004-08-08 Thread Bruce Momjian
[EMAIL PROTECTED] wrote: > Interesting, > > After repeating 'make distclean;./configure --without-zlib' I have a > pg_config.h *with* HAVE_SYMLINK=1. Right, symlinks are supported in Win32 now. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED]

Re: [PATCHES] Win32 tablespace

2004-08-08 Thread Bruce Momjian
[EMAIL PROTECTED] wrote: > It was, next update got it! Of course I found the src/utils issue then > > However, with the patch for that applied I can confirm a successful build! What patch is that? -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED]

Re: [PATCHES] Win32 tablespace

2004-08-08 Thread Bruce Momjian
Andreas Pflug wrote: > [EMAIL PROTECTED] wrote: > > > > (create/drop tablespace works too) > > I can *not* confirm this; after configure; make clean; make; make > install I got "tablespace not supported". pg_config.h lacks HAVE_SYMLINK=1. I am confused. We have something in configure that forc

Re: [PATCHES] Win32 fix for pg_dumpall

2004-08-08 Thread Bruce Momjian
Andrew Dunstan wrote: > > > Bruce Momjian wrote: > > > > > /* > >+ * Sometime the child returns "\r\n", which doesn't match > >+ * our version string. The backend uses > >+ * setvbuf(stdout, NULL, _

Re: [PATCHES] Win32 tablespace

2004-08-08 Thread Andreas Pflug
[EMAIL PROTECTED] wrote: Interesting, After repeating 'make distclean;./configure --without-zlib' I have a pg_config.h *with* HAVE_SYMLINK=1. Sorry, mea culpa. I did a simple clean, not a distclean. Works ok. Regards, Andreas ---(end of broadcast)---

Re: [PATCHES] Win32 tablespace

2004-08-08 Thread Bruce Momjian
Andreas Pflug wrote: > [EMAIL PROTECTED] wrote: > > Interesting, > > > > After repeating 'make distclean;./configure --without-zlib' I have a > > pg_config.h *with* HAVE_SYMLINK=1. > > > > Sorry, mea culpa. I did a simple clean, not a distclean. Works ok. Perfect! I didn't think distclean wou

Re: [PATCHES] Win32 tablespace

2004-08-08 Thread Mark Kirkwood
Sorry Bruce - I meant your 'fix for win32 pgport and pg_dumpall' patch. Mark Bruce Momjian wrote: [EMAIL PROTECTED] wrote: It was, next update got it! Of course I found the src/utils issue then However, with the patch for that applied I can confirm a successful build! What patch is that

[PATCHES] psql - missing tab-completion support for tablespaces

2004-08-08 Thread Stefan Kaltenbrunner
Hi! While playing around with 8.0devel I found it somewhat irritating that psql had no tab-complete support for all tablespace related commands. Attached is my own poor attempt that adds at least basic support for CREATE/ALTER/DROP and \db. When looking through the code I found that there seem t

Re: [PATCHES] Patch for Array min() / max()

2004-08-08 Thread Koju Iijima
> Bruce Momjian wrote: > > May I have a context diff please, diff -c? > > > > As this is new functionality, I presume it will be held for 8.1, > correct? In any case, you can put my name on it for review. > > Joe Hi ! I updated the patch for array min()/ma

Re: [PATCHES] Patch for Array min() / max()

2004-08-08 Thread Bruce Momjian
This has been saved for the 8.1 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 --- Koju Iijima wrote: > > > Bruce Momjian wrote: > > > May I have a context diff please, diff -c? > > > > > > > As this is

Re: [PATCHES] psql - missing tab-completion support for tablespaces

2004-08-08 Thread Bruce Momjian
Stefan Kaltenbrunner wrote: > When looking through the code I found that there seem to be much more > places where the tabcomplete-code is not 100% in sync with what the > doc's show as possible syntax. > Is there interest in fixing those up (ie qualifing as BUGS that can get > fixed during BETA) ?