Re: [PATCHES] log_filename_prefix -- log_filename + strftime()

2004-08-28 Thread Andreas Pflug
Tom Lane wrote: It's definitely creeping featurism ... but I can see the value of not needing any cron daemon to remove old logs. No other logs on your system to purge? A potential problem is what about size-driven rotation? If the hourly output exceeds log_rotation_size then you'd truncate and

Re: [PATCHES] log_filename_prefix -- log_filename + strftime()

2004-08-28 Thread Tom Lane
Andreas Pflug [EMAIL PROTECTED] writes: Tom Lane wrote: I can see the value of not needing any cron daemon to remove old logs. No other logs on your system to purge? The DBA isn't necessarily also root. regards, tom lane ---(end of

Re: [PATCHES] [SQL] array_in: '{}}'::text[]

2004-08-28 Thread Joe Conway
Tom Lane wrote: actually, why isn't this just a pstrdup? Why not just if (strcmp(str, {}) == 0) Good points. Changes made, and attached committed. Joe Index: src/backend/utils/adt/arrayfuncs.c === RCS file:

Re: [PATCHES] [SQL] array_in: '{}}'::text[]

2004-08-28 Thread Markus Bertheau
, 28.08.2004, 21:33, Joe Conway : /* special case for an empty array */ ! if (strcmp(str, {}) == 0) return 0; Without looking at the code in a whole, you accept '{} ' as an empty array literal, so why is the special case for '{}' needed here? I should be catched by

Re: [PATCHES] Win32 fix: Token buffer

2004-08-28 Thread Bruce Momjian
Patch applied. Thanks. --- Magnus Hagander wrote: This patch fixes the open item: o use dynamic buffer for token buffer in win32 admin check //Magnus Content-Description: token_buffer.patch [ Attachment,

Re: [PATCHES] [pgsql-hackers-win32] Service startup delay

2004-08-28 Thread Bruce Momjian
Patch applied. Thanks. --- Dave Page wrote: -Original Message- From: Bruce Momjian [mailto:[EMAIL PROTECTED] Sent: 26 August 2004 02:44 To: Max Dunn Cc: Dave Page; 'Barry Lind'; [EMAIL PROTECTED]

Re: [PATCHES] [SQL] array_in: '{}}'::text[]

2004-08-28 Thread Joe Conway
Markus Bertheau wrote: Without looking at the code in a whole, you accept '{} ' as an empty array literal, so why is the special case for '{}' needed here? It's a fast path for a common special case. Why spend any cycles parsing if we can immediately recognize it? However, anything other than a

Re: [PATCHES] [BUGS] BUG #1219: pgxs does not work fully

2004-08-28 Thread Bruce Momjian
Patch applied. Thanks. --- Fabien COELHO wrote: Am Dienstag, 17. August 2004 14:26 schrieb Fabien COELHO: The patch adds missing the libpgport.a file to the installation under install-all-headers. It is needed

Re: [PATCHES] Service control enhancements

2004-08-28 Thread Bruce Momjian
Patch applied. Thanks. --- Dave Page wrote: The attached patch improves pg_ctl's win32 service code to eliminate some possible causes of the stale postmaster.pid problem that some users have reported. - The service

Re: [PATCHES] cygwin 8.0.0beta1 postmaster/syslogger.c, port/dirmod.c,

2004-08-28 Thread Bruce Momjian
Your patch highlighted several bugs in our code. First, I wasn't testing for CYGWIN in the backend pgport_palloc code. Second, I added an #undef to prevent compiler warnings. Third I added your Cygwin includes with an #ifdef. These will appear in beta2. On the timezone issue, I see this in

Re: [PATCHES] add hint

2004-08-28 Thread Bruce Momjian
Patch applied. Thanks. --- James William Pye wrote: -- Start of PGP signed section. On Wed, 2004-08-25 at 13:11, Tom Lane wrote: It'd be even better if it followed the message style guidelines... Indeed. I was

Re: [PATCHES] log_line_prefix additions

2004-08-28 Thread Bruce Momjian
This has been saved for the 8.1 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 --- Ed L. wrote: This patch against 8.0.0beta1 source adds log_line_prefix options for millisecond timestamps (%m),

Re: [PATCHES] Win32 bug fix

2004-08-28 Thread Bruce Momjian
Patch applied. Thanks. --- Claudio Natoli wrote: Could someone please eyeball the attached patch for errors and as a correction for: http://archives.postgresql.org/pgsql-bugs/2004-08/msg00307.php Also, could

Re: [PATCHES] log_filename_prefix -- log_filename + strftime()

2004-08-28 Thread Bruce Momjian
Are we going to change this before beta2? I have not seen a final patch yet. --- Ed L. wrote: Attached is a patch which replaces the 'log_filename_prefix' configuration directive with a similar 'log_filename' directive.