Re: [PATCHES] pgxs default installation + various fixes

2004-09-12 Thread Bruce Momjian
Well, we don't have forever to wait on this, and I don't plan to require patches to be held until one specific person can review them. Fabien, which version is your best? I will put it in the patch queue. --- Fabien

[PATCHES] New Translation

2004-09-12 Thread eetemadi
hello, we are starting a new language translation in postgresql. I send the pg_controldata message translation in Farsi language. I sended it to the Peter Eisentraut with the name fa_IR.po. He said that Is there any use of fa outside of IR? Else I would just call the translation files fa.po.

Re: [PATCHES] [pgsql-hackers-win32] VC++ psql build broken

2004-09-12 Thread Bruce Momjian
How does your Win32 system rename prototype differ from what is in port.h? extern int pgrename(const char *from, const char *to); extern int pgunlink(const char *path); Good question on wether we need to keep this working but it would be nice to keep it I guess for client-only

Re: [PATCHES] New Translation

2004-09-12 Thread Andreas Pflug
[EMAIL PROTECTED] wrote: hello, we are starting a new language translation in postgresql. I send the pg_controldata message translation in Farsi language. I sended it to the Peter Eisentraut with the name fa_IR.po. He said that Is there any use of fa outside of IR? Else I would just call the

Re: [PATCHES] pgxs default installation + various fixes

2004-09-12 Thread Peter Eisentraut
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Where are we on this? I think we're waiting on Peter to review it. I have no technical issue with the patch, except that as I have previously mentioned, I don't particularly care for what it does. -- Peter Eisentraut

Re: [PATCHES] [pgsql-hackers-win32] VC++ psql build broken

2004-09-12 Thread Andreas Pflug
Bruce Momjian wrote: How does your Win32 system rename prototype differ from what is in port.h? What is the need of *any* special file handling functions for client tools? Regards, Andreas ---(end of broadcast)--- TIP 1: subscribe and unsubscribe

Re: [PATCHES] New Translation

2004-09-12 Thread Tom Lane
Andreas Pflug [EMAIL PROTECTED] writes: [EMAIL PROTECTED] wrote: I see that there is a farsi translation in pgadmin and you named it fa_IR. This isn't comparable. In pgadmin, we're bound to the canonical names defined in wxWidgets, which is fa_IR (and there's no other Farsi version). Thus

[PATCHES] pltcl on win32

2004-09-12 Thread Magnus Hagander
The following patch fixes pltcl compiles on win32. The code change in pltcl.c is from this post: http://groups.google.com/groups?q=tcl_createslave+errorhl=enlr=ie=UTF -8c2coff=1safe=offselm=20040107132138.57308.qmail%40web60304.mail.yah oo.comrnum=3 Can't say I fully understand why, but it does

Re: [PATCHES] New Translation

2004-09-12 Thread Peter Eisentraut
Tom Lane wrote: Nonetheless, it would also be good to have some consistency between the core PG server and related projects. I tend to agree that we should honor pgadmin's precedent here; it's not a strong argument but the argument for fa over fa_IR seems even weaker. fa_IR would uselessly

Re: [PATCHES] pgxs default installation + various fixes

2004-09-12 Thread Bruce Momjian
Peter Eisentraut wrote: Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Where are we on this? I think we're waiting on Peter to review it. I have no technical issue with the patch, except that as I have previously mentioned, I don't particularly care for what it does. Yea,

Re: [PATCHES] [pgsql-hackers-win32] VC++ psql build broken

2004-09-12 Thread Bruce Momjian
Andreas Pflug wrote: Bruce Momjian wrote: How does your Win32 system rename prototype differ from what is in port.h? What is the need of *any* special file handling functions for client tools? We could avoid it but it does give us Unix semantics so it seemed good to keep it if we could.

Re: [PATCHES] pgxs default installation + various fixes

2004-09-12 Thread Bruce Momjian
Fabien COELHO wrote: Thus it suggests that the only use for the two targets is whether someone is interested in having a smaller footprint version... The other reason why I sticked to it in the submission is to be upward compatible with the previous state with 2 differents targets. I feel it

[PATCHES] WIP: SetQuerySnapshot redesign

2004-09-12 Thread Tom Lane
The attached patch implements my proposal of 6-Sep to force updating of the snapshot before every SQL query executed by SQL and SPI functions, but to provide an escape hatch by defining a read-only mode in which we do neither SetQuerySnapshot nor CommandCounterIncrement, and instead always use the

Re: [PATCHES] [pgsql-hackers-win32] VC++ psql build broken

2004-09-12 Thread Andreas Pflug
Bruce Momjian wrote: Andreas Pflug wrote: Bruce Momjian wrote: How does your Win32 system rename prototype differ from what is in port.h? What is the need of *any* special file handling functions for client tools? We could avoid it but it does give us Unix semantics so it seemed good to keep it

Re: [PATCHES] [pgsql-hackers-win32] VC++ psql build broken

2004-09-12 Thread Bruce Momjian
Andreas Pflug wrote: Bruce Momjian wrote: Andreas Pflug wrote: Bruce Momjian wrote: How does your Win32 system rename prototype differ from what is in port.h? What is the need of *any* special file handling functions for client tools? We could avoid it but it does give us

Re: [PATCHES] contribution: namespace.sql

2004-09-12 Thread Neil Conway
Tom Lane wrote: It seemed a tad excessive to me, at least for routine regression testing. What do you think of making it a separate test script and adding it to make bigcheck, as we did once with the numeric_big tests? I'm not sure I see the point: I would guess that the rate at which we're