[PATCHES] doc patch for ssl in server

2004-09-22 Thread Dominic Mitchell
This patch attempts to note the use of the root.crt file in the server. Given that PostgreSQL will output a message complaining about it's absence if you're using SSL mode, I feel it's important that it gets a mention in the documentation at some point. -Dom Index: doc/src/sgml/runtime.sgml ==

[PATCHES] WIP: CREATE TABLE AS / WITH DATA

2004-09-22 Thread Neil Conway
This patch makes CREATE TABLE AS conform more closely to SQL:2003 by adding support for the WITH [ NO ] DATA clause (per section 11.3). The standard says that this clause is mandatory, but I think it should be optional in PG (partly for backward compatibility, and partly because I think that is san

Re: [PATCHES] WIP: CREATE TABLE AS / WITH DATA

2004-09-22 Thread Alvaro Herrera
On Wed, Sep 22, 2004 at 06:48:12PM +1000, Neil Conway wrote: > P.S. I'm beginning to think that rather than applying this patch as-is > when we branch for 8.1, it might be a better idea to just bite the > bullet and restructure CREATE TABLE AS as suggested above. Thoughts? Could that include supp

[PATCHES] transaction idle timeout

2004-09-22 Thread Szima Gábor
Hello, Here is a patch for backend to allow transaction idle timeout. Works with original 8.0.0beta2 (and 7.4.5 with some warnings). TODO: SSL-connection 8<-- include/storage/proc.h: --- postgresql-8.0.0beta2/s

Re: [PATCHES] transaction idle timeout

2004-09-22 Thread Tom Lane
=?ISO-8859-1?Q?Szima_G=E1bor?= <[EMAIL PROTECTED]> writes: > Here is a patch for backend to allow transaction idle timeout. I don't think this is a good idea in the first place. But even if it were, this patch is a mess. secure_read() has no business doing the things you have made it do, either

Re: [PATCHES] [PERFORM] 7.4 vs 7.3 ( hash join issue )

2004-09-22 Thread Greg Stark
Greg Stark <[EMAIL PROTECTED]> writes: > Dennis Bjorklund <[EMAIL PROTECTED]> writes: > > > On 22 Sep 2004, Greg Stark wrote: > > > > > Actually this looks like it's arguably a bug to me. Why does the hash > > > join execute the sequential scan at all? Shouldn't it also like the > > > merge joi

Re: [PATCHES] [PERFORM] 7.4 vs 7.3 ( hash join issue )

2004-09-22 Thread Greg Stark
Tom Lane <[EMAIL PROTECTED]> writes: > Yeah, I was just looking at doing that. Well I imagine it takes you as long to read my patch as it would for you to write it. But anyways it's still useful to me as exercises. > It would also be interesting to prefetch one row from the outer table and fall

Re: [PATCHES] [PERFORM] 7.4 vs 7.3 ( hash join issue )

2004-09-22 Thread Tom Lane
Greg Stark <[EMAIL PROTECTED]> writes: >> It would also be interesting to prefetch one row from the outer table and fall >> out immediately (without building the hash table) if the outer table is >> empty. This seems to require some contortion of the code though :-( > Why is it any more complicat

[PATCHES] ALTER TABLE .. OWNER TO and sequences

2004-09-22 Thread Alvaro Herrera
Patchers, Here is a patch regarding ALTER TABLE ... OWNER and the sequences that were created by a SERIAL column. It uses pg_depend to find SERIAL sequences, and recurses the ChangeOwner to them. Additionally, it forbids directly changing the owner of a SERIAL sequence (the error message of this

Re: [PATCHES] pg_hba.conf additional comment re local line

2004-09-22 Thread Andrew Dunstan
The original of this seems to have gotten lost in the ether somewhere. It might turn up some day ... andrew Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: The attached tiny patch will possibly help to avoid some confusion by Windows users about the "local" line in pg_hba.conf (and

[PATCHES] libpq SSL documentation

2004-09-22 Thread Dominic Mitchell
This patch attempts to outline the supported level of SSL within libpq. I haven't mentioned any of ~/.postgresql/{root.crt,postgresql.crt,postresql.key} even though they are checked for in the code, since they do not appear to be supported. I base this on discussions in pgsql-hackers. -Dom Index:

Re: [PATCHES] pg_controldata usage

2004-09-22 Thread Neil Conway
On Sun, 2004-09-19 at 01:39, Dennis Bjorklund wrote: > I think that the DATADIR part being treated as an option is confusing Patch applied -- thanks! -Neil ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

[PATCHES] CREATE TABLE AS docs

2004-09-22 Thread Neil Conway
This patch updates the docs to reflect the fact that CREATE TABLE AS is part of the SQL:2003 standard. Patch applied to HEAD. -Neil Index: doc/src/sgml/ref/create_table_as.sgml === RCS file: /home/neilc/private-cvsroot/pgsql-server/d

Re: [PATCHES] WIP: CREATE TABLE AS / WITH DATA

2004-09-22 Thread Neil Conway
On Wed, 2004-09-22 at 23:00, Alvaro Herrera wrote: > Could that include supporting SELECT INTO as well as both types of > CREATE TABLE AS? Right; my thinking is to have the parser construct SELECT INTO as a CreateTableAsStmt. That way all the code for creating the "into" relation is centralized in

Re: [PATCHES] WIP: CREATE TABLE AS / WITH DATA

2004-09-22 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On Wed, 2004-09-22 at 23:00, Alvaro Herrera wrote: >> Could that include supporting SELECT INTO as well as both types of >> CREATE TABLE AS? > Right; my thinking is to have the parser construct SELECT INTO as a > CreateTableAsStmt. That way all the code fo

Re: [PATCHES] WIP: CREATE TABLE AS / WITH DATA

2004-09-22 Thread Gavin Sherry
On Thu, 23 Sep 2004, Tom Lane wrote: > Neil Conway <[EMAIL PROTECTED]> writes: > > On Wed, 2004-09-22 at 23:00, Alvaro Herrera wrote: > >> Could that include supporting SELECT INTO as well as both types of > >> CREATE TABLE AS? > > > Right; my thinking is to have the parser construct SELECT INTO