[PATCHES] error report on slru.c

2004-10-02 Thread Gaetano Mendola
Hi all, here a patch that 1) Rise the information about the file missing on pg_clog from detail to error 2) Insert the offset information also for a missing file I did it with the 8.0beta2 sources Regards Gaetano Mendola --- slru.c.orig 2004-10-02 10:56:01.0 +0200 +++ slru.c 2004

Re: [PATCHES] LDFLAGS overriding

2004-10-02 Thread Reini Urban
Peter Eisentraut schrieb: Reini Urban wrote: I think that LDFLAGS overriding is in some situations bad for newer libtool, as it is used with some postgresql contrib makefiles and interfaces. We're not using libtool. sorry. it conflicts with gnu ld. LIBS are added to LDFLAGS where they really should

Re: [PATCHES] error report on slru.c

2004-10-02 Thread Tom Lane
Gaetano Mendola <[EMAIL PROTECTED]> writes: > here a patch that > 1) Rise the information about the file missing on pg_clog from > detail to error This violates the message style guidelines, IMHO. > 2) Insert the offset information also for a missing file It's hardly necessary, since the tra

Re: [PATCHES] LDFLAGS overriding

2004-10-02 Thread Tom Lane
Reini Urban <[EMAIL PROTECTED]> writes: > Peter Eisentraut schrieb: >> Please point out where that happens so it can be corrected. > Something like this (against an older cvs snap), but I don't believe > that this is the best way to solve it. It just solved building under cygwin. Peter asked to

Re: [PATCHES] [PATCH] 5 plperl patches

2004-10-02 Thread Andrew Dunstan
This also passes my modest testing, including the error case mentioned the other day, and appears to make sense. (I did notice a small case of non-postgres indentation, but I assume we'll have another run of pg_indent before the next beta?) cheers andrew Abhijit Menon-Sen wrote: I have attached