Re: [PATCHES] [pgsql-hackers-win32] Static build of libpq fails

2004-10-13 Thread Bruce Momjian
I was able to reproduce the failure, and the attached applied patch fixes the problem. Seems someone just disable the libpq.a make rule in Makefile.shlib, probably because it didn't used to work, but it does now. I am not sure about Cygwin but our build experience so far is that if it works on

Re: [PATCHES] [pgsql-hackers-win32] pg_ctl: WIN32 for CYGWIN also (services)

2004-10-13 Thread Bruce Momjian
I have applied the attached patch which will allow service use on Cygwin using pg_ctl. A few of your #ifndef changes were backwards so you might want to test the attached version to make sure it still works on Cygwin. ---

Re: [PATCHES] [pgsql-hackers-win32] Static build of libpq fails

2004-10-13 Thread Dave Page
-Original Message- From: Bruce Momjian [mailto:[EMAIL PROTECTED] Sent: 13 October 2004 10:52 To: Dave Page Cc: [EMAIL PROTECTED]; PostgreSQL-patches; PostgreSQL Cygwin mailing list Subject: Re: [pgsql-hackers-win32] Static build of libpq fails I was able to reproduce the

Re: [PATCHES] pg_restore - added documentation

2004-10-13 Thread Peter Eisentraut
Bruce Momjian wrote: OK, wording updated and applied. I used process instead of issue. I think this is drifting farther and farther from the target... Does anyone else have a wording suggestion? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end

Re: [PATCHES] pg_restore - added documentation

2004-10-13 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Bruce Momjian wrote: However, I wonder if output database is the proper name for -d? Isn't it more restore database or target database? restore database name sounds like, When this option is specified, only the database name is restored.. target

Re: [PATCHES] pg_restore - added documentation

2004-10-13 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: ! printf(_( -C, --create process commands to create the database\n)); Wow, that's just about *completely* content-free. Obviously documentation written by a committee :-( How about ! printf(_( -d, --dbname=NAMEconnect

[PATCHES] (Turkish)New translation: pg_config

2004-10-13 Thread Devrim GUNDUZ
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I've just translated pg_config into Turkish: http://www.gunduz.org/postgresql/translation/PostgreSQL-8.0/pg_config-tr.pot Could you please apply it? Regards, - -- Devrim GUNDUZ devrim~gunduz.orgdevrim.gunduz~linux.org.tr

[PATCHES] pg_ctl cleanup

2004-10-13 Thread Neil Conway
This patch makes a couple small changes to pg_ctl: - refactor a bunch of code to call a separate function print_msg() which checks whether silent mode is enabled before printing an error message. I could have made print_msg() take a varargs list, but I didn't bother (worse is better). Also, we do

Re: [PATCHES] [HACKERS] more dirmod CYGWIN

2004-10-13 Thread Bruce Momjian
I have added the attached patch to allow Cygwin /contrib compiles. I am a little confused why Cygwin requires -lpgport and no other platform does, but it is in the Cygwin-specific section so we can always improve it later if we find the cause. Thanks.

Re: [PATCHES] [HACKERS] more dirmod CYGWIN

2004-10-13 Thread Reini Urban
Bruce Momjian schrieb: I have added the attached patch to allow Cygwin /contrib compiles. I am a little confused why Cygwin requires -lpgport and no other platform does, but it is in the Cygwin-specific section so we can always improve it later if we find the cause. thanks. duplicate does not