[PATCHES] pg_regress --temp-keep

2004-10-15 Thread Reini Urban
add boolean option --temp-keep to pg_regress to keep the existing tmp_check installation, instead of overwriting it with a fresh make install. Useful to test minor modifications in the current tmp_check installation. -- Reini Urban http://xarch.tu-graz.ac.at/home/rurban/ *** src/test/regress/pg_

Re: [PATCHES] pg_regress --temp-keep

2004-10-15 Thread Bruce Momjian
Uh, why would someone use this option? --- Reini Urban wrote: > add boolean option --temp-keep to pg_regress to keep the existing > tmp_check installation, instead of overwriting it with a fresh make > install. Useful to t

Re: [PATCHES] 8.0.0beta3 duration logging patch

2004-10-15 Thread Bruce Momjian
Patch applied. Thanks. I made some small wording adjustments. Patch attached. --- Ed L. wrote: > The attached patch forces queryless duration log statements to be turned off > in step with the log_statement directive.

Re: [PATCHES] Clarification of the PL/Perl documents

2004-10-15 Thread Bruce Momjian
Patch applied. Thanks. --- David Fetter wrote: > Folks, > > This patch clarifies the usage of references in PL/Perl :) > > Cheers, > D > -- > David Fetter [EMAIL PROTECTED] http://fetter.org/ > phone: +1 510 893 6100

Re: [PATCHES] Cosmetic changes

2004-10-15 Thread Bruce Momjian
It seems Peter has already applied many of the cleanups you suggested. If you have more, would you download the snapshot and send in a new patch? Thanks. --- Euler Taveira de Oliveira wrote: > Hi, > This small patch correc

Re: [PATCHES] [PATCH] 5 plperl patches

2004-10-15 Thread Bruce Momjian
Patch applied. Thanks. --- Abhijit Menon-Sen wrote: > I have attached 5 patches (split up for ease of review) to plperl.c. > > 1. Two minor cleanups: > > - We don't need to call hv_exists+hv_fetch; we should just che

Re: [PATCHES] Small win32 build cleanup (versioninfo)

2004-10-15 Thread Bruce Momjian
Patch applied. Thanks. --- Magnus Hagander wrote: > The previous build rules caused each binary to be re-linked on every > "make", even if nothing had changed. With this patch, it's only relinked > if it's actually updated

Re: [PATCHES] pg_regress --temp-keep

2004-10-15 Thread Tom Lane
Reini Urban <[EMAIL PROTECTED]> writes: > add boolean option --temp-keep to pg_regress to keep the existing > tmp_check installation, instead of overwriting it with a fresh make > install. Useful to test minor modifications in the current tmp_check > installation. This doesn't seem like a parti

Re: [PATCHES] pg_regress --temp-keep

2004-10-15 Thread Reini Urban
Bruce Momjian schrieb: Uh, why would someone use this option? after fixing a minor issue, not to wait for a full de-install / install and test database loss. minor issues can be regression tests updates, or updated single binaries. ---

Re: [PATCHES] pg_regress --temp-keep

2004-10-15 Thread Bruce Momjian
Reini Urban wrote: > Bruce Momjian schrieb: > > Uh, why would someone use this option? > > after fixing a minor issue, not to wait for a full > de-install / install and test database loss. > > minor issues can be regression tests updates, or updated single binaries. Seems to be of too limited a

Re: [PATCHES] pg_regress --temp-keep

2004-10-15 Thread Tom Lane
Reini Urban <[EMAIL PROTECTED]> writes: > Bruce Momjian schrieb: >> Uh, why would someone use this option? > after fixing a minor issue, not to wait for a full > de-install / install and test database loss. > minor issues can be regression tests updates, or updated single binaries. Personally I f

Re: [PATCHES] [CYGWIN] postgresql 8.0 with cygwin - success

2004-10-15 Thread Reini Urban
Marek Lewczuk schrieb: Reini Urban wrote: Bruce Momjian schrieb: Great. Thanks. I was getting conflicting reports of Cygwin problems before. Not for me: I found a problem with my pg_ctl patch (WIN32 is always defined in cygwin when windows.h is included, and the START /B postmaster cmdline does

Re: [PATCHES] Slightly better testing for pg_ctl(1)'s -w...

2004-10-15 Thread Bruce Momjian
Patch applied. Thanks. I simplified your test and made the error message a #define that is now used consistently in all places. Patch attached. --- Sean Chittenden wrote: > pg_ctl(1)'s -w option works well if the default

Re: [PATCHES] libpq.dll on win32

2004-10-15 Thread Bruce Momjian
Patch applied. Thanks. I fixed a few merge conflicts. --- Magnus Hagander wrote: > >*** src/interfaces/libpq/fe-secure.c 28 Sep 2004 00:06:02 > >-1.54 > >--- src/interfaces/libpq/fe-secure.c 11 Oct 2004 19:50

Re: [PATCHES] [CYGWIN] postgresql 8.0 with cygwin - success

2004-10-15 Thread Bruce Momjian
I did things a little differently. I #undef WIN32 after including windows.h on Cygwin and kept the defines the same except for the use of START. This makes things more consistent. Applied. --- Reini Urban wrote: > Marek L

Re: [PATCHES] [CYGWIN] postgresql 8.0 with cygwin - success

2004-10-15 Thread Reini Urban
Bruce Momjian schrieb: I did things a little differently. I #undef WIN32 after including windows.h on Cygwin and kept the defines the same except for the use of START. This makes things more consistent. But more verbose. :) But consistency is also good. Applied. Thanks. BTW, FYI: The current rema

Re: [PATCHES] [HACKERS] plperl Safe restrictions

2004-10-15 Thread Andrew Dunstan
David Helgason wrote: On 14. okt 2004, at 21:09, Andrew Dunstan wrote: It has just been brought to my attention that we are being very restrictive about what we allow to be done in trusted plperl. Basically we allow the :default and :base_math set of operations (run perldoc Opcode or see http: