Patch applied. Thanks.
---
Magnus Hagander wrote:
by the change to gettext. Needs a bunch of new includes. Patch follows:
diff -c -r1.13 win32.c
*** win32.c 22 Feb 2005 04:42:20 - 1.13
--- win32.c
Peter Eisentraut wrote:
That email message is about a timestamp data type.
Hmm, it seems that when Bruce removes items from the patch queue, the
remaining items are renumbered. You can find the original thread here:
http://archives.postgresql.org/pgsql-patches/2004-10/msg00140.php
I believe I
[ Previous version removed.]
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
Berényi Gábor wrote:
Dear Bruce,
Didn't work:
Fatal bcc32.mak 169: No terminator specified for in-line file operator
Look forward to hear of you again, Gabor
OK, new bcc32.mak attached. It turns out the actions were indented with
spaces instead of tabs.
--
Bruce Momjian
Neil Conway wrote:
I've applied a modified version of this patch from seanc:
http://candle.pha.pa.us/mhonarc/patches2/msg00029.html
(Sorry, I've lost the original thread.) The patch as I applied it is
attached. Catalog version bumped.
That email message is about a timestamp data type.
Neil Conway wrote:
Peter Eisentraut wrote:
That email message is about a timestamp data type.
Hmm, it seems that when Bruce removes items from the patch queue, the
remaining items are renumbered. You can find the original thread here:
Patch applied. Thanks.
---
Magnus Hagander wrote:
there is no sys/ioctl.h. Trivial patch below:
diff -c -r1.6 snprintf.c
*** snprintf.c 22 Feb 2005 04:57:24 - 1.6
--- snprintf.c 27 Feb 2005 17:05:54
there is no sys/ioctl.h. Trivial patch below:
I don't think this header is needed on any platform. If it
were, you certainly couldn't just remove it.
Not so. On win32 we pull in windows.h, which contains a lot of the
definitions that are present in various other header files on unix.
Neil Conway wrote:
It has a long standing precedent outside of mathematics, such as in C
and derived programming languages.
C doesn't have a boolean type.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
---(end of broadcast)---
TIP
Patch applied by Neil Conway. Thanks.
---
Koju Iijima wrote:
Bruce Momjian wrote:
May I have a context diff please, diff -c?
As this is new functionality, I presume it will be held for 8.1,
correct? In
Peter Eisentraut [EMAIL PROTECTED] writes:
I believe I would have objected to an int/bool cast. I do so now
anyway.
This was already discussed and agreed to. Since it's an explicit-only
cast, I see no harm in it. And it's certainly been requested often
enough.
- Casting back and forth does
Tom Lane wrote:
[EMAIL PROTECTED] writes:
Do we have any idea about what format string causes the regression failure?
I'll bet the problem is that configure.in is doing things in the wrong
order: it computes INT64_FORMAT against the system printf before
deciding we should use our own
Bruce Momjian pgman@candle.pha.pa.us writes:
Ah, the problem was introduced here:
Right, it was my fault.
The problem is that the PGAC_FUNC_PRINTF_ARG_CONTROL call was moved
below the printf 64-bit tests. This commited patch moves
PGAC_FUNC_PRINTF_ARG_CONTROL which is after we know
Tom Lane wrote:
Bruce Momjian pgman@candle.pha.pa.us writes:
Ah, the problem was introduced here:
Right, it was my fault.
The problem is that the PGAC_FUNC_PRINTF_ARG_CONTROL call was moved
below the printf 64-bit tests. This commited patch moves
PGAC_FUNC_PRINTF_ARG_CONTROL which
And while we are on it, I would like to submit minor
changes to make snprintf() vsnprintf() and printf()
functions in src/port/snprintf.c thread-safe.
Best regards,
Nicolai Tufar
Index: src/port/snprintf.c
===
RCS file:
15 matches
Mail list logo
