Re: [PATCHES] [HACKERS] contrib/pg_buffercache

2005-03-31 Thread Mark Kirkwood
Neil Conway wrote: Mark Kirkwood wrote: Great that it fixes it... however, I had submitted a tidier patch that puts the macro in the header How is this tidier? err... puts the macro in the header (I don't see a reason for pg_buffercache_pages.h at all, actually.) (chuckles) - well, that puts

Re: [PATCHES] [HACKERS] contrib/pg_buffercache

2005-03-31 Thread Andrew Dunstan
Mark Kirkwood wrote: Neil Conway wrote: Andrew Dunstan wrote: I have confirmed that the attached patch works on Cygwin as well as Windows. Please apply. Applied, thanks. Great that it fixes it... however, I had submitted a tidier patch that puts the macro in the header (probably after asking

Re: [PATCHES] [HACKERS] contrib/pg_buffercache

2005-03-31 Thread Mark Kirkwood
Andrew Dunstan wrote: I didn't see the original of the later patch, which is why I sent in mine. I honestly don't care that much either way, although I'm inclined to agree that the header file is just unnecessary noise. Well, looks like a strong feeling for no header :-). I didn't really think

Re: [PATCHES] [HACKERS] HEAD \df doesn't show functions with no arguments

2005-03-31 Thread Bruce Momjian
I have applied the following attached patch to CVS to fix the \df display problem you reported. We might remove the test it at some point but at least now it works as in previous releases. --- Michael Fuhr wrote: > On Thu,