Neil Conway [EMAIL PROTECTED] wrote:
--- 622,628
for (i = 0; i (sizeof(DDLAFTERs) / sizeof(char *)); i++)
{
res = PQexec(con, DDLAFTERs[i]);
! if (strncmp(DDLAFTERs[i], drop, 4) PQresultStatus(res) !=
PGRES_COMMAND_OK)
{
On E, 2005-05-23 at 10:16 -0400, Tom Lane wrote:
Neil Conway [EMAIL PROTECTED] writes:
I'm a little worried about having this set to true after a VACUUM is
executed, and only reset to false when the next transaction is begun: it
shouldn't affect correctness right now, but it seems like
On E, 2005-05-23 at 11:42 -0400, Tom Lane wrote:
Hannu Krosing [EMAIL PROTECTED] writes:
I can't think of any other cases where it could matter, as at least the
work done inside vacuum_rel() itself seema non-rollbackable.
VACUUM FULL's tuple-moving is definitely roll-back-able, so it might
ITAGAKI Takahiro wrote:
But this code seems to be an idiom,
Check the result, but drop commands may be fail.
Drop commands might be added to DDLAFTERs some time, so we may leave it.
Possibly, but I think checking for something that cannot occur is
confusing to the reader (and besides, it is
