Do you agree that using a hashtable for it in general is a good idea
assuming this sideeffect is removed, though?
I have no problem with the hashtable, only with preloading it with
everything. What I'd like to see is that the table inherited at fork()
contains just the data for the default
Revised patch to avoid lost signals before signaling mechanism is set up
in Win32. This was tested by plus a line:
Sleep(10*1000);
in the front of pgwin32_signal_initialize().
Regards,
Qingqing
Index: src/port/kill.c
===
Hi!
A quick-check (haven't checked any details) - your unconditional use of
Global\ will not work on NT4. With 8.0 we said we wanted to support NT4
with some limits (IIRC, tablespaces don't work, and the intaller
definitly doesn't work). If we want to continue doing that (which I
think we do),
I think the conclusion from the discussion is that O_DIRECT is in
addition to the sync method, rather than in place of it, because
O_DIRECT doesn't have the same media write guarantees as fsync(). Would
you update the patch to do O_DIRECT in addition to O_SYNC or fsync() and
see if there is a
Andreas Pflug wrote:
This patch reenables pg_terminate_backend, allowing (superuser only, of
course) to terminate a backend. As taken from the discussion some weeks
earlier, SIGTERM seems to be used quite widely, without a report of
misbehavior so while the code path is officially not too
Magnus Hagander wrote:
Hi!
A quick-check (haven't checked any details) - your unconditional use of
Global\ will not work on NT4. With 8.0 we said we wanted to support NT4
with some limits (IIRC, tablespaces don't work, and the intaller
definitly doesn't work). If we want to continue doing
Hi!
A quick-check (haven't checked any details) - your
unconditional use of
Global\ will not work on NT4. With 8.0 we said we wanted to
support NT4
with some limits (IIRC, tablespaces don't work, and the intaller
definitly doesn't work). If we want to continue doing that (which I
think
A quick-check (haven't checked any details) - your
unconditional use of
Global\ will not work on NT4. With 8.0 we said we wanted to
support NT4
with some limits (IIRC, tablespaces don't work, and the intaller
definitly doesn't work). If we want to continue doing
that (which I
think
Patch applied. Thanks. (The first if == NULL test was already in CVS).
---
a_ogawa wrote:
Tom Lane [EMAIL PROTECTED] writes:
a_ogawa [EMAIL PROTECTED] writes:
It is a reasonable idea. However, the majority part
Mega-patch version applied. Thanks.
---
Abhijit Menon-Sen wrote:
At 2005-05-21 20:18:50 +0530, [EMAIL PROTECTED] wrote:
The second issue is where plperl returns a large result set.
I have attached the following
I see Tatsuo already applied this, which is great. I added a little
comment:
/* if multi-byte, take len and find # characters */
---
Yoshiyuki Asaba wrote:
Character type value including multibyte characters is
This has broken the regression tests for plperl - see for example
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=pandadt=2005-06-04%2021:20:01
That's because, as Abhijit noted in point 4 below, select foo_srf() no
longer works.
At a minimum those calls need to be removed from the regression
Tom Lane wrote:
Bruce Momjian pgman@candle.pha.pa.us writes:
Patch applied. Thanks. (The first if == NULL test was already in CVS).
The first if == NULL test was the only part I wanted to apply ...
I do not think this patch is a performance win in general.
Attached is the part I backed
Andrew Dunstan wrote:
This has broken the regression tests for plperl - see for example
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=pandadt=2005-06-04%2021:20:01
That's because, as Abhijit noted in point 4 below, select foo_srf() no
longer works.
At a minimum those calls need to
Tom Lane wrote:
Bruce Momjian pgman@candle.pha.pa.us writes:
Patch applied. Thanks. (The first if == NULL test was already in CVS).
The first if == NULL test was the only part I wanted to apply ...
I do not think this patch is a performance win in general.
OK, patch reverted. a_ogawa,
I will add the documentation and make sure your oids are not duplicates.
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
Bruce Momjian said:
Andrew Dunstan wrote:
This has broken the regression tests for plperl - see for example
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=pandadt=2005-06-04%2021:20:01
That's because, as Abhijit noted in point 4 below, select foo_srf() no
longer works.
At a minimum
Patch additions added to the patch queue.
---
Andrew Dunstan wrote:
Ed L. wrote:
Attached also is a patch to comments in sample postgresql.conf file.
Subject: [PATCHES] log_line_prefix additions
Date:
I will add documentation for it.
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
Bruce Momjian wrote:
Could we do your NOLOGGING automatically in COPY if we test to see if
anyone else is connected to our current database?
That seems pretty fragile -- what happens if someone connects after the
COPY has started? Considering that many COPY operations can take many
minutes
I am using 'cp' in current CVS for this. I assume it is as fast as the
C implementation, but if not, please let me know.
---
Alvaro Herrera wrote:
Patchers,
I wrote an install program in C. It's supposed to replace
[EMAIL PROTECTED] wrote:
I must be missing something, but AFAICS this patch doesn't actually *do*
anything useful. It looks to me like you've implemented a write-only
addition to the system catalogs. (And not even done a very good job of
that --- no documentation, no pg_dump support.)
Later version of this patch added to the patch queue.
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
Patch applied. Thanks.
---
Abhijit Menon-Sen wrote:
At 2005-06-04 17:27:10 -0500, [EMAIL PROTECTED] wrote:
OK, would you please submit a patch to fix it. Thanks.
I will unless someone beats me to it in the next
ITAGAKI Takahiro wrote:
Hello everyone.
I fixed two bugs in the patch that I sent before.
Check and test new one, please.
1. Fix update timing of Write-curridx. (pointed by Tom)
Change to update it soon after write().
2. Fix buffer alignment routine on 64bit cpu. (pointed by Mark)
What would be absolutely ideal is a reset connection command, plus some
way of knowing via the protocol if it's needed or not.
Chris
Bruce Momjian wrote:
What did we decide on RESET CONNECTION. Do we want an SQL command or
something only the protocol can do?
Bruce,
Please note that this patch is a correction and replacement for an
earlier patch in the queue. The patch accompanying the message
http://candle.pha.pa.us/mhonarc/patches/msg8.html
should be removed from the queue and not applied.
The one (originally) attached to this message
Bruce Momjian pgman@candle.pha.pa.us writes:
Your patch has been added to the PostgreSQL unapplied patches list at:
a_ogawa00 wrote:
This patch provides a new function regexp_replace.
regexp_replace extends a replace function and enables text search
by the regular expression. And, a back
Bruce Momjian pgman@candle.pha.pa.us writes:
BTW, I found memory leak in BootStrapXLOG(). The buffer allocated by malloc()
is not free()ed. ISSUE_BOOTSTRAP_MEMORYLEAK in this patch points out it.
(But this leak is not serious, because this function is called only once.)
Does the following
On Sun, 5 Jun 2005 10:29 am, Neil Conway wrote:
Bruce Momjian wrote:
Well, it isn't going to help us for 8.1 because 8.0 will not have it,
and if we add the clause we make loading the data into previous releases
harder.
pg_dump output in general is not compatible with prior releases. It
Bruce,
Attached patch replaces the original, applied today against CVS HEAD.
Fixes the surrogates, and limits to 4 byte utf8 as per spec.
Also extends UtfToLocal to 4 byte characters (tho, it does not add any,
just enables the code to handle them. If my interpretation of this code
is wrong,
On Thu, 2 Jun 2005, Neil Conway wrote:
Here is a small patch that implements a function lastval() that
Have you had a chance to respin this patch per my earlier comments on
the implementation, Dennis?
I've been spending my free time on another project and I don't multitask
very well :-)
32 matches
Mail list logo
