Michael Fuhr said:
On Tue, Aug 23, 2005 at 10:30:51PM -0600, Michael Fuhr wrote:
Global symbol $x requires explicit package name at (eval 3) line 1.
If I'm reading the Perl source code correctly (pp_ctl.c), the number
following eval comes from a variable named PL_evalseq that's
incremented
On K, 2005-08-17 at 15:40 -0400, Tom Lane wrote:
Saatja:
Tom Lane [EMAIL PROTECTED]
Kellele:
Bruce Momjian
pgman@candle.pha.pa.us, Hannu
Krosing [EMAIL PROTECTED], Neil Conway
[EMAIL PROTECTED], pgsql-
[EMAIL PROTECTED]
I wrote:
Michael Fuhr said:
we might be able to do
my $retval = eval($stuff);
$@ =~ s/ \(eval \d+\) / /g if $@;
return $retval;
T
It would probably be more efficient and less convoluted to munge this in a
__DIE__ handler. The we wouldn't need the extra level of eval.
e.g.
On Wed, Aug 24, 2005 at 09:50:06AM -0400, Andrew Dunstan wrote:
Here's an updated patch incorporating Michael's ideas, and this time
*with* a small regression test that dynamically turns strict mode on/off.
Shouldn't the $@ munging patterns include the /g flag so they remove
all occurrences of
This has been saved for the 8.2 release:
http://momjian.postgresql.org/cgi-bin/pgpatches_hold
---
Hannu Krosing wrote:
On K, 2005-08-17 at 15:40 -0400, Tom Lane wrote:
Saatja:
Tom
Michael Fuhr wrote:
On Wed, Aug 24, 2005 at 09:50:06AM -0400, Andrew Dunstan wrote:
Here's an updated patch incorporating Michael's ideas, and this time
*with* a small regression test that dynamically turns strict mode on/off.
Shouldn't the $@ munging patterns include the /g flag
This has been saved for the 8.2 release:
http://momjian.postgresql.org/cgi-bin/pgpatches_hold
---
Magnus Hagander wrote:
I just realised this mail didn't go through. Probably because it was too
large for
Im proposing this change to /src/port/getaddrinfo.c
to support IPv6 under windows.
10a11,14
* Windows may or may not have these
routines, so we handle Windows special
* by dynamically checking for their existence.
If they already exist, we
* use the Windows native routines, but if
Context diff, please, diff -c.
---
Chuck McDevitt wrote:
I'm proposing this change to /src/port/getaddrinfo.c to support IPv6
under windows.
10a11,14
* Windows may or may not have these routines, so we handle
Michael Fuhr [EMAIL PROTECTED] writes:
The attached patch allows the PL/Perl regression tests to pass when
use_strict is enabled. I've also attached a variant of plperl_elog.out
to account for an elog() message that shows a different line number
when run under use_strict.
Now that we've got
Im proposing this change to /src/port/getaddrinfo.c
to support IPv6 under windows.
(this time with a context diff !)
*** \postgresql-snapshot\src\port\getaddrinfo.c Wed
Aug 24 11:54:09 2005
--- \postgresql-patched\src\port\getaddrinfo.c Wed
Aug 24 11:53:05 2005
***
***
Bruce Momjian wrote:
Context diff, please, diff -c.
It needed dos2unix and pgindent as well. Here's a cleaned patch.
Thanks to Chuck for doing this work.
cheers
andrew
*** src/port/getaddrinfo.c 2005-07-28 00:03:14.0 -0400
--- /home/andrew/getaddrinfo.c 2005-08-24
Attached is a patch adding regression tests for this code.
Thanks,
Gavin
On Tue, 23 Aug 2005, Bruce Momjian wrote:
Thanks, modified patch applied by Tom, with the addition of a USER
triggers only mode.
---
Satoshi
Larry Rosenman wrote:
The following is from my SCO Internal contact about the bug. It's
definitely their bug. Towards the end of the
Exact diagnosis, is a suggested work-around for now, as well as a (possible)
memory leak.
...
Also note that there appears to be a memory leak in the
Does this fix IPv6 on Win32?
---
Tom Lane wrote:
Andrew Dunstan [EMAIL PROTECTED] writes:
Context diff, please, diff -c.
It needed dos2unix and pgindent as well. Here's a cleaned patch.
Thanks to Chuck for doing
Andrew Dunstan [EMAIL PROTECTED] writes:
Context diff, please, diff -c.
It needed dos2unix and pgindent as well. Here's a cleaned patch.
Thanks to Chuck for doing this work.
Applied, thanks.
regards, tom lane
---(end of
Bruce Momjian said:
OK, we need text for the release notes. What would it be?
How about this?:
. Support for connections over IPv6 on Windows platforms capable of it.
(Chuck McDevitt, Petr Jelinek, Magnus Hagander, Andrew Dunstan).
cheers
andrew
---(end of
OK, we need text for the release notes. What would it be?
---
Andrew Dunstan wrote:
I believe so, yes, although I think that we should remove the
HAVE_GETADDRINFO compile time test that Tom built into initdb.c the
I believe so, yes, although I think that we should remove the
HAVE_GETADDRINFO compile time test that Tom built into initdb.c the other
day, so that it can fall through to this code.
cheers
andrew
Bruce Momjian said:
Does this fix IPv6 on Win32?
Thanks, added.
---
Andrew Dunstan wrote:
Bruce Momjian said:
OK, we need text for the release notes. What would it be?
How about this?:
. Support for connections over IPv6 on Windows platforms capable of it.
Andrew Dunstan [EMAIL PROTECTED] writes:
I believe so, yes, although I think that we should remove the
HAVE_GETADDRINFO compile time test that Tom built into initdb.c the other
day, so that it can fall through to this code.
Will do. BTW, when we are using getaddrinfo.c, is the gai_strerror
Bruce Momjian pgman@candle.pha.pa.us writes:
Good catch on the memory leak. I have applied the following fix.
These explicit pfrees are a waste of time, and probably actually
counterproductive as far as speed goes, because these functions
will always be invoked in relatively short-lived memory
22 matches
Mail list logo
