[PATCHES] sum(int4)/sum(int2) improvement

2005-09-01 Thread Atsushi Ogawa
When sum(int4) or sum(int2) is executed, many cycles are spent by AllocSetReset. Because per-tuple context is used to allocate the first data of each group. An attached patch uses AggState-aggcontext instead of per-tuple context to allocate the data. As a result, per-tuple context is not used,

Re: [PATCHES] sum(int4)/sum(int2) improvement

2005-09-01 Thread Tom Lane
Atsushi Ogawa [EMAIL PROTECTED] writes: An attached patch uses AggState-aggcontext instead of per-tuple context to allocate the data. As a result, per-tuple context is not used, and the cycles of AllocSetReset is reduced. Why is this better than the fix already in place?

Re: [PATCHES] sum(int4)/sum(int2) improvement

2005-09-01 Thread Atsushi Ogawa
Tom Lane wrote: Atsushi Ogawa [EMAIL PROTECTED] writes: An attached patch uses AggState-aggcontext instead of per-tuple context to allocate the data. As a result, per-tuple context is not used, and the cycles of AllocSetReset is reduced. Why is this better than the fix already in place?

Re: [PATCHES] sum(int4)/sum(int2) improvement

2005-09-01 Thread Tom Lane
Atsushi Ogawa [EMAIL PROTECTED] writes: Tom Lane wrote: Why is this better than the fix already in place? Because per-tuple context is reset many times. If per-tuple context is never used, the following codes of AllocSetReset become effective. /* Nothing to do if context has never

Re: [PATCHES] Work-in-progress referential action trigger timing

2005-09-01 Thread Stephan Szabo
On Tue, 23 Aug 2005, Stephan Szabo wrote: Here's my current work in progress for 8.1 devel related to fixing the timing issues with referential actions having their checks run on intermediate states. I've only put in a simple test that failed against 8.0 in the regression patch and

Re: [PATCHES] [BUGS] PSQL commands not backwards-compatible

2005-09-01 Thread Bruce Momjian
Greg Sabino Mullane wrote: [ There is text before PGP section. ] -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Four years later, people were saying: OK, this new patch prints a warning on any major version mismatch, newer or older. I would suggest showing both the client and