[PATCHES] For review: Initial support for COLLATE

2005-09-07 Thread Martijn van Oosterhout
[Please CC any replies, thanks] This patch is the beginnings of support for COLLATE. I need to do some other work for a few days so I'm posting here to get some initial reviews. Various parts are marked [done] and [not done]. The steps involved are: - Add COLLATE to grammer as part of

Re: [PATCHES] For review: Initial support for COLLATE

2005-09-07 Thread Martijn van Oosterhout
On Wed, Sep 07, 2005 at 09:12:12PM +0200, Peter Eisentraut wrote: No, and in fact the terminology mixup in your patch and description concerns me. If you are talking about collation, then the data types, system catalog columns, etc. should talk about collation, not about locale, because

Re: [PATCHES] For review: Initial support for COLLATE

2005-09-07 Thread Peter Eisentraut
Martijn van Oosterhout wrote: - Should LOCALE be created as a synonym for COLLATE? It reads more naturally. No, and in fact the terminology mixup in your patch and description concerns me. If you are talking about collation, then the data types, system catalog columns, etc. should talk

Re: [PATCHES] For review: Initial support for COLLATE

2005-09-07 Thread Peter Eisentraut
Martijn van Oosterhout wrote: Look at the POSIX interface, look at ICU. They both provide collate order *and* date/time formats *and* number formatting. Pretending they're seperate is silly. I'm not pretending. They *are* separate. That's why you can set them separately. -- Peter