Re: [PATCHES] suggested warning about perl nested named subroutines

2005-10-12 Thread Bruce Momjian
Patch applied. Thanks. --- Andrew Dunstan wrote: I propose to add the following to the plperl docs, following recent problems. comments? cheers andrew Index: plperl.sgml

[PATCHES] Fix argument of SetBufferCommitInfoNeedsSave at _bt_check_unique

2005-10-12 Thread Atsushi Ogawa
The argument of SetBufferCommitInfoNeedsSave at _bt_check_unique might be not correct. When the next page is checked, I think that the argument is not buf but nbuf. regards, --- Atsushi Ogawa *** ./src/backend/access/nbtree/nbtinsert.c.orig 2005-10-13 00:59:55.599839064 +0900 ---

Re: [PATCHES] suggested warning about perl nested named subroutines

2005-10-12 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 If this were a Postgres problem I'd agree with you. But it isn't, really - it's a Perl problem, which is properly documented in the Perl docs, to which this note refers. Well, it's really a problem with our implementation of pl/perl. I don't

Re: [PATCHES] Fix argument of SetBufferCommitInfoNeedsSave at _bt_check_unique

2005-10-12 Thread Tom Lane
Atsushi Ogawa [EMAIL PROTECTED] writes: The argument of SetBufferCommitInfoNeedsSave at _bt_check_unique might be not correct. When the next page is checked, I think that the argument is not buf but nbuf. You are right --- thanks for finding this! regards, tom lane

[PATCHES] Perf test patch for lwlock structure padding

2005-10-12 Thread Simon Riggs
As discussed on -hackers: Patch to test performance for lwlock structure padding for 8.1beta This patch is only expected to show improvement on larger SMP systems where there is considerable lwlock activity, on related lock types e.g. multiple backends doing tight nested loop joins at the same

[PATCHES] Typo in UPDATE documentation

2005-10-12 Thread Michael Fuhr
In the UPDATE documentation, indeterminacy is misspelled as indeterminancy. http://www.m-w.com/cgi-bin/dictionary?va=indeterminacy -- Michael Fuhr Index: doc/src/sgml/ref/update.sgml === RCS file:

Re: [PATCHES] suggested warning about perl nested named subroutines

2005-10-12 Thread Andrew Dunstan
Greg Sabino Mullane wrote: If this were a Postgres problem I'd agree with you. But it isn't, really - it's a Perl problem, which is properly documented in the Perl docs, to which this note refers. Well, it's really a problem with our implementation of pl/perl. I don't think it's

Re: [PATCHES] Typo in UPDATE documentation

2005-10-12 Thread Tom Lane
Michael Fuhr [EMAIL PROTECTED] writes: In the UPDATE documentation, indeterminacy is misspelled as indeterminancy. Fixed, thanks. regards, tom lane ---(end of broadcast)--- TIP 6: explain analyze is your friend