[PATCHES] Single-Transaction Utility options

2005-12-16 Thread Simon Riggs
The following patches add a -N option to psql and pgrestore. This option adds a BEGIN at the start and a COMMIT at the end of all commands, causing all statements to be executed as a single transaction. In pgrestore the -N option also forces the -e option: exit on error. Passes make check on

Re: [PATCHES] Single-Transaction Utility options

2005-12-16 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: The following patches add a -N option to psql and pgrestore. -N seems an entirely random name for the switch ... can't we do better? I see that -t, -T, -s, -S, -x and -X are all taken, which lets out the obvious choices ... but I'd rather have no

Re: [PATCHES] Single-Transaction Utility options

2005-12-16 Thread Alvaro Herrera
Simon Riggs wrote: The following patches add a -N option to psql and pgrestore. This option adds a BEGIN at the start and a COMMIT at the end of all commands, causing all statements to be executed as a single transaction. Why use it around the whole file and not only around that particular

Re: [PATCHES] Single-Transaction Utility options

2005-12-16 Thread Jaime Casanova
Also, I don't actually see any point to this in psql, as you can always do begin; \i file end; It's only pg_restore that you really need it for. Dropping the psql part of the patch might give us a little more maneuvering room as far as the switch name goes.

[PATCHES] Win32 gettimeofday() comment patch

2005-12-16 Thread Qingqing Zhou
Add a note to Win32 gettimeofday() emulation. Regards, Qingqing --- Index: gettimeofday.c === RCS file: /projects/cvsroot/pgsql/src/port/gettimeofday.c,v retrieving revision 1.6 diff -c -r1.6 gettimeofday.c *** gettimeofday.c

Re: [PATCHES] Single-Transaction Utility options

2005-12-16 Thread Simon Riggs
On Fri, 2005-12-16 at 13:59 -0500, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: The following patches add a -N option to psql and pgrestore. -N seems an entirely random name for the switch ... can't we do better? I see that -t, -T, -s, -S, -x and -X are all taken, which lets out

Re: [PATCHES] Single-Transaction Utility options

2005-12-16 Thread Simon Riggs
On Fri, 2005-12-16 at 16:04 -0300, Alvaro Herrera wrote: Simon Riggs wrote: The following patches add a -N option to psql and pgrestore. This option adds a BEGIN at the start and a COMMIT at the end of all commands, causing all statements to be executed as a single transaction. Why

Re: [PATCHES] Single-Transaction Utility options

2005-12-16 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: On Fri, 2005-12-16 at 13:59 -0500, Tom Lane wrote: Would -1 work, or just confuse people? That was my preference, I just thought it wouldn't be popular... So I'll happily change that. OK. While you're at it, I didn't like the long name either ;-). We do

Re: [PATCHES] TODO Item - Add system view to show free space map

2005-12-16 Thread Mark Kirkwood
Mark Kirkwood wrote: Bruce Momjian wrote: Mark Kirkwood wrote: Simon Riggs wrote: I like this, but not because I want to read it myself, but because I want to make autovacuum responsible for re-allocating free space when it runs out. This way we can have an autoFSM feature in 8.2

Re: [PATCHES] Win32 gettimeofday() comment patch

2005-12-16 Thread Alvaro Herrera
Qingqing Zhou wrote: Add a note to Win32 gettimeofday() emulation. Applied, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---(end of

Re: [PATCHES] Single-Transaction Utility options

2005-12-16 Thread Alvaro Herrera
Simon Riggs wrote: On Fri, 2005-12-16 at 16:04 -0300, Alvaro Herrera wrote: Simon Riggs wrote: The following patches add a -N option to psql and pgrestore. This option adds a BEGIN at the start and a COMMIT at the end of all commands, causing all statements to be executed as a

Re: [PATCHES] Single-Transaction Utility options

2005-12-16 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: Why use it around the whole file and not only around that particular table's operations? You could. That just behaves slightly differently. pg_dump does not always produce all the commands affecting a single table together, so I don't think you can

Re: [PATCHES] Single-Transaction Utility options

2005-12-16 Thread Alvaro Herrera
Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: Why use it around the whole file and not only around that particular table's operations? You could. That just behaves slightly differently. pg_dump does not always produce all the commands affecting a single table together, so I