Re: [PATCHES] [PATCH] Add support for GnuTLS

2006-05-30 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: I think we are ready to move forward with this. Please supply an updated patch ready for application. Thanks. I'm still not very happy with the size/invasiveness of that patch. Nor am I. FWIW, Red Hat's legal department

Re: [PATCHES] [PATCH] Add support for GnuTLS

2006-05-30 Thread Martijn van Oosterhout
On Mon, May 29, 2006 at 11:21:16PM -0400, Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: I think we are ready to move forward with this. Please supply an updated patch ready for application. Thanks. I'm still not very happy with the size/invasiveness of that patch. I think

Re: [PATCHES] [PATCH] Add support for GnuTLS

2006-05-30 Thread Martijn van Oosterhout
Forgot the patch... On Tue, May 30, 2006 at 01:01:38PM +0200, Martijn van Oosterhout wrote: snip -- Martijn van Oosterhout kleptog@svana.org http://svana.org/kleptog/ From each according to his ability. To each according to his ability to litigate. Index: configure Index: configure.in

Re: [PATCHES] plpgsql documentation

2006-05-30 Thread Bruce Momjian
Patch applied. Thanks. Your documentation changes can be viewed in five minutes using links on the developer's page, http://www.postgresql.org/developer/testing. --- Chris Browne wrote: An article at WebProNews quoted

Re: [PATCHES] small doc patch for regexp_replace

2006-05-30 Thread Bruce Momjian
Patch applied. Thanks. Your documentation changes can be viewed in five minutes using links on the developer's page, http://www.postgresql.org/developer/testing. --- Joachim Wieland wrote: Is there any reason, why

Re: [PATCHES] PL/PGSQL: Dynamic Record Introspection

2006-05-30 Thread Bruce Momjian
Patch applied. Thanks. --- [EMAIL PROTECTED] wrote: Bruce Momjian schrieb: This patch cannot be applied. 'active_simple_exprs' is referenced but not defined. I think the new variable name is 'simple_eval_estate',

Re: [PATCHES] [pgadmin-hackers] Adminpack contrib module

2006-05-30 Thread Bruce Momjian
Patch applied. Thanks. --- Dave Page wrote: -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Andrus Sent: 08 May 2006 18:16 To: pgadmin-hackers@postgresql.org

Re: [PATCHES] fori stmt with by keyword was:(Re: [HACKERS] for statement,

2006-05-30 Thread Bruce Momjian
I went to test this patch and got the attached regression failures. Please repair and resubmit. Thanks. --- Jaime Casanova wrote: On 4/30/06, Jaime Casanova [EMAIL PROTECTED] wrote: On 4/29/06, Andrew Dunstan [EMAIL

Re: [PATCHES] The problem of an inline definition by construction in

2006-05-30 Thread Bruce Momjian
Patch applied to CVS HEAD and 8.1.X. Thanks. Borland CC also needed this change, so I modified your patch appropriately. --- Hiroshi Saito wrote: Dear Bruce san. I neglected sufficient test before a release.:-(

Re: [PATCHES] Add namespace dependency for conversions

2006-05-30 Thread Bruce Momjian
Patch applied. Thanks. --- Bernd Helmle wrote: Currently we don't record any dependencies between namespaces and conversions. This looks inconsistent to me, since we have dependencies on all other objects that live

Re: [PATCHES] trivial fix in fd.c

2006-05-30 Thread Bruce Momjian
Patch applied. Thanks. --- Qingqing Zhou wrote: Fix a format warning in fd.c when FDDEBUG is on. By the way (to save a thread): What's the rationale of designing resowner APIs like this:

Re: [PATCHES] archiver.pid

2006-05-30 Thread Bruce Momjian
Patch applied to CVS HEAD and 8.1.X. Thanks. --- Simon Riggs wrote: On Mon, 2006-05-22 at 17:29 +0100, Simon Riggs wrote: Lock file to prevent starting with multiple archivers present. Possibly some debate over

Re: [PATCHES] PL/PGSQL: Dynamic Record Introspection

2006-05-30 Thread Tom Lane
Bruce Momjian pgman@candle.pha.pa.us writes: Patch applied. Thanks. I wish to object to this patch; it's poorly designed, poorly coded, and badly documented. The philosophy seems to be I want this feature and I don't care what I have to do to the semantics and performance of plpgsql to get it.

Re: [PATCHES] PL/PGSQL: Dynamic Record Introspection

2006-05-30 Thread Bruce Momjian
OK, patch reverted, and attached. Would the author please revise? Thanks. It seems like a cool feature. --- Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: Patch applied. Thanks. I wish to object to

Re: [PATCHES] [PATCH] Warning about configure args (weaker version)

2006-05-30 Thread Bruce Momjian
Patch applied. Thanks. --- Martijn van Oosterhout wrote: -- Start of PGP signed section. Here's a weaker version of the previous patch. Rather than aborting, it simply prints a warning about any unrecognised options,

Re: [PATCHES] [PATCH] Improve EXPLAIN ANALYZE overhead by sampling

2006-05-30 Thread Bruce Momjian
Patch applied. Thanks. --- Martijn van Oosterhout wrote: -- Start of PGP signed section. This was a suggestion made back in March that would dramatically reduce the overhead of EXPLAIN ANALYZE on queries that loop

Re: [PATCHES] [DOCS] Proposed doc-patch: Identifying the Current WAL file

2006-05-30 Thread Bruce Momjian
Simon, I understand this is only for the 8.1.X and 8.0.X branches. I am hesitant to put something in back branches when the main branch does not have this functionality. I will hold the patch until we are sure where the head branch is going.

Re: [PATCHES] [PATCH] Round 2: Magic block for modules

2006-05-30 Thread Bruce Momjian
Patch applied. Thanks. --- Martijn van Oosterhout wrote: -- Start of PGP signed section. Per feedback, here is an updated version. As was pointed out, the prior version was checking stuff that either changed too often

Re: [PATCHES] PL/PGSQL: Dynamic Record Introspection

2006-05-30 Thread Tom Lane
Bruce Momjian pgman@candle.pha.pa.us writes: It seems like a cool feature. The fundamental problem with it is that plpgsql isn't designed to deal with dynamically changing data types. The patch as submitted contained some hacks that sort of dealt with this in some cases (I don't think it

Re: [PATCHES] [PATCH] Add support for GnuTLS

2006-05-30 Thread Andrew Dunstan
Tom Lane wrote: FWIW, Red Hat's legal department thinks that the FSF has overreached in claiming that the GPL is incompatible with OpenSSL's license. Which is why Red Hat isn't worrying about GPL apps that use OpenSSL, of which there are quite a few ... I'm quite happy if we hang onto Red

Re: [PATCHES] PL/PGSQL: Dynamic Record Introspection

2006-05-30 Thread Neil Conway
[EMAIL PROTECTED] said: The patch was now hanging around more than 9 months, and it was already accepted during the original discussion by Neil Conway. Nonsense. I provided some specific code cleanup suggestions and said that I didn't object to the general feature. That should not be taken as

Re: [PATCHES] [PATCH] Round 2: Magic block for modules

2006-05-30 Thread Tom Lane
Bruce Momjian pgman@candle.pha.pa.us writes: Patch applied. Thanks. I hadn't gotten around to reviewing the revised version. Just to let you know, I'm going to remove the separate header file pgmagic.h and put the macro into fmgr.h as I'd suggested originally. The reason is that the separate

Re: [PATCHES] [PATCH] Round 2: Magic block for modules

2006-05-30 Thread Andrew Dunstan
Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: Patch applied. Thanks. I hadn't gotten around to reviewing the revised version. Is it just me or is this happening a lot lately? cheers andrew ---(end of broadcast)---

Re: [PATCHES] [PATCH] Round 2: Magic block for modules

2006-05-30 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Tom Lane wrote: I hadn't gotten around to reviewing the revised version. Is it just me or is this happening a lot lately? That security stuff took up a *lot* of time behind the scenes :-( Normality is returning, slowly.

Re: [PATCHES] PL/PGSQL: Dynamic Record Introspection

2006-05-30 Thread uol
No, the author would not. Tom did participate in the discussion at the time when the original patch was developed. The patch was now hanging around more than 9 months, and it was already accepted during the original discussion by Neil Conway. Please figure out by yourselves who might be the one