Re: [PATCHES] [PATCH] Add support for GnuTLS

2006-05-31 Thread Bruce Momjian
Andrew Dunstan wrote: > Tom Lane wrote: > > FWIW, Red Hat's legal department thinks that the FSF has "overreached" > > in claiming that the GPL is incompatible with OpenSSL's license. Which > > is why Red Hat isn't worrying about GPL apps that use OpenSSL, of which > > there are quite a few ... >

Re: [PATCHES] [PATCH] Magic block for modules

2006-05-31 Thread Marko Kreen
On 5/8/06, Martijn van Oosterhout wrote: This implements a proposal made last november: http://archives.postgresql.org/pgsql-hackers/2005-11/msg00578.php All it requires is to include the header "pgmagic.h" and to put somewhere in their source: PG_MODULE_MAGIC Could you serve this as spec

Re: [PATCHES] [HACKERS] psql \copy warning

2006-05-31 Thread Bruce Momjian
Patch applied. --- Bruce Momjian wrote: > > I have developed an updated patch that: > > o turns off escape_string_warning in pg_dumpall.c > o optionally use E'' for \password (undocumented option?) > o

Re: [PATCHES] [PATCH] Magic block for modules

2006-05-31 Thread Martijn van Oosterhout
On Wed, May 31, 2006 at 01:08:41PM +0300, Marko Kreen wrote: > On 5/8/06, Martijn van Oosterhout wrote: > >All it requires is to include the header "pgmagic.h" and to put > >somewhere in their source: > > > >PG_MODULE_MAGIC > > Could you serve this as special docstring instead? Eg: > > PG_MODUL

Re: [PATCHES] psql strings and ''

2006-05-31 Thread Bruce Momjian
Patch applied. Thanks. I see now that a state is not required because we are already in the single-quote string at that point, comment added. --- Bruce Momjian wrote: > > Currently, psql single-quote argument strings can

Re: [PATCHES] [PATCH] Magic block for modules

2006-05-31 Thread Marko Kreen
On 5/31/06, Martijn van Oosterhout wrote: On Wed, May 31, 2006 at 01:08:41PM +0300, Marko Kreen wrote: > On 5/8/06, Martijn van Oosterhout wrote: > >All it requires is to include the header "pgmagic.h" and to put > >somewhere in their source: > > > >PG_MODULE_MAGIC > > Could you serve this as s

Re: [PATCHES] [PATCH] Magic block for modules

2006-05-31 Thread Tom Lane
"Marko Kreen" <[EMAIL PROTECTED]> writes: >>> Could you serve this as special docstring instead? Eg: >>> PG_MODULE(foomodule) I have no objection to that, and see no real implementation problem with it: we just add a "const char *" field to the magic block. The other stuff seems too blue-sky, an

[PATCHES] Update link for GUI Tools in FAQ

2006-05-31 Thread Robert Treat
Attached patch updates FAQ 2.3 updating the link for the GUI Tools page to the new page in the new techdocs, along with some verbage changes. Note this link should be updated by all translators. -- Robert Treat Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL Index: FAQ.html

Re: [PATCHES] Allow commenting of variables in postgresql.conf to -

2006-05-31 Thread Zdenek Kotala
There is second version of patch. I made following changes: - fix problem with assertion - use boot_val instead default_val for all configuration data types - add GUC_JUST_RELOAD status to track what is in configuration file or not - revert only commented out variables - add message what is rever

Re: [PATCHES] [PATCH] Magic block for modules

2006-05-31 Thread Martijn van Oosterhout
On Wed, May 31, 2006 at 11:14:27AM -0400, Tom Lane wrote: > Is it worth adding a module name to the magic block, or should we just > leave well enough alone? It's certainly not something foreseen as part > of the purpose of that block. In the absence of some fairly concrete > ideas what to do wit

Re: [PATCHES] Allow commenting of variables in postgresql.conf to - try2

2006-05-31 Thread Joachim Wieland
Zdenek, On Wed, May 31, 2006 at 06:13:04PM +0200, Zdenek Kotala wrote: > Joachim, could you explain me second point? I cannot determine > described problem. By my opinion my patch does not change this behavior. I guess what I saw was another phenomenon: I do the following: - vi postgresql.con

Re: [PATCHES] [PATCH] Magic block for modules

2006-05-31 Thread Marko Kreen
On 5/31/06, Tom Lane <[EMAIL PROTECTED]> wrote: "Marko Kreen" <[EMAIL PROTECTED]> writes: >>> Could you serve this as special docstring instead? Eg: >>> PG_MODULE(foomodule) I have no objection to that, and see no real implementation problem with it: we just add a "const char *" field to the ma

Re: [PATCHES] [PATCH] Magic block for modules

2006-05-31 Thread Martijn van Oosterhout
On Wed, May 31, 2006 at 11:14:27AM -0400, Tom Lane wrote: > ... The other > stuff seems too blue-sky, and I'm not even sure that it's the right > direction to proceed in. Marko seems to be envisioning a future where > an extension module is this binary blob with install/deinstall/etc code > all

Re: [PATCHES] [HACKERS] psql \copy warning

2006-05-31 Thread Tom Lane
Bruce Momjian writes: >> I have developed an updated patch that: >> >> o turns off escape_string_warning in pg_dumpall.c >> o optionally use E'' for \password (undocumented option?) >> o honor standard_conforming-strings for \copy (but not >> support literal E'' strings) >> o optionally use E

Re: [PATCHES] [HACKERS] psql \copy warning

2006-05-31 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > >> I have developed an updated patch that: > >> > >> o turns off escape_string_warning in pg_dumpall.c > >> o optionally use E'' for \password (undocumented option?) > >> o honor standard_conforming-strings for \copy (but not > >> support literal E'' s

Re: [PATCHES] [PATCH] Improve EXPLAIN ANALYZE overhead by sampling

2006-05-31 Thread Martijn van Oosterhout
On Tue, May 30, 2006 at 10:01:49AM -0400, Bruce Momjian wrote: > > Patch applied. Thanks. I note Tom made some changes to this patch after it went in. For the record, it was always my intention that samplecount count the number of _tuples_ returned while sampling, rather than the number of _iter