Re: [PATCHES] Have psql display names and OUT/INOUT in \df output

2006-07-16 Thread David Fetter
On Sat, Jul 15, 2006 at 04:42:50PM -0700, David Fetter wrote: Folks, This patch makes psql's \df display functions with the names of parameters and OUT/INOUT if appropriate. Should there be a regression test for this? A doc patch? As this doesn't change any documented behavior, it doesn't

Re: [PATCHES] Have psql display names and OUT/INOUT in \df output

2006-07-16 Thread Neil Conway
On Sat, 2006-07-15 at 23:16 -0700, David Fetter wrote: Anyhow, please find enclosed the context-style diff. How carefully did you test this? postgres=# \df abc List of functions Schema | Name | Result data type | Argument data types

Re: [PATCHES] Have psql display names and OUT/INOUT in \df output

2006-07-16 Thread David Fetter
On Sun, Jul 16, 2006 at 12:21:12AM -0700, Neil Conway wrote: On Sat, 2006-07-15 at 23:16 -0700, David Fetter wrote: Anyhow, please find enclosed the context-style diff. How carefully did you test this? Not enough. Here's the latest. postgres=# \df abc List of

Re: [PATCHES] Have psql display names and OUT/INOUT in \df output

2006-07-16 Thread Neil Conway
On Sun, 2006-07-16 at 01:00 -0700, David Fetter wrote: On Sun, Jul 16, 2006 at 12:21:12AM -0700, Neil Conway wrote: You need to schema-qualify references to builtin functions, to avoid accidentally using functions of the same name that appear earlier in the user's search path. I don't

Re: [PATCHES] Restartable Recovery

2006-07-16 Thread Andreas Seltenreich
Simon Riggs [EMAIL PROTECTED] writes: [2. text/x-patch; restartableRecovery.patch] Hmm, wouldn't you have to reboot the resource managers at each checkpoint? I'm afraid otherwise things like postponed page splits could get lost on restart from a later checkpoint. regards, andreas

Re: [PATCHES] Have psql display names and OUT/INOUT in \df output

2006-07-16 Thread David Fetter
On Sun, Jul 16, 2006 at 05:16:58AM -0700, Neil Conway wrote: On Sun, 2006-07-16 at 01:00 -0700, David Fetter wrote: On Sun, Jul 16, 2006 at 12:21:12AM -0700, Neil Conway wrote: You need to schema-qualify references to builtin functions, to avoid accidentally using functions of the same

Re: [PATCHES] Restartable Recovery

2006-07-16 Thread Tom Lane
Andreas Seltenreich [EMAIL PROTECTED] writes: Simon Riggs [EMAIL PROTECTED] writes: [2. text/x-patch; restartableRecovery.patch] Hmm, wouldn't you have to reboot the resource managers at each checkpoint? I'm afraid otherwise things like postponed page splits could get lost on restart from a

Re: [PATCHES] Restartable Recovery

2006-07-16 Thread Simon Riggs
On Sun, 2006-07-16 at 10:51 -0400, Tom Lane wrote: Andreas Seltenreich [EMAIL PROTECTED] writes: Simon Riggs [EMAIL PROTECTED] writes: [2. text/x-patch; restartableRecovery.patch] Hmm, wouldn't you have to reboot the resource managers at each checkpoint? I'm afraid otherwise things like

Re: [PATCHES] Have psql display names and OUT/INOUT in \df output

2006-07-16 Thread Neil Conway
On Sun, 2006-07-16 at 07:18 -0700, David Fetter wrote: Thanks for clarifying this. Patch attached. Applied, with one more fix: format_type's second argument should be NULL if it is not otherwise known. Thanks for the patch. (Speaking of which, there is probably room for a one-parameter version

[PATCHES] pg_dump: multiple tables, schemas with exclusions and wildcards

2006-07-16 Thread Greg Sabino Mullane
Here's the latest pg_dump patch I've been (too sporadically) working on. I abandoned building linked lists and decided to make the backend do all the work, from building the list of good relations, to doing the POSIX regex matching. I've added numerous examples to the docs, but it may still need