Re: [PATCHES] [HACKERS] Possible explanation for Win32 stats regression test

2006-07-29 Thread [EMAIL PROTECTED]
Is anyone working on this? Tom Lane wrote: > korry <[EMAIL PROTECTED]> writes: > > The problem is that, each time you go through > > pgwin32_waitforsinglesocket(), you tie the *same* kernel object > > (waitevent is static) to each socket. > > > The fix is pretty simple - just call WSAEventS

Re: [PATCHES] [HACKERS] Possible explanation for Win32 stats regression

2006-07-29 Thread Andrew Dunstan
heh. I was just doing it the way Tom suggested - see attached. With a little more trouble we could also keep track if the listened for events and sometimes save ourselves a second call to WSAEventSelect, but I'm not sure it's worth it. cheers andrew [EMAIL PROTECTED] wrote: Is anyone wor

Re: [PATCHES] [HACKERS] More #ifdef fun: src/interfaces/libpq/win32.c

2006-07-29 Thread Bruce Momjian
Tom Lane wrote: > src/interfaces/libpq/win32.c contains > > /* Declared here to avoid pulling in all includes, which causes name > collissions */ > #ifdef ENABLE_NLS > extern char * > libpq_gettext(const char *msgid) > __attribute__((format_arg(1))); > #else > #define libpq_gettext(x) (x) > #end

Re: [HACKERS] [PATCHES] putting CHECK_FOR_INTERRUPTS in

2006-07-29 Thread Bruce Momjian
Are we done with the sort interrupt issue mentioned in the subject line, and the issue outlined below? --- Tom Lane wrote: > "Charles Duffy" <[EMAIL PROTECTED]> writes: > > ... For the 'long' data, the compare moves on right

Re: [PATCHES] CREATE INDEX ... ONLINE

2006-07-29 Thread Bruce Momjian
Still discussion about keyword use. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. ---

Re: [PATCHES] [HACKERS] Possible explanation for Win32 stats

2006-07-29 Thread [EMAIL PROTECTED]
heh. I was just doing it the way Tom suggested - see attached. With a little more trouble we could also keep track if the listened for events and sometimes save ourselves a second call to WSAEventSelect, but I'm not sure it's worth it. It all depends on the overhead of WSAEventSelect()

Re: [PATCHES] [HACKERS] Possible explanation for Win32 stats regression

2006-07-29 Thread Andrew Dunstan
[EMAIL PROTECTED] wrote: heh. I was just doing it the way Tom suggested - see attached. With a little more trouble we could also keep track if the listened for events and sometimes save ourselves a second call to WSAEventSelect, but I'm not sure it's worth it. It all depends on the overh

Re: [PATCHES] [HACKERS] pg_regress breaks on msys

2006-07-29 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I modified pg_regress.c to use just the return code to determine if the > diff worked, but I added in a WIN32-specific test for the file size. I > think that is the cleanest solution. Attached. It really needs a comment, along the lines of /*

Re: [HACKERS] [PATCHES] putting CHECK_FOR_INTERRUPTS in

2006-07-29 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Are we done with the sort interrupt issue mentioned in the subject line, > and the issue outlined below? I'm inclined not to apply the proposed patch (adding CHECK_FOR_INTERRUPTS) because of the risk of memory leakage inside qsort. OTOH you could argue

[PATCHES] New variable server_version_num

2006-07-29 Thread Greg Sabino Mullane
Today on IRC David Fetter and some others were discussing version numbers and we realized that although libpq now provides the version of Postgres as a number, this is still a wheel that is being reinvented by apps many times over, as it is not available any other way. Hence, a small patch to provi

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-29 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: >> I'm afraid though that after 2 or so days heading down the last path you >> suggested (namely making a new jointree leaf node) I was having trouble, >> and at the same time came to the conclusion that adding a new RTE was >> alot cleaner and made more se

Re: [PATCHES] [HACKERS] 8.2 features?

2006-07-29 Thread Joe Conway
Tom Lane wrote: Joe Conway <[EMAIL PROTECTED]> writes: I'm afraid though that after 2 or so days heading down the last path you suggested (namely making a new jointree leaf node) I was having trouble, and at the same time came to the conclusion that adding a new RTE was alot cleaner and made

Re: [PATCHES] New variable server_version_num

2006-07-29 Thread Tom Lane
Greg Sabino Mullane <[EMAIL PROTECTED]> writes: > small patch to provide a new variable "server_version_num", which is > almost the same as "server_version" but uses the handy PG_VERSION_NUM > which allows apps to do things like if ($version >= 80200) without > having to parse apart the value of se

Re: [PATCHES] [HACKERS] pg_regress breaks on msys

2006-07-29 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I modified pg_regress.c to use just the return code to determine if the > > diff worked, but I added in a WIN32-specific test for the file size. I > > think that is the cleanest solution. Attached. > > It really needs a comment, alo

Re: [HACKERS] [PATCHES] putting CHECK_FOR_INTERRUPTS in

2006-07-29 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Are we done with the sort interrupt issue mentioned in the subject line, > > and the issue outlined below? > > I'm inclined not to apply the proposed patch (adding > CHECK_FOR_INTERRUPTS) because of the risk of memory leakage inside >

Re: [PATCHES] PATCH to allow concurrent VACUUMs to not lock each

2006-07-29 Thread Bruce Momjian
Alvaro has just applied a modified version of this patch. --- Hannu Krosing wrote: > On E, 2005-05-23 at 11:42 -0400, Tom Lane wrote: > > Hannu Krosing <[EMAIL PROTECTED]> writes: > > > I can't think of any other cases where

Re: [PATCHES] New variable server_version_num

2006-07-29 Thread David Fetter
On Sat, Jul 29, 2006 at 09:44:10PM -0400, Tom Lane wrote: > Greg Sabino Mullane <[EMAIL PROTECTED]> writes: > > small patch to provide a new variable "server_version_num", which > > is almost the same as "server_version" but uses the handy > > PG_VERSION_NUM which allows apps to do things like if (