Re: [PATCHES] XML syntax patch

2006-09-06 Thread Peter Eisentraut
Am Dienstag, 5. September 2006 03:21 schrieb Bruce Momjian: > I have received an update XML syntax patch from Nikolay (summer of code) > based on David Fetter's patch from 2005. > > Comments? It would be nice to have for 8.2. I've told you privately already, I think it would be a grave mistake to

Re: [PATCHES] XML syntax patch

2006-09-06 Thread Peter Eisentraut
Am Mittwoch, 6. September 2006 17:28 schrieb Bruce Momjian: > Uh, when? You had Nikolay review David's patch to see if it could be > made consistent enough so it could go into 8.2 and not conflict with the > additions in 8.3. The only thing we could justify under the feature freeze regime is to a

Re: [PATCHES] XML syntax patch

2006-09-06 Thread Bruce Momjian
Peter Eisentraut wrote: > Am Mittwoch, 6. September 2006 17:28 schrieb Bruce Momjian: > > Uh, when? You had Nikolay review David's patch to see if it could be > > made consistent enough so it could go into 8.2 and not conflict with the > > additions in 8.3. > > The only thing we could justify und

Re: [PATCHES] XML syntax patch

2006-09-06 Thread Bruce Momjian
Peter Eisentraut wrote: > Am Dienstag, 5. September 2006 03:21 schrieb Bruce Momjian: > > I have received an update XML syntax patch from Nikolay (summer of code) > > based on David Fetter's patch from 2005. > > > > Comments? It would be nice to have for 8.2. > > I've told you privately already,

Re: [PATCHES] [HACKERS] Open items for 8.2

2006-09-06 Thread Tom Lane
Tom Lane <[EMAIL PROTECTED]> writes: > Peter Eisentraut <[EMAIL PROTECTED]> writes: >> Am Dienstag, 5. September 2006 05:58 schrieb Tom Lane: >>> A couple of recently discussed FE/BE protocol issues are: not storing a >>> plan at all for unnamed-statement cases, and thus allowing bind >>> parameter

Re: [PATCHES] [HACKERS] Coding style for emacs

2006-09-06 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: Looking at this further, I am wondering if it would not be better to put sample .emacs and .vimrc files in the source (in, say, src.tools). Seems reasonable. I was about to say "what if they're just looking at the docs and don

Re: [PATCHES] BUG #2600: dblink compile with SSL missing libraries

2006-09-06 Thread Chris Browne
The change Tom made to contrib/sshinfo/Makefile to support Darwin, adding in $(LIBS), fixed my problem with that contrib module on AIX. I still need the following, on AIX: === RCS file: /projects/cvsroot/pgsql/contrib/dblink/Makefile

Re: [PATCHES] [HACKERS] Coding style for emacs

2006-09-06 Thread Bruce Momjian
Patch applied. Thanks. Added to /tools/editors. --- Andrew Dunstan wrote: > Tom Lane wrote: > > Andrew Dunstan <[EMAIL PROTECTED]> writes: > > > >> Looking at this further, I am wondering if it would not be better to pu

Re: [PATCHES] BUG #2600: dblink compile with SSL missing libraries

2006-09-06 Thread Tom Lane
Chris Browne <[EMAIL PROTECTED]> writes: > I still need the following, on AIX: > -SHLIB_LINK = $(libpq) > +SHLIB_LINK = $(libpq) $(LIBS) No you don't --- see recent warthog complaint. We have to filter LIBS down to just the minimum. regards, tom lane ---