Re: [PATCHES] Writing WAL for relcache invalidation:pg_internal.init

2006-11-02 Thread Simon Riggs
On Wed, 2006-11-01 at 12:05 -0500, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: Enclose a patch for new WAL records for relcache invalidation. I don't think this works. RelationCacheInitFileInvalidate is executed post-commit, which means that there's a window between commit and

Re: [PATCHES] Writing WAL for relcache invalidation:pg_internal.init

2006-11-02 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: On Wed, 2006-11-01 at 12:05 -0500, Tom Lane wrote: I don't think this works. Surely you are pointing out a bug, no? If a backend did crash, the init file would be wrong and we'd get exactly the same wrong relfilenode errors we got after that PITR.

[PATCHES] Micro-doc patch for CREATE FUNCTION

2006-11-02 Thread Joachim Wieland
It is not obvious that a function should be declared RETURNS VOID if it is not supposed to return a value. There's also a user-comment on the 8.1 doc-page. Joachim Index: create_function.sgml === RCS file:

[PATCHES] Patch for SPI subtransaction memory leakage

2006-11-02 Thread Tom Lane
I noticed a gripe about plpgsql exceptions leaking memory: http://archives.postgresql.org/pgsql-performance/2006-11/msg00032.php (woulda been nice if he'd reported it more formally, but whatever.) Some experimentation shows that there is indeed an issue, eg this function leaks about 16K per

Re: [PATCHES] Micro-doc patch for CREATE FUNCTION

2006-11-02 Thread Tom Lane
Joachim Wieland [EMAIL PROTECTED] writes: It is not obvious that a function should be declared RETURNS VOID if it is not supposed to return a value. Done, thanks. regards, tom lane ---(end of broadcast)--- TIP 4: Have you