[PATCHES] Caveat Caveat

2006-11-16 Thread Simon Riggs
I noticed that the Partitioning section of the docs has *two* sections of caveats in different places, but close together. One called caveats, one not. That looks like it just led to somebody not reading some appropriate caveats in the second group of caveats (on -admin). Doc patch only. Combines

Re: [PATCHES] replication docs: split single vs. multi-master

2006-11-16 Thread Bruce Momjian
Markus Schiltknecht wrote: Hi, as promised on -docs, here comes my proposal on how to improve the replication documentation. The patches are split as follows and have to be applied in order: replication_doku_1.diff: Smallest possible one-word change to warm-up... Done.

Re: [PATCHES] replication docs: split single vs. multi-master

2006-11-16 Thread Markus Schiltknecht
Hello Bruce, Bruce Momjian wrote: Actually the patch moves down data paritioning. I am confused. Uh.. yeah, sorry, that's what I meant. I thought a long time about this. I have always liked splitting the solutions up into single and multi-master, but in doing this documentation section, I

Re: [PATCHES] replication docs: split single vs. multi-master

2006-11-16 Thread Bruce Momjian
Bruce Momjian wrote: I didn't mention distributed shared memory as a separate item because I felt it was an implementation detail of clustering, rather than something separate. I kept two-phase in the cluster item for the same reason. Current version at:

[PATCHES] Cast null to int4 upgrading from Version 7.2

2006-11-16 Thread Dwight Emmons
My company is currently using version 7.2 and would like to convert to the latest version. Unfortunately, version 7.3 implicitly casts a null text to an int4. For example: Create table employee_table ( employee_id integer employee_name text employee_address text); Select *

Re: [PATCHES] replication docs: split single vs. multi-master

2006-11-16 Thread Markus Schiltknecht
Bruce Momjian wrote: I am now attaching the additional text I added based on your comments. I have also changed the markup so all the solutions appear on the same web page. I think seeing it all together might give us new ideas for improvement. Good, it's definitely better to have it all on

Re: [PATCHES] Cast null to int4 upgrading from Version 7.2

2006-11-16 Thread Andrew Dunstan
Dwight Emmons wrote: [Why did you post this to pgsql-patches of all places? it should properly have gone to pgsql-general, I think] My company is currently using version 7.2 and would like to convert to the latest version. Unfortunately, version 7.3 implicitly casts a null text to an int4.

Re: [PATCHES] [HACKERS] Extended protocol logging

2006-11-16 Thread Bruce Momjian
Simon Riggs wrote: On Wed, 2006-11-01 at 10:06 -0500, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: On Tue, 2006-10-31 at 23:51 -0500, Tom Lane wrote: With what logging settings? log_duration has rather different behavior from what it used to do. I think it would be

[PATCHES] Proposed patch for xact-vs-multixact bugs

2006-11-16 Thread Tom Lane
The attached patch fixes the problem discussed here http://archives.postgresql.org/pgsql-hackers/2006-11/msg00357.php as well as a related problem that I discovered while working on it: the sequence begin; savepoint x; select * from foo for update; release savepoint x; select * from foo for

Re: [PATCHES] Cast null to int4 upgrading from Version 7.2

2006-11-16 Thread Jim Nasby
On Nov 16, 2006, at 3:10 PM, Neil Conway wrote: Yes, this is a common problem for people upgrading from 7.2. I think the long-term fix is to change your queries: comparing an integer with '' is not sensible. That is: SELECT * FROM employee_table WHERE employee_id = 0; is the right way to

Re: [PATCHES] Cast null to int4 upgrading from Version 7.2

2006-11-16 Thread Peter Eisentraut
Jim Nasby wrote: As a less invasive alternative, I *think* you could create an SQL function for casting text to int that treated '' as 0, and then replace the built-in CAST with that. Won't work. You need to replace the data type input function. -- Peter Eisentraut