Here's an updated patch that fixes a bug with full_page_writes, and an
alignment issue in replay code. Also added a new test case to
crashtest.sh that exercises the fixed bug.
Has anyone looked at this? I now consider it ready for committing, if
no-one sees a problem with it.
Here's the
Applied.
---
Bruce Momjian wrote:
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
OK, are you saying that there is a signal we are ignoring for
overflow/underflow, or that we should just silently
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
Euler
Tom Lane wrote:
Andrew Dunstan [EMAIL PROTECTED] writes:
... And then we'd need to change the regression makefile to use
the option, based on an environment variable a bit like MAX_CONNEXCTIONS
maybe.
Why wouldn't we just use it always? If a regression test dumps core,
that's going
Patch applied. Thanks.
---
Glen Parker wrote:
This patch consists of two c functions to expose n_live_tuples and
n_dead_tuples, SQL functions to expose them to SQL land, and
corresponding fields added to
Andrew Dunstan [EMAIL PROTECTED] writes:
Revised patch attached, doing just this. I will apply it soon unless
there are objections.
Probably a good idea to check defined(HAVE_GETRLIMIT) defined(RLIMIT_CORE),
rather than naively assuming every getrlimit implementation supports
that particular
Tom Lane wrote:
Andrew Dunstan [EMAIL PROTECTED] writes:
Revised patch attached, doing just this. I will apply it soon unless
there are objections.
Probably a good idea to check defined(HAVE_GETRLIMIT) defined(RLIMIT_CORE),
rather than naively assuming every getrlimit implementation
Thanks to Simon Riggs and Bruce for input that helped me put this together.
--
Bill Moran
Collaborative Fusion Inc.
diff -c -r src.orig/backend/storage/file/fd.c src/backend/storage/file/fd.c
*** src.orig/backend/storage/file/fd.c Thu Dec 7 15:44:42 2006
--- src/backend/storage/file/fd.c Tue
Bill Moran wrote:
Thanks to Simon Riggs and Bruce for input that helped me put this together.
Please change things to save the stat() syscall when the feature is not
in use.
Nitpick: also note our brace placement convention (though this would be
fixed by pgindent, but still).
--
Alvaro
Bill Moran wrote:
+ if (stat(vfdP-fileName, filestats) == 0) {
+ if (trace_temp_files)
Shouldn't these tests be the other way around?
cheers
andrew
---(end of broadcast)---
TIP 7: You can help support the
In response to Alvaro Herrera [EMAIL PROTECTED]:
Bill Moran wrote:
Thanks to Simon Riggs and Bruce for input that helped me put this together.
Please change things to save the stat() syscall when the feature is not
in use.
Do you have a suggestion on how to do that and still have the
Bill Moran [EMAIL PROTECTED] writes:
In response to Alvaro Herrera [EMAIL PROTECTED]:
Please change things to save the stat() syscall when the feature is not
in use.
Do you have a suggestion on how to do that and still have the PG_TRACE1()
work? That was specifically requested by Simon
12 matches
Mail list logo
