Re: [PATCHES] Updated bitmap index patch

2007-05-04 Thread Finlay Thompson
Hi Gavin Thanks for the new patch! I ran some address matching on the patched code and have generated another "ERROR: out of memory" problem. The strange thing is that it runs over 150 queries without problem and then crashes. I have attached the logfile (well some of it). If you want I can

Re: [PATCHES] document plperl argument and return value representation

2007-05-04 Thread Alvaro Herrera
Andrew Dunstan wrote: > > > Alvaro Herrera wrote: > >Andrew Dunstan wrote: > > > >>The attached docs patch makes clearer how arguments and return values in > >>pl/perl are escaped. This is to clarify the situation that Theo > >>Schlossnagle recently reported on -bugs. > >> > > > >I find t

[PATCHES] small patch for guc issues

2007-05-04 Thread Joachim Wieland
The appended patch addresses the outstanding issues of the recent guc patch. It makes PGCLIENTENCODING work again and uses bsearch() instead of iterating over the array of guc variables in guc_get_index(). Joachim Index: src/backend/utils/misc/guc.c

Re: [PATCHES] updated SORT/LIMIT patch

2007-05-04 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Gregory Stark <[EMAIL PROTECTED]> writes: >> Updated patch against cvs update in case it makes applying easier. > > Applied with revisions --- notably, I avoided adding any overhead to > HEAPCOMPARE() by the expedient of reversing the logical sort order > b

Re: [PATCHES] updated SORT/LIMIT patch

2007-05-04 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > Hum. The major change I see is the bit related to rescans where you made it > resort if the bound had changed. But surely the only way the bound can change > is if it's a parameter, and if there is a parameter then surely the executor > must be doing more

Re: [PATCHES] Updated bitmap index patch

2007-05-04 Thread Jie Zhang
Finlay, Thanks for testing. If you can send me the schema, that would be great. Thanks, Jie On 5/4/07 5:41 AM, "Finlay Thompson" <[EMAIL PROTECTED]> wrote: > Hi Gavin > > Thanks for the new patch! > > I ran some address matching on the patched code and have generated > another "ERROR: out o

Re: [PATCHES] updated SORT/LIMIT patch

2007-05-04 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Gregory Stark <[EMAIL PROTECTED]> writes: >> What does the executor do differently in the case of a subplan with a >> parameter that makes it re-execute the plan from scratch and not just do a >> simple rescan? > > Look at the chgParam signaling. Since a S

Re: [PATCHES] updated SORT/LIMIT patch

2007-05-04 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > "Tom Lane" <[EMAIL PROTECTED]> writes: >> Look at the chgParam signaling. Since a Sort node itself has no >> parameters, it historically has only had to re-sort if its input node >> suffers a parameter change, which it checks in ExecReScanSort. But now

Re: [PATCHES] small patch for guc issues

2007-05-04 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Jo

Re: [PATCHES] [WIP] GUC for temp_tablespaces

2007-05-04 Thread Jaime Casanova
On 5/3/07, Bruce Momjian <[EMAIL PROTECTED]> wrote: Your patch has been added to the PostgreSQL unapplied patches list at: This is an updated version of the patch. Tom objections: - fd.c is too low level for calling code from commands/tablespace.c. This was fixed adding a second parameter t