Re: [PATCHES] Maintaining cluster order on insert

2007-06-17 Thread Heikki Linnakangas
Jaime Casanova wrote: On 5/27/07, Jim C. Nasby [EMAIL PROTECTED] wrote: On Mon, May 21, 2007 at 10:48:59AM +0100, Heikki Linnakangas wrote: IOW it's working as designed. But maybe it's not the desired behavior. Should we have a special case and always respect the fillfactor when inserting

Re: [PATCHES] Load Distributed Checkpoints, revised patch

2007-06-17 Thread Heikki Linnakangas
Simon Riggs wrote: On Fri, 2007-06-15 at 11:34 +0100, Heikki Linnakangas wrote: - What units should we use for the new GUC variables? From implementation point of view, it would be simplest if checkpoint_write_rate is given as pages/bgwriter_delay, similarly to bgwriter_*_maxpages. I never

Re: [PATCHES] Load Distributed Checkpoints, revised patch

2007-06-17 Thread Simon Riggs
On Sun, 2007-06-17 at 08:51 +0100, Heikki Linnakangas wrote: We don't really care about units because the way you use it is to nudge it up a little and see if that works etc.. Not necessarily. If it's given in KB/s, you might very well have an idea of how much I/O your hardware is

Re: [PATCHES] Load Distributed Checkpoints, revised patch

2007-06-17 Thread Heikki Linnakangas
Simon Riggs wrote: On Sun, 2007-06-17 at 08:51 +0100, Heikki Linnakangas wrote: Do we need to know it so exactly that we look at WALInsertLock? Maybe use info_lck to request the latest page, since that is less heavily contended and we need never wait across I/O. Is there such a value available,

Re: [PATCHES] Load Distributed Checkpoints, revised patch

2007-06-17 Thread Simon Riggs
On Sun, 2007-06-17 at 12:00 +0100, Heikki Linnakangas wrote: Simon Riggs wrote: On Sun, 2007-06-17 at 08:51 +0100, Heikki Linnakangas wrote: Do we need to know it so exactly that we look at WALInsertLock? Maybe use info_lck to request the latest page, since that is less heavily contended

Re: [PATCHES] Load Distributed Checkpoints, revised patch

2007-06-17 Thread Heikki Linnakangas
Simon Riggs wrote: XLogCtl-LogwrtRqst.Write is updated every time we insert an xlog record that advances to a new page. It isn't exactly up to date, but it lags behind by no more than a page. Oh, ok. That would work just fine then. -- Heikki Linnakangas EnterpriseDB

[PATCHES] WIP: rewrite numeric division

2007-06-17 Thread Tom Lane
I wrote: I just blew the dust off my old copy of Knuth vol 2, and see that his algorithm for multi-precision division generates output digits that are correct to start with (or at least he never needs to revisit a digit after moving on to the next). ISTM we should go over to an approach like

Re: [PATCHES] Maintaining cluster order on insert

2007-06-17 Thread Tom Lane
Heikki Linnakangas [EMAIL PROTECTED] writes: The implementation has changed a bit since August. I thought I had submitted an updated version in the winter but couldn't find it. Anyway, I updated and dusted off the source tree, tidied up the comments a little bit, and fixed some inconsistencies

Re: [PATCHES] Maintaining cluster order on insert

2007-06-17 Thread Heikki Linnakangas
Tom Lane wrote: Heikki Linnakangas [EMAIL PROTECTED] writes: The implementation has changed a bit since August. I thought I had submitted an updated version in the winter but couldn't find it. Anyway, I updated and dusted off the source tree, tidied up the comments a little bit, and fixed some