Re: [PATCHES] SPI-header-files safe for C++-compiler

2007-06-28 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: On Thu, 2007-28-06 at 01:15 -0400, Tom Lane wrote: The patch as given merely renames some random identifiers that happen to be keywords in some non-C language ... The fact is, any user-written extensions that depend on types defined in parsenodes.h and

Re: [PATCHES] SPI-header-files safe for C++-compiler

2007-06-28 Thread Neil Conway
On Thu, 2007-28-06 at 02:07 -0400, Tom Lane wrote: It was already pointed out upthread that wrapping the inclusions in extern C {...} would fix the identifier part of the problem from the user side No, my point about extern C was that I don't think we need to add it to the Postgres headers. As

Re: [PATCHES] psql: add volatility to \df+

2007-06-28 Thread Neil Conway
On Tue, 2007-26-06 at 15:10 -0700, Neil Conway wrote: Attached is a patch that adds information about function volatility to the output of psql's \df+ slash command. I'll apply this to HEAD tomorrow, barring any objections. Applied. -Neil ---(end of

Re: [PATCHES] Load Distributed Checkpoints, final patch

2007-06-28 Thread Heikki Linnakangas
Tom Lane wrote: Heikki Linnakangas [EMAIL PROTECTED] writes: Here's latest revision of Itagaki-sans Load Distributed Checkpoints patch: Applied with some minor revisions to make some of the internal APIs a bit cleaner; mostly, it seemed like a good idea to replace all those bool parameters

Re: [PATCHES] SPI-header-files safe for C++-compiler

2007-06-28 Thread Jacob Rief
Tom Lane wrote: Sure, but we don't break them just on a whim. The bottom line here is whether we are going to make a real commitment to making C++ usable as a backend extension language --- and for the reasons I mentioned, that would entail a lot more than renaming a few identifiers. It was

[PATCHES] Doc update for pg_start_backup

2007-06-28 Thread Heikki Linnakangas
Added a note to the docs that pg_start_backup can take a long time to finish now that we spread out checkpoints: *** doc/src/sgml/backup.sgml1 Feb 2007 00:28:16 - 2.97 --- doc/src/sgml/backup.sgml28 Jun 2007 11:44:20 - *** *** 672,678 para It

Re: [PATCHES] Load Distributed Checkpoints, final patch

2007-06-28 Thread Greg Smith
On Wed, 27 Jun 2007, Tom Lane wrote: Also, the question of redesigning the bgwriter's LRU scan is still open. I believe that's on Greg's plate, too. Greg's plate was temporarily fried after his house was hit by lightening yesterday. I just got everything back on-line again, so no coding

Re: [PATCHES] Load Distributed Checkpoints, final patch

2007-06-28 Thread Tom Lane
Heikki Linnakangas [EMAIL PROTECTED] writes: The comment in PreallocXlogFiles is out of date: Yeah, I changed it yesterday ... As you pointed out, it only preallocates one log file. And there is no XLOGfile mentioned anywhere else in the source tree. If memory serves, there once was a

Re: [PATCHES] Doc update for pg_start_backup

2007-06-28 Thread Tom Lane
Heikki Linnakangas [EMAIL PROTECTED] writes: Added a note to the docs that pg_start_backup can take a long time to finish now that we spread out checkpoints: Rather than suggesting twiddling checkpoint_completion_target, should we suggest a manual CHECKPOINT command before pg_start_backup?

[PATCHES] configure.in / xml / quoting trouble

2007-06-28 Thread Patrick Welche
I found I needed the enclosed patch when configuring today's CVS - I haven't been keeping up since 8.2beta3. The first part I needed when configuring --with-libxml. Why go to the effort of finding xml2-config, and then disbelieve what it tells you? The second part is a shell quoting problem. As

Re: [PATCHES] configure.in / xml / quoting trouble

2007-06-28 Thread Andrew Dunstan
Patrick Welche wrote: I found I needed the enclosed patch when configuring today's CVS - I haven't been keeping up since 8.2beta3. The first part I needed when configuring --with-libxml. Why go to the effort of finding xml2-config, and then disbelieve what it tells you? Which in

Re: [PATCHES] configure.in / xml / quoting trouble

2007-06-28 Thread Tom Lane
Patrick Welche [EMAIL PROTECTED] writes: The first part I needed when configuring --with-libxml. Why go to the effort of finding xml2-config, and then disbelieve what it tells you? This proposed change puts CFLAGS into CPPFLAGS; maybe the libxml guys have not understood the difference, but we

Re: [PATCHES] configure.in / xml / quoting trouble

2007-06-28 Thread Andrew Dunstan
Patrick Welche wrote: The one that broke things for me in NetBSD is the rpath flag that got ignored. The thing is, if xml2-config is meant to give the flags necessary to compile a programme with libxml, then why pick-and-choose which flags you are going to use? Should a library we are

Re: [PATCHES] configure.in / xml / quoting trouble

2007-06-28 Thread Tom Lane
Patrick Welche [EMAIL PROTECTED] writes: The thing is, if xml2-config is meant to give the flags necessary to compile a programme with libxml, then why pick-and-choose which flags you are going to use? Well, if they gave the flags in a sane format (distinguishing CPPFLAGS from CFLAGS, and

Re: [PATCHES] WIP CSV logs

2007-06-28 Thread Andrew Dunstan
Andrew Dunstan wrote: Here is a WIP patch of the CSV logs work brought up to date with CVS HEAD. One large change I made was to multiplex the selects on the pipes - previously it waited on one then the other - this seems almost to defeat the purpose of using select() :-) It seems to