Re: [PATCHES] actualised execute using patch

2008-03-26 Thread Pavel Stehule
On 25/03/2008, Zdenek Kotala [EMAIL PROTECTED] wrote: you have extra space onPavel Stehule napsal(a): Hello http://archives.postgresql.org/pgsql-patches/2007-10/msg00161.php I actualized this patch for current CVS Hi Pavel, I tested your patch and it works regarding to

Re: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-03-26 Thread Alvaro Herrera
Bruce Momjian escribió: This has been saved for the next commit-fest: I noticed you broke an URL that previously worked: what was http://momjian.us/mhonarc/patches/[EMAIL PROTECTED] is now http://momjian.us/mhonarc/patches_hold/[EMAIL PROTECTED] May I suggest that the URLs with Message-Ids

[PATCHES] \password in psql help

2008-03-26 Thread Magnus Hagander
The \password command appears to be documented in the psql reference page, but not included in the output of the \? command. Is there any actual reason for that, or should I just apply the attached patch? (which means I will apply it unless there are objections :-P) //Magnus Index:

Re: [PATCHES] Consistent \d commands in psql

2008-03-26 Thread Heikki Linnakangas
Greg Sabino Mullane wrote: Attached is an updated version of my psql patch that makes the \d backslash commands perform in an intuitive, consistent way. Specifically, the following objects will be treated as first class citizens (as tables and indexes currently are) by showing all the non-system

Re: [PATCHES] Bulk Insert tuning

2008-03-26 Thread Simon Riggs
On Tue, 2008-02-26 at 15:12 -0500, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: Following patch implements a simple mechanism to keep a buffer pinned while we are bulk loading. This will fail to clean up nicely after a subtransaction abort, no? (For that matter I don't think it's

Re: [PATCHES] \password in psql help

2008-03-26 Thread Heikki Linnakangas
Magnus Hagander wrote: + fprintf(output, _( \\password [USERNAME]\n + securely change the password for a user\n)); I would leave out the word securely. Unless you want to provide another command for changing it insecurely ;-). What does

Re: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-03-26 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian escribi?: This has been saved for the next commit-fest: I noticed you broke an URL that previously worked: what was http://momjian.us/mhonarc/patches/[EMAIL PROTECTED] is now http://momjian.us/mhonarc/patches_hold/[EMAIL PROTECTED] May I suggest

Re: [PATCHES] Friendly help for psql

2008-03-26 Thread Alvaro Herrera
Greg Sabino Mullane wrote: Why not run help when someone enters help (or HELP ME!) on the command line? \? is hardly an easy thing to remember (and some people can't be bothered to actually read the screen...) So, have you produced a followup patch? -- Alvaro Herrera

Re: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-03-26 Thread Alvaro Herrera
Bruce Momjian escribió: Alvaro Herrera wrote: I noticed you broke an URL that previously worked: what was http://momjian.us/mhonarc/patches/[EMAIL PROTECTED] is now http://momjian.us/mhonarc/patches_hold/[EMAIL PROTECTED] May I suggest that the URLs with Message-Ids are stored

Re: [PATCHES] \password in psql help

2008-03-26 Thread Alvaro Herrera
Heikki Linnakangas wrote: Magnus Hagander wrote: +fprintf(output, _( \\password [USERNAME]\n + securely change the password for a user\n)); I would leave out the word securely. Unless you want to provide another command for changing it

Re: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-03-26 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian escribi?: Alvaro Herrera wrote: I noticed you broke an URL that previously worked: what was http://momjian.us/mhonarc/patches/[EMAIL PROTECTED] is now http://momjian.us/mhonarc/patches_hold/[EMAIL PROTECTED] May I suggest that the URLs

Re: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-03-26 Thread Alvaro Herrera
Bruce Momjian escribió: Alvaro Herrera wrote: My point is that you should only _add_ Message-Ids, not remove them. You can move the messages from one queue to the other to your heart's content, but the Message-Id URL should continue to work with no changes. Well, when an email is

Re: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-03-26 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian escribi?: Alvaro Herrera wrote: My point is that you should only _add_ Message-Ids, not remove them. You can move the messages from one queue to the other to your heart's content, but the Message-Id URL should continue to work with no changes.

Re: [PATCHES] pg_dump -i wording

2008-03-26 Thread Bruce Momjian
Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: I have developed the attached patch with improves wording for the pg_dump -i (ignore version) option. I think this is going in exactly the wrong direction --- it makes both the documentation and the

Re: [PATCHES] \password in psql help

2008-03-26 Thread Magnus Hagander
On Wed, 26 Mar 2008 10:43:48 -0300 Alvaro Herrera [EMAIL PROTECTED] wrote: Heikki Linnakangas wrote: Magnus Hagander wrote: + fprintf(output, _( \\password [USERNAME]\n +securely change the password for a user\n)); I would leave out the

Re: [PATCHES] \password in psql help

2008-03-26 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: The \password command appears to be documented in the psql reference page, but not included in the output of the \? command. Is there any actual reason for that, or should I just apply the attached patch? Presumably somebody forgot. While you're at

Re: [PATCHES] \password in psql help

2008-03-26 Thread Magnus Hagander
On Wed, 26 Mar 2008 10:44:43 -0400 Tom Lane [EMAIL PROTECTED] wrote: Magnus Hagander [EMAIL PROTECTED] writes: The \password command appears to be documented in the psql reference page, but not included in the output of the \? command. Is there any actual reason for that, or should I just

[PATCHES] Remove ipcclean

2008-03-26 Thread Bruce Momjian
There are patch queue comments suggesting the removal of the ipcclean command-line utility. ipcclean doesn't work on Windows, and it probably doesn't work perfectly all Unixes either. The attached patch removes the utility, though some files will have to be removed as well. -- Bruce Momjian

Re: [PATCHES] \password in psql help

2008-03-26 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: The \password command appears to be documented in the psql reference page, but not included in the output of the \? command. Is there any actual reason for that, or should I just apply the attached patch? Just to be sure - this is non-backpatch stuff,

Re: [PATCHES] \password in psql help

2008-03-26 Thread Magnus Hagander
On Wed, 26 Mar 2008 11:35:22 -0400 Tom Lane [EMAIL PROTECTED] wrote: Magnus Hagander [EMAIL PROTECTED] writes: The \password command appears to be documented in the psql reference page, but not included in the output of the \? command. Is there any actual reason for that, or should I just

Re: [PATCHES] Moving snapshot code around

2008-03-26 Thread Alvaro Herrera
Tom Lane wrote: I think thinking of snapshot.h as an external interface is wrongheaded. In the proposed refactoring, snapshot.h is concerned with snapshot *management* (creating, copying, deleting) while tqual.h is concerned with tuple visibility testing (which requires a snapshot as an

Re: [PATCHES] Moving snapshot code around

2008-03-26 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: Agreed, it makes a lot more sense considered in this light. I renamed snapshot.{c,h} into snapmgmt.{c,h}, hopefully making the intent clearer. I'd have gone with snapmgr.h/c for consistency with existing filenames (bufmgr, lmgr, etc). One thing I'm

Re: [PATCHES] Moving snapshot code around

2008-03-26 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Agreed, it makes a lot more sense considered in this light. I renamed snapshot.{c,h} into snapmgmt.{c,h}, hopefully making the intent clearer. I'd have gone with snapmgr.h/c for consistency with existing filenames (bufmgr, lmgr,

Re: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-03-26 Thread Bruce Momjian
bruce wrote: I am assuming you use hard links -- obviously this doesn't work with symlinks. (My script creates hard links.) I was using symlinks. I try to avoid hardlinks that cross directories --- not sure why, probably because I can't easily manage them to find out what something is

Re: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-03-26 Thread Alvaro Herrera
Bruce Momjian escribió: OK, I remember now. The problem wasn't symlinks but that mhonarc generates URLs relative to the current directory. If we have message-id files outside the directory, links like Thread Next will not work. We could try to change those to absolute with a script. The

Re: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-03-26 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian escribi?: OK, I remember now. The problem wasn't symlinks but that mhonarc generates URLs relative to the current directory. If we have message-id files outside the directory, links like Thread Next will not work. We could try to change those to

Re: [PATCHES] Moving snapshot code around

2008-03-26 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: Tom Lane wrote: I'd have gone with snapmgr.h/c for consistency with existing filenames (bufmgr, lmgr, etc). Doh! Sorry. We're at the best time for changing the name, since the file has no history. Shall I? +1 I don't like that very much. What

Re: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-03-26 Thread Bruce Momjian
Bruce Momjian wrote: Alvaro Herrera wrote: Bruce Momjian escribi?: OK, I remember now. The problem wasn't symlinks but that mhonarc generates URLs relative to the current directory. If we have message-id files outside the directory, links like Thread Next will not work. We

Re: [PATCHES] Moving snapshot code around

2008-03-26 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Tom Lane wrote: I'd have gone with snapmgr.h/c for consistency with existing filenames (bufmgr, lmgr, etc). Doh! Sorry. We're at the best time for changing the name, since the file has no history. Shall I? +1 Done. --

Re: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-03-26 Thread Alvaro Herrera
Bruce Momjian wrote: Alvaro Herrera wrote: Ahh, thanks for pointing it out. I think I will use an HTTP redirect. How do you know which directory to redirect to? The script gets the directory as a parameter. -- Alvaro Herrerahttp://www.CommandPrompt.com/

Re: [PATCHES] V1.1 patch for TODO Item: SQL-language reference parameters by name.

2008-03-26 Thread Tom Lane
Gevik Babakhani [EMAIL PROTECTED] writes: This is a minor update to 1.0 (corrected some typo here and there). Please see: http://archives.postgresql.org/pgsql-patches/2007-11/msg00253.php I looked this over a bit and feel that it's nowhere near ready to apply. The main problem is that the

Re: [PATCHES] Moving snapshot code around

2008-03-26 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Tom Lane wrote: I don't like that very much. What about just moving the HTSU_Result enum's declaration somewhere else? Two possibilities are heapam.h itself, or the new snapshot.h file (which'd then have to be included by

Re: [PATCHES] Fix pg_dump dependency on postgres.h

2008-03-26 Thread Tom Lane
Zdenek Kotala [EMAIL PROTECTED] writes: Thank your for Your and Alvaro's comments. I attached updated patch version only with YYSTYPE definition. Applied with minor revisions. I fixed pg_conversion.h as well; the only remaining special inclusions in the catalog header files are of pg_list.h.