Re: [PATCHES] [HACKERS] Text - C string

2008-04-16 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 - -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Sat, Mar 29, 2008 at 5:40 AM, Brendan Jurd wrote: On 29/03/2008, Tom Lane wrote: I intentionally didn't touch xml.c, nor anyplace that is not dealing in text, even if it happens to be

Re: [PATCHES] Improve shutdown during online backup

2008-04-16 Thread Simon Riggs
On Tue, 2008-04-08 at 09:16 +0200, Albe Laurenz wrote: Heikki Linnakangas wrote: Albe Laurenz wrote: Moreover, if Shutdown == SmartShutdown, new connections won't be accepted, and nobody can connect and call pg_stop_backup(). So even if I'd add a check for (pmState == PM_WAIT_BACKENDS)

[PATCHES] options for RAISE statement

2008-04-16 Thread Pavel Stehule
Hello this patch adds possibility to set additional options (SQLSTATE, DETAIL, DETAIL_LOG and HINT) for RAISE statement, Proposal: http://archives.postgresql.org/pgsql-hackers/2008-04/msg00919.php I changed keyword from WITH to USING, because I don't would to create new keyword RAISE level

Re: [PATCHES] Reference by output in : \d table_name

2008-04-16 Thread kenneth d'souza
Hi Brendan, I thought you were referring to the spaces sourrounding the word FOREIGN KEY on the last line and hence my explaination was out of place.I am glad that you have corrected the indentation to 4 spaces. Those were unintentional at 2 spaces from myside. However,Why does the word

Re: [PATCHES] Improve shutdown during online backup

2008-04-16 Thread Gregory Stark
Simon Riggs [EMAIL PROTECTED] writes: Personally, I think smart shutdown could be even smarter. It should kick off unwanted sessions, such as an idle pgAdmin session - maybe a rule like anything that has been idle for 30 seconds. That's not a bad idea in itself but I don't think it's

Re: [PATCHES] options for RAISE statement

2008-04-16 Thread Alvaro Herrera
Pavel Stehule escribió: Hello this patch adds possibility to set additional options (SQLSTATE, DETAIL, DETAIL_LOG and HINT) for RAISE statement, Added to May commitfest page, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company -

Re: [PATCHES] [HACKERS] Text - C string

2008-04-16 Thread Tom Lane
Brendan Jurd [EMAIL PROTECTED] writes: If we don't want to meddle with xmltype/bytea/VarChar at all, we'll have to revert those changes, and I'll have to seriously scale back the cleanup patch I was about to post. Still not sure where we stand on the above. To cast, or not to cast? I dunno.

Re: [PATCHES] [HACKERS] Text - C string

2008-04-16 Thread Andrew Dunstan
Tom Lane wrote: Brendan Jurd [EMAIL PROTECTED] writes: If we don't want to meddle with xmltype/bytea/VarChar at all, we'll have to revert those changes, and I'll have to seriously scale back the cleanup patch I was about to post. Still not sure where we stand on the above. To

Re: [PATCHES] Reference by output in : \d table_name

2008-04-16 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, Apr 16, 2008 at 10:00 PM, kenneth d'souza wrote: However,Why does the word FOREIGN KEY appear in the last line of your output. My original patch had the output like this. Referenced by: bar_foo_fkey IN public.bar(foo) REFERENCES

Re: [PATCHES] [HACKERS] Text - C string

2008-04-16 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, Apr 17, 2008 at 1:16 AM, Tom Lane wrote: Brendan Jurd writes: If we don't want to meddle with xmltype/bytea/VarChar at all, we'll have to revert those changes, and I'll have to seriously scale back the cleanup patch I was about to

Re: [PATCHES] printTable API (was: Show INHERIT in \du)

2008-04-16 Thread Alvaro Herrera
Brendan Jurd escribió: The second version of the patch is attached. Thanks. I looked the patch over and did some minor changes. Modified version attached. One thing I'm not entirely happy about is the fact that we need a pointer to the last footer/cell/header, so two pointers for each

Re: [PATCHES] Sorting writes during checkpoint

2008-04-16 Thread Greg Smith
On Wed, 16 Apr 2008, ITAGAKI Takahiro wrote: Dirty region of database was probably larger than disk controller's cache. Might be worthwhile to run with log_checkpoints on and collect some statistics there next time you're running these tests. It's a good habit to get other testers into

Re: [PATCHES] Suppress compiler warnings on mingw

2008-04-16 Thread Andrew Dunstan
Applied, Thanks. wiki updated. cheers andrew ITAGAKI Takahiro wrote: Peter Eisentraut [EMAIL PROTECTED] wrote: Then try using %lu and no casts. That should get rid of the warnings the proper way. Ok, I rewrote it to use %lu for format strings. Jeremy Drake [EMAIL PROTECTED]

Re: [PATCHES] [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout

2008-04-16 Thread Alex Hunsaker
On Wed, Apr 16, 2008 at 4:54 PM, Alvaro Herrera [EMAIL PROTECTED] wrote: Joshua D. Drake escribió: That is an interesting idea. Something like: pg_restore -E SET STATEMENT_TIMEOUT=0; SET MAINTENANCE_WORK_MEM=1G ? We already have it -- it's called PGOPTIONS. Ok but is not the purpose

Re: [PATCHES] printTable API (was: Show INHERIT in \du)

2008-04-16 Thread Brendan Jurd
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, Apr 17, 2008 at 7:27 AM, Alvaro Herrera wrote: Brendan Jurd escribió: The second version of the patch is attached. Thanks. I looked the patch over and did some minor changes. Modified version attached. Cool, I had a look through

Re: [PATCHES] printTable API (was: Show INHERIT in \du)

2008-04-16 Thread Alvaro Herrera
Brendan Jurd escribió: On Thu, Apr 17, 2008 at 7:27 AM, Alvaro Herrera wrote: One thing I'm not entirely happy about is the fact that we need a pointer to the last footer/cell/header, so two pointers for each element kind. Well, the alternative is iterating through the array each

Re: [PATCHES] Proposed patch - psql wraps at window width

2008-04-16 Thread Bruce Momjian
Bryce Nesbitt wrote: I've attached a patch, against current 8.4 cvs, which optionally sets a maximum width for psql output: # \pset format aligned-wrapped # \pset border 2 # select * from distributors order by did; +--++-+---+ |

Re: [PATCHES] Proposed patch - psql wraps at window width

2008-04-16 Thread Bryce Nesbitt
Bruce Momjian wrote: I spent time reviewing your patch --- quite impressive. I have attached and updated version with mostly stylistic changes. In testing I found the regression tests were failing because of a divide by zero error (fixed), and a missing case where the column delimiter has to