Re: [PATCHES] Exposing keywords to clients

2008-05-03 Thread Dave Page
On Sat, May 3, 2008 at 12:24 AM, Alvaro Herrera [EMAIL PROTECTED] wrote: Dave Page wrote: Hi, The attached patch implements a new function, pg_get_keywords(), which returns a set of records describing the keywords recognised by the server. This allows clients such as pgAdmin to get

Re: [PATCHES] plpgsql CASE statement - last version

2008-05-03 Thread Pavel Stehule
Hello 2008/5/3 Tom Lane [EMAIL PROTECTED]: Pavel Stehule [EMAIL PROTECTED] writes: 2008/5/2 Heikki Linnakangas [EMAIL PROTECTED]: How about taking a completely different strategy, and implement the CASE-WHEN construct fully natively in plpgsql, instead of trying to convert it to a single SQL

Re: [PATCHES] [COMMITTERS] pgsql: Sigh ...

2008-05-03 Thread Peter Eisentraut
Andrew Dunstan wrote: This patch should fix things for both sets of changes. And it demonstrates pretty much what you need to do for config options for MSVC. Btw., it is quite easily possible to use the autom4te tracing facility to parse the configure.ac file, in case you are interested in

Re: [PATCHES] Exposing keywords to clients

2008-05-03 Thread Peter Eisentraut
Dave Page wrote: Perhaps use a separate string for machine parse (say R, T, C, U), and let the string be translatable. I considered that, but wasn't sure if folks would like the redundancy. It's trivial to do of course - any objections? Is there anything useful you would do with this

Re: [PATCHES] configure option for XLOG_BLCKSZ

2008-05-03 Thread Simon Riggs
On Fri, 2008-05-02 at 12:28 -0400, Greg Smith wrote: As PostgreSQL makes its way into higher throughput environments, it wouldn't surprise me to discover more of these situations where switching WAL segments every 16MB turns into a bottleneck. We already hit that issue and fixed it early

Re: [PATCHES] [COMMITTERS] pgsql: Sigh ...

2008-05-03 Thread Andrew Dunstan
Peter Eisentraut wrote: Andrew Dunstan wrote: This patch should fix things for both sets of changes. And it demonstrates pretty much what you need to do for config options for MSVC. Btw., it is quite easily possible to use the autom4te tracing facility to parse the configure.ac

Re: [PATCHES] create or replace language

2008-05-03 Thread Andreas 'ads' Scherbaum
On Sat, 29 Mar 2008 22:35:21 -0400 Tom Lane wrote: The key argument seems to be that it's quite unclear what the state following CREATE IF NOT EXISTS (CINE) should be, if the object does exist but not with the same properties specified in the CINE command. CREATE OR REPLACE resolves that by

Re: [PATCHES] Exposing keywords to clients

2008-05-03 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Dave Page wrote: Perhaps use a separate string for machine parse (say R, T, C, U), and let the string be translatable. I considered that, but wasn't sure if folks would like the redundancy. It's trivial to do of course - any objections? Is there

Re: [PATCHES] configure option for XLOG_BLCKSZ

2008-05-03 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: We already hit that issue and fixed it early in the 8.3 cycle. It was more of a problem than the checkpoint issue because it caused hard lock-outs while the file switches occurred. It didn't show up unless you looked at the very detailed transaction result

Re: [PATCHES] [COMMITTERS] pgsql: Sigh ...

2008-05-03 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Peter Eisentraut wrote: Btw., it is quite easily possible to use the autom4te tracing facility to parse the configure.ac file, in case you are interested in generating some of the Windows build code automatically. Yeah, maybe. Let's fix the issue

Re: [PATCHES] configure option for XLOG_BLCKSZ

2008-05-03 Thread Andreas 'ads' Scherbaum
On Sat, 03 May 2008 13:14:35 -0400 Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: Not seen any gains from varying the WAL file size since then... I think the use-case for varying the WAL segment size is unrelated to performance of the master server, but would instead be concerned

Re: [PATCHES] create or replace language

2008-05-03 Thread Tom Lane
Andreas 'ads' Scherbaum [EMAIL PROTECTED] writes: Attached is a first version for the CREATE OR REPLACE LANGUAGE patch. It's still missing some functionality (especially the update part is far away from being complete) and it's also missing documentation. It strikes me that if there are any

Re: [PATCHES] create or replace language

2008-05-03 Thread Andreas 'ads' Scherbaum
Hello, On Sat, 03 May 2008 13:34:05 -0400 Tom Lane wrote: So maybe the right thing is that CREATE OR REPLACE LANGUAGE can change inessential properties of an existing language, but not the core properties --- which might only be the handler function, though you could make a case for the

Re: [PATCHES] [COMMITTERS] pgsql: Sigh ...

2008-05-03 Thread Magnus Hagander
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: Peter Eisentraut wrote: Btw., it is quite easily possible to use the autom4te tracing facility to parse the configure.ac file, in case you are interested in generating some of the Windows build code automatically. Yeah, maybe. Let's

Re: [PATCHES] Exposing keywords to clients

2008-05-03 Thread Dave Page
On Sat, May 3, 2008 at 6:12 PM, Tom Lane [EMAIL PROTECTED] wrote: Peter Eisentraut [EMAIL PROTECTED] writes: Is there anything useful you would do with this information? Or would you just quote all listed words anyway? Currently, yes, we just quote all listed words. I think the practical

Re: [PATCHES] Exposing keywords to clients

2008-05-03 Thread Tom Lane
Dave Page [EMAIL PROTECTED] writes: Attached is an updated patch, giving the following output. The catdesc column can be translated. Documentation has got a couple of problems: + contains the keyword, the structfieldcatcode/ column contains a + category code of 'U' for unknown, 'C'

Re: [PATCHES] Exposing keywords to clients

2008-05-03 Thread Tom Lane
Dave Page [EMAIL PROTECTED] writes: Attached is an updated patch, giving the following output. Oh, one other thing: dropping externs into random modules unrelated to their source module is completely awful programming style, because there is nothing preventing incompatible declarations. Put

Re: [PATCHES] Exposing keywords to clients

2008-05-03 Thread Dave Page
On Sat, May 3, 2008 at 9:06 PM, Tom Lane [EMAIL PROTECTED] wrote: Dave Page [EMAIL PROTECTED] writes: Attached is an updated patch, giving the following output. Oh, one other thing: dropping externs into random modules unrelated to their source module is completely awful programming style,

Re: [PATCHES] [HACKERS] Multiline privileges in \z

2008-05-03 Thread Andrew Dunstan
Brendan Jurd wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, Apr 18, 2008 at 2:37 AM, Tom Lane wrote: The function names in the patch need schema-qualification in case pg_catalog is not first in the search path. Ah, yes. I should have seen that. Thanks Tom. New

Re: [PATCHES] [HACKERS] Multiline privileges in \z

2008-05-03 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Wouldn't this expression: pg_catalog.array_to_string(c.relacl, chr(10)) be better expressed as pg_catalog.array_to_string(c.relacl, E'\n') +1 ... it's minor, but knowing that ASCII LF is 10 is probably not wired into too many people's

Re: [PATCHES] Sorting writes during checkpoint

2008-05-03 Thread Tom Lane
ITAGAKI Takahiro [EMAIL PROTECTED] writes: Greg Smith [EMAIL PROTECTED] wrote: If shared_buffers(=NBuffers) is set to something big, this could give some memory churn. And I think it's a bad idea to allocate something this large at checkpoint time, because what happens if that fails?