Re: [PATCHES] [HACKERS] WITH RECURSIVE updated to CVS TIP

2008-07-07 Thread Yoshiyuki Asaba
Hi, From: Hans-Juergen Schoenig [EMAIL PROTECTED] Subject: Re: [PATCHES] [HACKERS] WITH RECURSIVE updated to CVS TIP Date: Sat, 5 Jul 2008 10:43:57 +0200 i did some quick testing with this wonderful patch. it seems there are some flaws in there still: test=# explain select count(*) test-#

Re: [PATCHES] GIN improvements

2008-07-07 Thread Alvaro Herrera
Teodor Sigaev wrote: Sync with current CVS HEAD and post in hackers- too because patches- close to the closing. http://www.sigaev.ru/misc/multicolumn_gin-0.3.gz I looked this over and it looks good in general. I was only wondering about for single-column indexes -- we're storing attribute

Re: [PATCHES] GIN improvements

2008-07-07 Thread Teodor Sigaev
I looked this over and it looks good in general. I was only wondering about for single-column indexes -- we're storing attribute numbers too, right? No, GinState-oneCol field signals to GinFormTuple and gin_index_getattr/gintuple_get_attrnum about actual storage. Single column index is binary

Re: [PATCHES] GIN improvements

2008-07-07 Thread Alvaro Herrera
Teodor Sigaev wrote: I looked this over and it looks good in general. I was only wondering about for single-column indexes -- we're storing attribute numbers too, right? No, GinState-oneCol field signals to GinFormTuple and gin_index_getattr/gintuple_get_attrnum about actual storage.