Re: [PATCHES] page macros cleanup (ver 04)

2008-07-09 Thread Heikki Linnakangas
Zdenek Kotala wrote: Pavan Deolasee napsal(a): On Fri, Jul 4, 2008 at 4:25 PM, Heikki Linnakangas [EMAIL PROTECTED] wrote: No, there's a itemsz = MAXALIGN(itemsz) call before the check against HashMaxItemSize. Ah, right. Still should we just not MAXALIGN_DOWN the Max size to reflect the

Re: [PATCHES] page macros cleanup (ver 04)

2008-07-09 Thread Zdenek Kotala
Heikki Linnakangas napsal(a): Zdenek Kotala wrote: Pavan Deolasee napsal(a): There's another academical discrepancy between these two hunks: snip I admit I don't understand what that bitmap is, it looks like we're assuming it can take up all the space between page header and the special

Re: [PATCHES] [HACKERS] Solaris ident authentication using unix domain sockets

2008-07-09 Thread Josh Berkus
Florian, I'd be *very* interested in how they come to that assessment. I'd have thought that the only alternative to getpeereid/getupeercred is password-based or certificate-based authenticated - which seem *less* secure because a) they also rely on the client having the correct uid or gid (to

Re: [HACKERS] [PATCHES] GIN improvements

2008-07-09 Thread Neil Conway
On Tue, 2008-07-08 at 14:51 -0400, Tom Lane wrote: I'd still like to take a look. I was tasked with reviewing this for the current commit fest, although so far I've just been working on grokking the rest of the GIN code. But if you'd like to review it instead, that's fine with me. -Neil --

Re: [PATCHES] [HACKERS] WITH RECURSIVE updated to CVS TIP

2008-07-09 Thread David Fetter
On Tue, Jul 08, 2008 at 09:28:34PM -0400, Alvaro Herrera wrote: David Fetter wrote: On Tue, Jul 08, 2008 at 06:01:05PM +0900, Tatsuo Ishii wrote: Here is the patches he made against CVS HEAD (as of today). The git repository should now match this :)

Re: [HACKERS] [PATCHES] GIN improvements

2008-07-09 Thread Josh Berkus
Neil, I was tasked with reviewing this for the current commit fest, although so far I've just been working on grokking the rest of the GIN code. But if you'd like to review it instead, that's fine with me. I have plenty of other stuff I could assign you if you're not needed on GIN. --