Re: [PATCHES] variadic function support

2008-07-13 Thread Tom Lane
"Pavel Stehule" <[EMAIL PROTECTED]> writes: > 2008/7/13 Jeff Davis <[EMAIL PROTECTED]>: >> Also, it doesn't seem to allow calls to a variadic function with zero >> arguments, e.g. "mleast()". I think this should be allowed. > It's not possible for all cases, because empty array have be typed > arr

Re: [PATCHES] page macros cleanup (ver 04)

2008-07-13 Thread Tom Lane
Zdenek Kotala <[EMAIL PROTECTED]> writes: > Good catch. if we have to bump catalog version then I have there small patch > which introduce following macro and remove PageHeaderData stucture from > HashMetaPageData: Seems like a bad idea --- PageGetContents is not guaranteed to deliver a maxaligne

Re: [PATCHES] page macros cleanup (ver 04)

2008-07-13 Thread Tom Lane
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > ... That macro is actually doing the > same thing as PageGetContents, so I switched to using that. As that > moves the data sligthly on those bitmap pages, I guess we'll need a > catversion bump. I'm amazed that Zdenek didn't scream bloody mur

Re: [HACKERS] [PATCHES] GIN improvements

2008-07-13 Thread Teodor Sigaev
Updated: http://www.sigaev.ru/misc/fast_insert_gin-0.9.gz need more review of fast_insert yet? It looked like a number of people commented on it already. I still havn't clearness of acceptability for suggested aminsertcleanup calling. -- Teodor Sigaev E