[PATCHES] msvc, build and install with cygwin in the PATH

2007-05-23 Thread Hannes Eder
With a small modification to src/tools/msvc/Install.pm (see attached patch) it's possible for me to build with msvc and install postgres on a Windows xp box and leave cygwin in the PATH. Since I use cygwin frequently it's usfull for me to have it in the PATH. This might not work on Win9x

Re: [PATCHES] [HACKERS] msvc, build and install with cygwin in the PATH

2007-05-30 Thread Hannes Eder
Andrew Dunstan schrieb: Hannes Eder wrote: -open($D, dir /b $subdirs $spec |) || croak Could not list $spec\n; +open($D, cmd /c dir /b $subdirs $spec |) || croak Could not list $spec\n; What the heck are we doing here anyway? We should be doing this a la Perl - calling out to dir

Re: [PATCHES] [HACKERS] msvc, build and install with cygwin in the PATH

2007-06-06 Thread Hannes Eder
Magnus Hagander wrote: Hannes Eder wrote: Is it worth doing this the Perl-way and using File::Find? If so, I can work an a patch for that. It's certainly cleaner that way, but I don't find it a major issue. But I'd rather see that fix than the other one. Here we go. See attached patch

[PATCHES] minor compiler warning in backend/utils/adt/tsrank.c

2007-09-20 Thread Hannes Eder
while rebuilding postgres with msvc 2005 I noticed some minor compiler warnings: .\src\backend\utils\adt\tsrank.c(24): warning C4305: 'initializing' : truncation from 'double' to 'float' .\src\backend\utils\adt\tsrank.c(24): warning C4305: 'initializing' : truncation from 'double' to 'float'

[PATCHES] msvc = VC7 understands __FUNCTION__

2007-09-28 Thread Hannes Eder
Hi, Starting from version VC7 msvc supports __FUNCTION__, so I think this could be enabled in pg_config.h.win32, see attached diff. -Hannes *** ../pgsql-cvshead/src/include/pg_config.h.win32 Mon Apr 16 20:39:19 2007 --- src/include/pg_config.h.win32 Fri Sep 28 22:32:50 2007

[PATCHES] minor compiler warning in libpg/fe-secure.c on win32 (msvc)

2007-10-02 Thread Hannes Eder
Hi, while rebuilding the entire project I ran across following warning: .\src\interfaces\libpq\fe-secure.c(593): warning C4101: 'fp' : unreferenced local variable see attached diff for a fix. -Hannes *** ../pgsql-cvshead/src/interfaces/libpq/fe-secure.c Tue Oct 2 11:43:05 2007 ---

Re: [PATCHES] parse_expr.c:typecast_expression:return immediate on NULL input

2007-11-23 Thread Hannes Eder
Tom Lane [EMAIL PROTECTED] writes: Hannes Eder [EMAIL PROTECTED] writes: in parse_expr.c:typecast_expression: return immediate on NULL input, i.e. do not lookup target type Oid as it is not required. I think the existing ordering is intentional, to detect and error out if the given

[PATCHES] parse_expr.c:typecast_expression:return immediate on NULL input

2007-11-23 Thread Hannes Eder
in parse_expr.c:typecast_expression: return immediate on NULL input, i.e. do not lookup target type Oid as it is not required. -Hannes Index: src/backend/parser/parse_expr.c === --- src/backend/parser/parse_expr.c (revision

Re: [PATCHES] [COMMITTERS] pgsql: Remove obsoleted README files.

2007-12-03 Thread Hannes Eder
Tom Lane wrote: Removed Files: - pgsql/contrib/spi: README.spi (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/spi/README.spi) Don't try to install a missing file ;) Install.pm needs an update, see attached .diff Best, -Hannes Index: