Re: [PATCHES] subtransactions -- storage manager

2004-04-30 Thread Simon Riggs
On Fri, 2004-04-30 at 01:02, Bruce Momjian wrote: Simon Riggs wrote: On Sun, 2004-04-25 at 19:06, Alvaro Herrera wrote: Hackers, This patch adds subtransaction support into the storage manager. Files created or dropped inside a subtransaction are correctly dealt

Re: [PATCHES] PITR Phase 1 - Full set of patches

2004-04-30 Thread Simon Riggs
02blahblah ^^^ Note that this should be -Ncr -- I don't create a lot of new files ... Thanks very much for the detailed help. I don't create a lot of new files either... Best Regards, Simon Riggs ---(end of broadcast)--- TIP 6: Have you

[PATCHES] PITR Phase 1 - Full set of patches

2004-04-29 Thread Simon Riggs
possible annoyances here. I am on hand to help and to learn by my mistakes. Report bugs to me at [EMAIL PROTECTED] and/or to the [HACKERS] list [EMAIL PROTECTED] Thanks, Best Regards Simon Riggs 2nd Quadrant http://www.2ndquadrant.com pgarch.tar Description: Unix tar archive *** guc.c.orig 2004

Re: [PATCHES] subtransactions -- storage manager

2004-04-29 Thread Simon Riggs
, Simon Riggs ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings

[PATCHES] Fix for erroneous warning on Shutdown

2004-06-11 Thread Simon Riggs
are occurring too frequently (%d seconds apart) HINT: Consider increasing the configuration parameter checkpoint_segments. Clearly, this should only occur when specific checkpoint requests have been made, shutdown checkpoints should not be included in the warning. Best regards, Simon Riggs Index: bgwriter.c

[PATCHES] PITR Archival

2004-06-15 Thread Simon Riggs
this done smoothly, I reckon I can have some PITR recovery control done by beta freeze. Best regards, Simon Riggs ? Makefile.global ? pitr_arch_v3.01.patch ? pitr_v3.1.patch ? backend/postgres ? backend/catalog/postgres.bki ? backend/catalog/postgres.description ? backend/postmaster/pgarch.c ? backend

Re: [PATCHES] Fix for erroneous warning on Shutdown

2004-06-15 Thread Simon Riggs
On Fri, 2004-06-11 at 19:25, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: Minor patch to correct erroneous warning in cvs tip, believed to be a very minor regression. This patch is wrong; it effectively disables the warning altogether. When a shutdown was requested within

Re: [PATCHES] PITR Archival

2004-06-15 Thread Simon Riggs
On Tue, 2004-06-15 at 16:34, Simon Riggs wrote: I enclose a working set of context diff patches and new files to make PITR archiving work, as of cvstip (NOW). You'll see the new options in the postgresql.conf...though you may wish to use archive_debug = true as well, when testing

Re: [PATCHES] Fix for erroneous warning on Shutdown

2004-06-15 Thread Simon Riggs
On Tue, 2004-06-15 at 19:33, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: As of now, (i.e. even including the new bgwriter shutdown) if you: 1. start postmaster 2. do some work that writes xlog 3. shutdown within some few seconds of startup you get a WARNING suggesting you

Re: [PATCHES] Fix for erroneous warning on Shutdown

2004-06-15 Thread Simon Riggs
On Tue, 2004-06-15 at 21:04, Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: Just to confirm that Simon is not suffering this uniquely, I saw this the other day on Windows, I believe - meant to report it but it got away from me. Oh, I bet I know what's going on --- are you

Re: [PATCHES] Nested transactions

2004-06-16 Thread Simon Riggs
, Simon Riggs ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]

Re: [PATCHES] Nested transactions

2004-06-17 Thread Simon Riggs
COMMIT statements 1,2,3,5 are committed Best Regards, Simon Riggs ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

Re: [PATCHES] Tablespaces

2004-06-20 Thread Simon Riggs
, but then... Best regards, Simon Riggs ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]

Re: [PATCHES] nested xacts and phantom Xids

2004-06-24 Thread Simon Riggs
done to Alvaro for being able to make the ideas reality. Best regards, Simon Riggs ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send unregister YourEmailAddressHere to [EMAIL PROTECTED])

Re: [PATCHES] PITR Archival

2004-06-25 Thread Simon Riggs
On Tue, 2004-06-15 at 16:34, Simon Riggs wrote: I enclose a working set of context diff patches and new files to make PITR archiving work, as of cvstip (NOW). As of now, this patch is invalidated by recent changes. Don't try to run it, it doesn't even start. There's good news coming later

[PATCHES] tz error prevents postmaster.c compiling...

2004-06-25 Thread Simon Riggs
2004 ...is this a case of? #ifdef BRIT gcc -throw-wobbly #endif Comments? Regards, Simon Riggs ---(end of broadcast)--- TIP 8: explain analyze is your friend

Re: [PATCHES] PITR Archive Recovery

2004-06-29 Thread Simon Riggs
On Mon, 2004-06-28 at 21:58, Simon Riggs wrote: PITR Archive Recovery, 28 June 2004 What's in this patch? - All of what was in previous PITR Archival patch, including reworking of all the archiver startup/shutdown code to match that of pgstat - New code to perform Archive Recovery mode

Re: [PATCHES] PITR Archive Recovery

2004-06-29 Thread Simon Riggs
On Tue, 2004-06-29 at 20:59, Simon Riggs wrote: On Mon, 2004-06-28 at 21:58, Simon Riggs wrote: PITR Archive Recovery, 28 June 2004 What's in this patch? This my LAST, PLANNED patch before Freeze. Any questions? This is a patch-on-patch, rather than a full patch. To use this, apply

Re: [PATCHES] PITR Archive Recovery

2004-06-30 Thread Simon Riggs
. Taking a full physical backup will normally need to exclude the pg_xlog directory, or at least the current xlog. Since it is being written to very regularly it is almost impossible to take a clean copy using standard utilities - though filesystem level utilities work fine. Best regards, Simon Riggs

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-06-30 Thread Simon Riggs
. Best Regards, Simon Riggs ---(end of broadcast)--- TIP 8: explain analyze is your friend

Re: [PATCHES] PITR Archive Recovery plus WIP PITR

2004-07-09 Thread Simon Riggs
archive on his tape. If he wants to archive it on disk, let him do it this way: archive_program = 'cp %s /mnt/pgarch/' archive_program = 'cp %s %s' would be the way to specify that... Thank you very much for feedback and your other contributions, Best regards, Simon Riggs

Re: [PATCHES] PITR Archive Recovery plus WIP PITR

2004-07-13 Thread Simon Riggs
Following a suggestion and patch from Klaus Naumann, the recovery.conf file can now accept comments No patch supplied at present (anoncvs is down), but here is the annotated recovery.conf.sample Best Regards, Simon Riggs # --- # PostgreSQL recovery config file

Re: [PATCHES] PITR Archive Recovery plus WIP PITR

2004-07-13 Thread Simon Riggs
On Tue, 2004-07-13 at 23:58, Bruce Momjian wrote: Simon Riggs wrote: New release of patch, at v5_1 ... for serious testing what's in - Point in Time Recovery now worksplease check carefully - additional options in recovery.conf (including code contributed to PITR from Klaus Naumann

Re: [PATCHES] PITR Archive Recovery plus WIP PITR

2004-07-14 Thread Simon Riggs
will break all those scripts. I agree, but I'm going to have a rest day while people test what is already there in case there are further code changeswhich nods towards both of your concerns. BTW, one test last night broke because of the lack of timelines... Best Regards, Simon Riggs

Re: [PATCHES] PITR Archive Recovery plus WIP PITR

2004-07-14 Thread Simon Riggs
, Simon Riggs ---(end of broadcast)--- TIP 8: explain analyze is your friend

Re: [PATCHES] [subxacts] Savepoint syntax

2004-07-14 Thread Simon Riggs
On Wed, 2004-07-14 at 20:03, Alvaro Herrera wrote: So I have dropped the idea of the propietary syntax. This patch implements proper savepoint syntax. Includes regression tests but no documentation is provided yet. Excellent. Thank you very much for your efforts. Many thanks, Simon Riggs

Re: [PATCHES] [HACKERS] Point in Time Recovery

2004-07-18 Thread Simon Riggs
, Simon Riggs ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send unregister YourEmailAddressHere to [EMAIL PROTECTED])

Re: [PATCHES] [HACKERS] Point in Time Recovery

2004-07-19 Thread Simon Riggs
On Mon, 2004-07-19 at 04:13, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: When archiver starts the FIRST thing it does is run a test to confirm that the command string works, so setting archive_command to '' would simply generate an error. No, it would do no such thing; the test

Re: [PATCHES] [HACKERS] Point in Time Recovery

2004-07-19 Thread Simon Riggs
On Mon, 2004-07-19 at 04:03, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: Latest version, pitr_v5_2.patch... Reviewed and committed with some adjustments. Wow! Thanks very much - you work fast. I'll be re-testing later today. I see the following significant loose ends

Re: [PATCHES] [HACKERS] Point in Time Recovery

2004-07-19 Thread Simon Riggs
if this was an issue, the solution would be to speed up recovery since that would benefit us more than putting recovery-squared code in. Just start over... Best Regards, Simon Riggs ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

Re: [PATCHES] [HACKERS] Point in Time Recovery

2004-07-20 Thread Simon Riggs
now or incorrectly specified (by somebody else, of course). (At least using the default log mode). Best Regards, Simon Riggs ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs

Re: [PATCHES] [HACKERS] Point in Time Recovery

2004-07-21 Thread Simon Riggs
opportunity to discuss and agree what constitutes real issues and then correct them. This may not be on that list later. Best Regards, Simon Riggs ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http

[PATCHES] ARC Memory Usage analysis

2004-10-22 Thread Simon Riggs
tuning, not just lab work. This will then allow reporting against the additional lists, so that cache hit ratios can be seen with various other prototype shared_buffer settings. Any thoughts? -- Best Regards, Simon Riggs Index: freelist.c

Re: [PATCHES] [HACKERS] ARC Memory Usage analysis

2004-10-22 Thread Simon Riggs
On Fri, 2004-10-22 at 20:35, Jan Wieck wrote: On 10/22/2004 2:50 PM, Simon Riggs wrote: My proposal is to alter the code to allow an array of memory linked lists. The actual list would be [0] - other additional lists would be created dynamically as required i.e. not using IFDEFs

Re: [PATCHES] [HACKERS] ARC Memory Usage analysis

2004-10-22 Thread Simon Riggs
assume that the OS cache is ours to play with - what will we do with it? We need to use it for some purposes, yet would like to ignore it for others. -- Best Regards, Simon Riggs ---(end of broadcast)--- TIP 2: you can get off all lists at once

Re: [PATCHES] [HACKERS] ARC Memory Usage analysis

2004-10-26 Thread Simon Riggs
effective_cache_size means and then set accordingly.all of that in 8.0 -- Best Regards, Simon Riggs ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]

Re: [PATCHES] [HACKERS] ARC Memory Usage analysis

2004-10-26 Thread Simon Riggs
On Tue, 2004-10-26 at 09:49, Simon Riggs wrote: On Mon, 2004-10-25 at 16:34, Jan Wieck wrote: The problem is, with a too small directory ARC cannot guesstimate what might be in the kernel buffers. Nor can it guesstimate what recently was in the kernel buffers and got pushed out from

[PATCHES] REINDEX doc patch

2004-11-04 Thread Simon Riggs
Minor re-wording following recent locking changes. -- Best Regards, Simon Riggs === RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/reindex.sgml,v retrieving revision 1.24 diff -d -c -r1.24 reindex.sgml *** reindex.sgml 24 Oct

[PATCHES] effective_cache_size patch

2004-11-04 Thread Simon Riggs
Regards, Simon Riggs Index: src/sgml/runtime.sgml === RCS file: /projects/cvsroot/pgsql/doc/src/sgml/runtime.sgml,v retrieving revision 1.289 diff -d -c -r1.289 runtime.sgml *** src/sgml/runtime.sgml 17 Oct 2004 22:01:49 - 1.289

Re: [PATCHES] effective_cache_size patch

2004-11-04 Thread Simon Riggs
On Thu, 2004-11-04 at 16:37, Simon Riggs wrote: Also, another minor patch which prevents effective_cache_size and random_page_cost from being set incorrectly: plancost.patch - previously it was possible to set effective_cache_size to 0, which would then be ignored and treated as 1 at run-time

Re: [PATCHES] effective_cache_size patch

2004-11-04 Thread Simon Riggs
On Thu, 2004-11-04 at 19:13, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: I enclose a doc patch for the effective_cache_size parameter in runtime.sgml: efcdoc.patch Applied after translation into English ;-) Yes, the most significant bit often seems to get flipped in en_GB

Re: [PATCHES] contrib/xml2: add function xml_encode_special_chars

2004-11-07 Thread Simon Riggs
On Sat, 2004-11-06 at 23:42, Markus Bertheau wrote: , 06.11.2004, 23:13, Simon Riggs : On Sat, 2004-11-06 at 00:36, Markus Bertheau wrote: , 06.11.2004, 01:24, Peter Eisentraut : Markus Bertheau wrote: attached is a patch that adds the function xml_encode_special_chars

Re: [PATCHES] contrib/xml2: add function xml_encode_special_chars

2004-11-07 Thread Simon Riggs
On Sun, 2004-11-07 at 12:56, Markus Bertheau wrote: , 07.11.2004, 09:33, Simon Riggs : On Sat, 2004-11-06 at 23:42, Markus Bertheau wrote: , 06.11.2004, 23:13, Simon Riggs : On Sat, 2004-11-06 at 00:36, Markus Bertheau wrote: , 06.11.2004, 01:24, Peter Eisentraut

[PATCHES] Enhanced PITR doc patch

2004-11-07 Thread Simon Riggs
with XA (or current lack of it), tuning etc... all of which we can expect to improve over time with help from the community. -- Best Regards, Simon Riggs Index: backup.sgml === RCS file: /projects/cvsroot/pgsql/doc/src/sgml/backup.sgml,v

[PATCHES] diff -c please

2004-11-14 Thread Simon Riggs
a few people on the lists, but many people are watching. Sticking to diff -c format helps those people to review and comment back. I've not always done this myself, so forgive me for casting the first stone. This isn't aimed at anyone, just a general comment. -- Best Regards, Simon Riggs

Re: [PATCHES] PITR docs enhancements

2004-11-14 Thread Simon Riggs
) to me, it seems you are saying that only tapes have the requirement to restore with the same name. That comment applies to all methods. If there is a particular command/mechanism that gives that problem, we should name and shame it. Tape is good, tape commands may not be. -- Best Regards, Simon

Re: [PATCHES] diff -c please

2004-11-15 Thread Simon Riggs
On Sun, 2004-11-14 at 11:55, Neil Conway wrote: Simon Riggs wrote: I note at least 3 people have submitted patches in other formats in the last week. I'm one of the guilty parties (as is Gavin, I'd imagine). I didn't read your earlier reasons, I apologise. My own patches had better

[PATCHES] Archiver restart timer

2004-11-21 Thread Simon Riggs
. That xlog file backlog could take some time to clear. This then leaves a larger than normal window of data loss for a possibly long period. It's a minor change only, with no other effect on function. -- Best Regards, Simon Riggs

[PATCHES] SQL Conformance introductory section

2004-11-21 Thread Simon Riggs
I've re-written the start of the SQL Conformance section to update things for the SQL2003 standard. This is intended to be applied alongside Troels Arvin's patch, though can be applied without it also. I've not reviewed Troels' patch in detail yet. -- Best Regards, Simon Riggs Index

Re: [PATCHES] Archiver restart timer

2004-11-21 Thread Simon Riggs
On Sun, 2004-11-21 at 23:07, Simon Riggs wrote: I enclose a short patch to reduce the PGARCH_RESTART_INTERVAL from 60 seconds to 10 seconds. The original number was plucked from thin air some months ago, and I'd like to review that now based upon further thought, observation and experience

[PATCHES] SQL:2003 keyword additions

2004-11-23 Thread Simon Riggs
as per SQL:2003 Annex E pp.1173-1175 Incompatibilities with SQL:1999, specifically point 17, pp.1174-1175: A number of additional reserved words have been added to the language. Enjoy. -- Best Regards, Simon Riggs Index: keywords.c

Re: [PATCHES] SQL:2003 keyword additions

2004-11-23 Thread Simon Riggs
On Tue, 2004-11-23 at 23:22, Tom Lane wrote: For future reference, the patch as proposed is broken anyway because it doesn't add the keywords to the appropriate list in gram.y. OK, thanks. -- Best Regards, Simon Riggs ---(end of broadcast

Re: [PATCHES] SQL:2003 keyword additions

2004-11-23 Thread Simon Riggs
On Tue, 2004-11-23 at 23:08, Peter Eisentraut wrote: Simon Riggs wrote: as per SQL:2003 Annex E pp.1173-1175 Incompatibilities with SQL:1999, specifically point 17, pp.1174-1175: A number of additional reserved words have been added to the language. I think you are confusing

Re: [PATCHES] SQL Conformance introductory section

2004-11-23 Thread Simon Riggs
On Tue, 2004-11-23 at 23:15, Peter Eisentraut wrote: Simon Riggs wrote: I've re-written the start of the SQL Conformance section to update things for the SQL2003 standard. This has got to be a mistake: Overall, PostgreSQL Global Development Group (acronymPGDG/acronym) supports

Re: [PATCHES] SQL:2003 keyword additions

2004-11-24 Thread Simon Riggs
On Wed, 2004-11-24 at 10:02, Peter Eisentraut wrote: Simon Riggs wrote: If you are saying we should not support the SQL standard with regard to the new reserved words added in SQL:2003, I would understand, but not agree. Conformance to the SQL standard is defined such that statements

Re: [DOCS] [PATCHES] SQL conformance related patch

2004-11-28 Thread Simon Riggs
On Fri, 2004-11-26 at 22:34, Peter Eisentraut wrote: Simon Riggs wrote: The sections Supported Features and Unsupported Features cover both Mandatory (Core) and Optional features in the same section. It would be better to separate these, just as the SQL standard itself does in Annex F

Re: [PATCHES] [HACKERS] Bgwriter behavior

2004-12-30 Thread Simon Riggs
, if this is approved. -- Best Regards, Simon Riggs Index: src/backend/storage/buffer/bufmgr.c === RCS file: /projects/cvsroot/pgsql/src/backend/storage/buffer/bufmgr.c,v retrieving revision 1.182 diff -d -c -r1.182 bufmgr.c *** src/backend

Re: [PATCHES] [HACKERS] Bgwriter behavior

2004-12-31 Thread Simon Riggs
On Fri, 2004-12-31 at 01:14, Bruce Momjian wrote: Simon Riggs wrote: On Mon, 2004-12-27 at 22:21, Bruce Momjian wrote: Should we consider at least adjusting the meaning of bgwriter_percent? Yes. As things stand, this is the only change that seems safe. Here's a very short patch

Re: [PATCHES] [HACKERS] Bgwriter behavior

2005-01-01 Thread Simon Riggs
on it. --- Simon Riggs wrote: On Fri, 2004-12-31 at 01:14, Bruce Momjian wrote: Simon Riggs wrote: On Mon, 2004-12-27 at 22:21, Bruce Momjian wrote: Should we consider at least adjusting the meaning of bgwriter_percent? Yes. As things

Re: [PATCHES] [HACKERS] Bgwriter behavior

2005-01-01 Thread Simon Riggs
On Sat, 2005-01-01 at 17:01, Bruce Momjian wrote: Simon Riggs wrote: Well, I think we're saying: its not in 8.0 now, and we take our time to consider patches for 8.1 and accept the situation that the parameter names/meaning will change in next release. I have no problem doing

Re: [PATCHES] [HACKERS] Bgwriter behavior

2005-01-01 Thread Simon Riggs
On Sat, 2005-01-01 at 17:47, Simon Riggs wrote: On Sat, 2005-01-01 at 17:01, Bruce Momjian wrote: Simon Riggs wrote: Well, I think we're saying: its not in 8.0 now, and we take our time to consider patches for 8.1 and accept the situation that the parameter names/meaning

Re: [PATCHES] [HACKERS] Bgwriter behavior

2005-01-03 Thread Simon Riggs
on the patch. Is it: * too late for 8.0 * not the right improvement * to be applied with doc/default additions Comments? --- Simon Riggs wrote: On Sat, 2005-01-01 at 17:47, Simon Riggs wrote

Re: [PATCHES] [HACKERS] Bgwriter behavior

2005-01-03 Thread Simon Riggs
On Mon, 2005-01-03 at 23:03, Bruce Momjian wrote: Simon Riggs wrote: On Mon, 2005-01-03 at 20:09, Bruce Momjian wrote: OK, we have a submitted patch that attempts to improve bgwriter by making bgwriter_percent control what percentage of the buffer is scanned. The patch still

Re: [PATCHES] [HACKERS] Bgwriter behavior

2005-01-04 Thread Simon Riggs
On Mon, 2005-01-03 at 19:14 -0500, Bruce Momjian wrote: Simon Riggs wrote: Here's my bgwriter instrumentation patch, which gives info that could allow the bgwriter settings to be tuned. Uh, what does this do exactly? Add additional logging output? Produces output like

Re: [PATCHES] Proof-of-concept ARC removal patches

2005-02-03 Thread Simon Riggs
in the postgresql.conf file at all...since it would be easy to misuse. A default setting of something like T1 as % of total (just roughly) = 50% when shared_buffers = 1000 = 25% when shared_buffers = 5000 = 10% when shared_buffers = 2 with smoothing... Best Regards, Simon Riggs

Re: [PATCHES] Patch for disaster recovery

2005-02-21 Thread Simon Riggs
more people would think about about using it ahead of time, just like everybody does with commercial databases. Best Regards, Simon Riggs ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your

Re: [PATCHES] A way to let Vacuum warn if FSM settings are low.

2005-02-24 Thread Simon Riggs
not be obvious that that is the case. Best Regards, Simon Riggs ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] A way to let Vacuum warn if FSM settings are low.

2005-02-27 Thread Simon Riggs
, it looks like a polish of final wording and commit. Best Regards, Simon Riggs ---(end of broadcast)--- TIP 8: explain analyze is your friend

Re: [PATCHES] [HACKERS] WAL: O_DIRECT and multipage-writer (+

2005-03-11 Thread Simon Riggs
- is there still scope to include this for smaller configs? If not, thanks for taking the time to write the patch and investigate whether changes in this area would help. Not every performance patch improves things, but that doesn't mean we shouldn't try... Best Regards, Simon Riggs

Re: [PATCHES] [pgsql-hackers-win32] explain analyze timings

2005-03-20 Thread Simon Riggs
). Is this just a Win32 hack? I've been looking for a sub-millisecond counter on other OS for a while now...anybody know of any port specific counters elsewhere? Thanks, Best Regards, Simon Riggs ---(end of broadcast)--- TIP 5: Have you checked our

[PATCHES] Exec statement logging

2005-04-11 Thread Simon Riggs
Corporation and the patch has now been donated to the PostgreSQL community under the standard PostgreSQL/BSD licence. Approval for release of this code has been given in writing to me by the Director, Open Runtime Products, Unisys on April 8, 2005. Best Regards, Simon Riggs Index: postgres.c

[PATCHES] OS Locale UTF-8

2005-04-11 Thread Simon Riggs
to specify an encoding, just like it used to. Whatever we call UTF*8, there will always be somebody who says different. Best regards, Simon Riggs Index: initdb.c === RCS file: /projects/cvsroot/pgsql/src/bin/initdb/initdb.c,v retrieving

[PATCHES] COPY Fillfactor patch

2005-04-12 Thread Simon Riggs
- there are some other items I need to work on for 8.1 ahead of this now. Best Regards, Simon Riggs diff -c -r postgresql-8.0.1/src/backend/access/heap/heapam.c postgresql-8.0.1-wip/src/backend/access/heap/heapam.c *** postgresql-8.0.1/src/backend/access/heap/heapam.c 2005-02-03 10:38:06.0 -0800

Re: [PATCHES] COPY Fillfactor patch

2005-04-12 Thread Simon Riggs
On Wed, 2005-04-13 at 00:00 +1000, Neil Conway wrote: Simon Riggs wrote: During recent tuning of the TPC-C workload, I produced the following patch to force COPY to leave some space in each data block when it loads data into heap relations. I can't get too excited about incorporating

Re: [PATCHES] COPY Fillfactor patch

2005-04-12 Thread Simon Riggs
On Tue, 2005-04-12 at 09:56 -0400, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: During recent tuning of the TPC-C workload, I produced the following patch to force COPY to leave some space in each data block when it loads data into heap relations. Put the info into the Relation

[PATCHES] WIP XLog Switch

2005-04-19 Thread Simon Riggs
in here about standby databases (yet) Any comments appreciated before I spend too much time on this. Best Regards, Simon Riggs Index: src/backend/access/transam/xlog.c === RCS file: /projects/cvsroot/pgsql/src/backend/access/transam

Re: [PATCHES] COPY Fillfactor patch

2005-04-20 Thread Simon Riggs
wouldn't help much until after the first vacuum of a table. Best Regards, Simon Riggs ---(end of broadcast)--- TIP 8: explain analyze is your friend

Re: [PATCHES] COPY Fillfactor patch

2005-04-20 Thread Simon Riggs
it, it needs to be varied according to what is happening to a particular relation. Otherwise you'd gain benefit in one area and lose it in another. Best Regards, Simon Riggs ---(end of broadcast)--- TIP 7: don't forget to increase your free space

Re: [PATCHES] COPY Fillfactor patch

2005-04-20 Thread Simon Riggs
On Wed, 2005-04-20 at 09:42 -0400, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: On Wed, 2005-04-20 at 09:03 -0400, Bruce Momjian wrote: My guess is that the FILLFACTOR will actually be a GUC variable rather than a clause to CREATE INDEX or REINDEX or CLUSTER. I hope

[PATCHES] Minor Comment updates

2005-04-21 Thread Simon Riggs
Some minor updates to comments. ? nodeResult.patch Index: nodeResult.c === RCS file: /projects/cvsroot/pgsql/src/backend/executor/nodeResult.c,v retrieving revision 1.29 diff -d -c -r1.29 nodeResult.c *** nodeResult.c 31 Dec 2004

Re: [PATCHES] Minor Comment updates

2005-04-22 Thread Simon Riggs
On Thu, 2005-04-21 at 23:52 -0400, Alvaro Herrera wrote: On Thu, Apr 21, 2005 at 11:15:48PM +0100, Simon Riggs wrote: This one is wrong ... it really means EXPLAIN EXECUTE. OK, yes that one is wrong - thought it was old syntax. Best Regards, Simon Riggs

Re: [PATCHES] Minor Comment updates

2005-04-22 Thread Simon Riggs
On Thu, 2005-04-21 at 23:52 -0400, Alvaro Herrera wrote: On Thu, Apr 21, 2005 at 11:15:48PM +0100, Simon Riggs wrote: This one is wrong ... it really means EXPLAIN EXECUTE. An updated patch, with changes to nodeAppend.c and nodeResult.c (only) These are the only two files in /executor

Re: [PATCHES] Cleaning up unreferenced table files

2005-05-04 Thread Simon Riggs
, but the admin can remove them without restarting the server. Same code, just a Function instead... Best Regards, Simon Riggs reference from fd.c: (this is not a patch) /* * Remove temporary files left over from a prior postmaster session * * This should be called during postmaster startup

Re: [PATCHES] Exec statement logging

2005-05-12 Thread Simon Riggs
for this. Think of it as due credit and politeness, rather than a requirement. Best Regards, Simon Riggs ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] Exec statement logging

2005-05-15 Thread Simon Riggs
output almost useless for query tuning, so please reconsider that. Perhaps you could include both the portal name and the SQL statement? Best Regards, Simon Riggs ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings

Re: [PATCHES] Exec statement logging

2005-05-15 Thread Simon Riggs
On Sun, 2005-05-15 at 13:29 -0400, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: On Sat, 2005-05-14 at 16:55 -0400, Bruce Momjian wrote: One thing you did was to log debug_query_string, but I don't see how that could be the right value. I used the debug_query_string because even

Re: [PATCHES] WIP XLog Switch

2005-05-21 Thread Simon Riggs
On Fri, 2005-05-20 at 23:16 -0400, Bruce Momjian wrote: Any farther on this? No, but it will be in by deadline. I need to make first base with partitioning before I can do this. Hence my (otherwise rude) ignoring of your sterling work on the exec logging patch. Best Regards, Simon Riggs

[PATCHES] WAL bypass for CTAS

2005-06-03 Thread Simon Riggs
to be integrated with Alon's work. Patch is diff -c format, compiles and make checks on cvstip as of now. No performance tests *on this patch*, though the general principle has already been proven via a similar prototype patch not published on list. Best Regards, Simon Riggs Index: src/backend/access/heap

Re: [PATCHES] WAL bypass for CTAS

2005-06-05 Thread Simon Riggs
fragile -- what happens if someone connects after the COPY has started? Considering that many COPY operations can take many minutes or hours, I don't think it is wise to make assumptions based on the initial state of the system. Agreed. Best Regards, Simon Riggs ---(end

Re: [PATCHES] indxpath.c refactoring

2005-06-14 Thread Simon Riggs
On Fri, 2005-06-10 at 18:33 -0400, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: This simple refactoring patch moves all of the code associated with Partial Index planning into a single file. Applied with some revisions - * I put the new predtest.c file into optimizer/util

Re: [PATCHES] WAL bypass for CTAS

2005-06-20 Thread Simon Riggs
On Mon, 2005-06-20 at 14:50 -0400, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: I enclose a complete patch for avoiding WAL usage for CREATE TABLE AS SELECT, when not in archive mode (PITR). The main use case for this is large BI environments that create summary tables or prejoined

Re: [PATCHES] WAL bypass for CTAS

2005-06-20 Thread Simon Riggs
On Mon, 2005-06-20 at 17:09 -0400, Alvaro Herrera wrote: On Mon, Jun 20, 2005 at 09:55:12PM +0100, Simon Riggs wrote: I put those changes in mainly for COPY. If you don't make any request at all to FSM then a relation never gets to the MRU relation FSM list. I agree

Re: [PATCHES] Constraint Exclusion (Partitioning) - Initial Review

2005-06-30 Thread Simon Riggs
On Mon, 2005-06-27 at 01:41 +0100, Simon Riggs wrote: I enclose a fully working implementation of Constraint Exclusion, a very basic form of Partitioning. Initial review is requested, to allow us all to assess what further work is required on this prior to Beta freeze. Patch against current

Re: [PATCHES] Constraint Exclusion (Partitioning) - Initial Review

2005-07-03 Thread Simon Riggs
I did not explain myself well enough. :-) Best Regards, Simon Riggs ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq

Re: [PATCHES] Constraint Exclusion (Partitioning) - Initial Review

2005-07-11 Thread Simon Riggs
, Simon Riggs ---(end of broadcast)--- TIP 6: explain analyze is your friend

[PATCHES] Final cleanup of SQL:1999 references

2005-07-13 Thread Simon Riggs
This doc patch replaces all inappropriate references to SQL:1999 when it is used as if it were the latest (and/or still valid) SQL standard. SQL:2003 is used in its place. Best Regards, Simon Riggs Index: array.sgml === RCS file

Re: [PATCHES] Final cleanup of SQL:1999 references

2005-07-14 Thread Simon Riggs
. Peter's suggestion of just saying the SQL standard seems motivated by reducing the amount of rework for translators. I would support that, but ask that Peter make those changes and reapply. Best Regards, Simon Riggs ---(end of broadcast)--- TIP 9

Re: [PATCHES] Constraint Exclusion (Partitioning) - Initial Review

2005-07-18 Thread Simon Riggs
On Sat, 2005-07-02 at 18:29 -0400, Alvaro Herrera wrote: On Sat, Jul 02, 2005 at 03:56:48PM -0400, Bruce Momjian wrote: Simon Riggs wrote: I enclose a fully working implementation of Constraint Exclusion, a very basic form of Partitioning. Initial review is requested, to allow us

Re: [PATCHES] Constraint Exclusion (Partitioning) - Initial Review

2005-07-18 Thread Simon Riggs
On Mon, 2005-06-27 at 01:41 +0100, Simon Riggs wrote: I enclose a fully working implementation of Constraint Exclusion, a very basic form of Partitioning. Initial review is requested, to allow us all to assess what further work is required on this prior to Beta freeze. Patch against current

[PATCHES] Writing Commit Status hint bits (was Re: [HACKERS] Constant WAL replay)

2005-07-19 Thread Simon Riggs
Regards, Simon Riggs Index: src/backend/storage/buffer/bufmgr.c === RCS file: /projects/cvsroot/pgsql/src/backend/storage/buffer/bufmgr.c,v retrieving revision 1.189 diff -c -c -r1.189 bufmgr.c *** src/backend/storage/buffer/bufmgr.c 19

  1   2   3   4   5   6   7   >