Re: [HACKERS] [PATCHES] v7.4.1 text_position() patch

2004-01-31 Thread Tatsuo Ishii
Tatsuo Ishii wrote: It's surprising that nobody noticed the bug until now. It seems it has been there since 7.3 days. I would like to make a back patch for 7.3-stable if nobody objects. It's my bug :( -- sorry about that. Here's a 7.3 patch per Tom's nearby advice. I'll apply if you'd

Re: [PATCHES] client side syntax error position (v3)

2004-03-15 Thread Tatsuo Ishii
that it is working, but still need testing for many other encodings. Also, currently for UTF-8 and MULE_INTERNAL it returns always 1, which is not correct of course. I will look into this within a week..(i have a dealine for a magazine article and have no time to do next 3 days) -- Tatsuo Ishii I also looked

Re: [PATCHES] ALTER TABLE ... SET TABLESPACE

2004-06-20 Thread Tatsuo Ishii
be even better to assign different tablespaces for each index. -- Tatsuo Ishii ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] ALTER TABLE ... SET TABLESPACE

2004-06-20 Thread Tatsuo Ishii
. It would be even better to assign different tablespaces for each index. Hm. It seems there's a problem with tablespaces. What I did was: pgbench -i test alter table accounts set tablespace mydb2; \d accounts backend crashes by signal 11... -- Tatsuo Ishii ---(end

Re: [PATCHES] [HACKERS] UNICODE characters above 0x10000

2004-08-07 Thread Tatsuo Ishii
0x0010, so 24-bit should be enough... -- Tatsuo Ishii ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send unregister YourEmailAddressHere to [EMAIL PROTECTED])

Re: [PATCHES] [HACKERS] UNICODE characters above 0x10000

2004-08-07 Thread Tatsuo Ishii
some supplementary character (?) scheme for values above 0x as of JDK 1.5. Java doesn't handle UCS above 0x? I didn't know that. As long as you put in/out JDBC, it shouldn't be a problem. However if other APIs put in such a data, you will get into trouble... -- Tatsuo Ishii

Re: [PATCHES] bugfix: character-code conversion of MIC - EUC_JP.

2005-06-10 Thread Tatsuo Ishii
(This is not surprising since very few people use Mule Internal Code). So I commit the fix to current only. Please let me know if back patch is neccessary. -- Tatsuo Ishii ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate

Re: [PATCHES] bugfix: character-code conversion of MIC - EUC_JP.

2005-06-10 Thread Tatsuo Ishii
Tatsuo Ishii [EMAIL PROTECTED] writes: In mic_to_euc_jp(), the call of mic2sjis() is a mistake. It is necessary to call mic2euc_jp() here. Thanks. The bug was there since 7.3. Apparently nobody uses MIC-EUC_JP conversion (This is not surprising since very few people use Mule

Re: [PATCHES] [HACKERS] Proposed patch to clean up signed-ness warnings

2005-09-22 Thread Tatsuo Ishii
hard to implement that without significant performance loss, but I know we should do it in the future). So unsigned char* is not enough for the goal anyway, I'm not against your patches. -- SRA OSS, Inc. Japan Tatsuo Ishii ---(end of broadcast)--- TIP

Re: [PATCHES] A couple of proposed pgbench changes

2005-11-30 Thread Tatsuo Ishii
patches seem fine. -- Tatsuo Ishii SRA OSS, Inc. Japan ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match

Re: [PATCHES] A couple of proposed pgbench changes

2005-12-03 Thread Tatsuo Ishii
I have commited your fixes into PostgreSQL 8.1 stable branches. -- Tatsuo Ishii SRA OSS, Inc. Japan Hi Tatsuo, Attached is a proposed patch that deals with a couple of pgbench issues. The change at line 490 updates doCustom's local variable commands after selecting a new file (command

Re: [PATCHES] [BUGS] BUG #2120: Crash when doing UTF8-ISO_8859_8 encoding

2005-12-22 Thread Tatsuo Ishii
Tom Lane wrote: Tatsuo Ishii [EMAIL PROTECTED] writes: It looks like somebody rearranged the pg_enc enum without bothering to fix the tables that are affected by this. I will look into this. Thank you. It might be worth adding a comment to pg_wchar.h listing all the places

Re: [PATCHES] [BUGS] BUG #2120: Crash when doing UTF8-ISO_8859_8

2005-12-22 Thread Tatsuo Ishii
the conversion for the code? What do you think, Sega? -- Tatsuo Ishii SRA OSS, Inc. Japan That is a nice solution --- instead of listing all the encodings, you listed just the ones that need to be used. The list is shorter and clearer. It seems like the right approach. Thanks

Re: [PATCHES] [BUGS] BUG #2120: Crash when doing UTF8-ISO_8859_8

2005-12-23 Thread Tatsuo Ishii
Tatsuo Ishii [EMAIL PROTECTED] writes: I think the current implementaion in utf8_and_iso8859.c is fast but too fragile against rearranging of encoding id. I modify those functions in utf8_and_iso8859.c to do a linear search with encoding id. That's not unreasonable, but I was wondering

Re: [PATCHES] [BUGS] BUG #2120: Crash when doing UTF8-ISO_8859_8

2005-12-25 Thread Tatsuo Ishii
On 23/12/2005 03:59, Tatsuo Ishii wrote: BTW, the example code sequence (ISO-8859-8) Sagi posted seems to have wrong one. select '$,3u=u=u=u=u=u=u=u=(B'; WARNING: ignoring unconvertible ISO_8859_8 character 0x00d7 : : 0x00d7(\327) is not listed in our ISO-8858-8/UTF-8

Re: [PATCHES] [HACKERS] pg_freespacemap question

2006-03-11 Thread Tatsuo Ishii
Mark, I have tried your patches and it worked great. Thanks. -- Tatsuo Ishii SRA OSS, Inc. Japan Tom Lane wrote: Mark Kirkwood [EMAIL PROTECTED] writes: Good points! I had not noticed this test case. Probably NULL is better Would setting it to 'BLCKSZ - (fixed index header stuff

Re: [PATCHES] [HACKERS] pg_freespacemap question

2006-03-11 Thread Tatsuo Ishii
BTW, I noticed difference of outputs from pg_freespacemap and pgstattuple. I ran pgbench and inspected accounts table by using these tools. pg_freespacemap: sum of bytes: 250712 pgstattuple: free_space: 354880 Shouldn't they be identical? -- Tatsuo Ishii SRA OSS, Inc. Japan

Re: [PATCHES] [HACKERS] pg_freespacemap question

2006-03-12 Thread Tatsuo Ishii
Tatsuo Ishii wrote: BTW, I noticed difference of outputs from pg_freespacemap and pgstattuple. I ran pgbench and inspected accounts table by using these tools. pg_freespacemap: sum of bytes: 250712 pgstattuple: free_space: 354880 Shouldn't they be identical

[PATCHES] pgbench patches

2006-07-27 Thread Tatsuo Ishii
. -- Tatsuo Ishii SRA OSS, Inc. Japan Index: pgbench.c === RCS file: /cvsroot/pgsql/contrib/pgbench/pgbench.c,v retrieving revision 1.50 diff -c -r1.50 pgbench.c *** pgbench.c 26 Jul 2006 07:24:50 - 1.50 --- pgbench.c 27 Jul 2006

Re: [PATCHES] contrib/pgbench bugfix

2006-07-30 Thread Tatsuo Ishii
Good catch! Thanks. I have committed your fix. -- Tatsuo Ishii SRA OSS, Inc. Japan I found a buffer overflow bug in contrib/pgbench. This occures when -c = 2. The type of 'state' is CState*, so we should use state+1 or state[1], not state + sizeof(*state) *** pgbench.c Mon Jul 31

Re: [PATCHES] Replication Documentation

2006-08-01 Thread Tatsuo Ishii
/pgpool_feat_and_devel.pdf -- Tatsuo Ishii SRA OSS, Inc. Japan ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] pgbench: handring empty lines in external scripts

2006-08-15 Thread Tatsuo Ishii
Thanks. I have committed your patches. -- Tatsuo Ishii SRA OSS, Inc. Japan Hi Tatsuo-san and folks, This is a fix in pgbench to handle empty lines in external scripts. The manual says | Empty lines and lines begging with -- will be ignored. but AFAICS, it cannot accept empty lines and exit

Re: [PATCHES] pgbench on mingw needs fflush

2007-03-12 Thread Tatsuo Ishii
Can we distinguish mingw case from others so that we could ifdef out the extra fflush()? -- Tatsuo Ishii SRA OSS, Inc. Japan pgbench reports its progress of loading (N tuples done.) or vacuuming (vacuum...end), but the messages are not printed on the moment on mingw. The reason seems

Re: [PATCHES] pgbench on mingw needs fflush

2007-03-12 Thread Tatsuo Ishii
Can we distinguish mingw case from others so that we could ifdef out the extra fflush()? -- Tatsuo Ishii SRA OSS, Inc. Japan pgbench reports its progress of loading (N tuples done.) or vacuuming (vacuum...end), but the messages are not printed on the moment on mingw. The reason seems

Re: [PATCHES] HOT WIP Patch - version 6.3

2007-04-04 Thread Tatsuo Ishii
patch revisions. Would it help to consolidate them in a single document ? That would help me lot. Also it would be nice it is place in a source directory as a README file. I have a design document of HOT posted by Simon on 2007/02/07. I wonder what have changed since the proposal. -- Tatsuo Ishii SRA

Re: [PATCHES] Optimized pgbench for 8.3

2007-04-04 Thread Tatsuo Ishii
Tatsuo, would you please comment on this patch? Sure. I will come up with a comment by the end of this week. -- Tatsuo Ishii SRA OSS, Inc. Japan --- ITAGAKI Takahiro wrote: The attached is a patch to optimize contrib

Re: [PATCHES] pgbench transaction timestamps

2007-04-04 Thread Tatsuo Ishii
Tatsuo, would you please comment on this patch too? No problem. I will come up with a comment by the end of this week. -- Tatsuo Ishii SRA OSS, Inc. Japan --- Greg Smith wrote: This patch changes the way pgbench

Re: [PATCHES] pgbench transaction timestamps

2007-04-05 Thread Tatsuo Ishii
, but the patches still include the feature. So I'm confused. -- Tatsuo Ishii SRA OSS, Inc. Japan --- Greg Smith wrote: This patch changes the way pgbench outputs its latency log files so that every transaction gets

Re: [PATCHES] Optimized pgbench for 8.3

2007-04-05 Thread Tatsuo Ishii
it easier to test HOT. -- Tatsuo Ishii SRA OSS, Inc. Japan --- ITAGAKI Takahiro wrote: The attached is a patch to optimize contrib/pgbench using new 8.3 features. - Use DROP IF EXISTS to suppress errors

Re: [PATCHES] Optimized pgbench for 8.3

2007-04-06 Thread Tatsuo Ishii
Patch committed. Thanks. -- Tatsuo Ishii SRA OSS, Inc. Japan The attached is a patch to optimize contrib/pgbench using new 8.3 features. - Use DROP IF EXISTS to suppress errors for initial loadings. - Use a combination of TRUNCATE and COPY to reduce WAL on creating the accounts table

Re: [HACKERS] [PATCHES] Optimized pgbench for 8.3

2007-04-07 Thread Tatsuo Ishii
Patch committed. Thanks. -- Tatsuo Ishii SRA OSS, Inc. Japan On 4/6/07, Tatsuo Ishii [EMAIL PROTECTED] wrote: BTW, is anybody working on enabling the fill factor to the tables used by pgbench? 8.3 will introduce HOT, and I think adding the feature will make it easier to test HOT

Re: [PATCHES] CREATE TABLE LIKE INCLUDING INDEXES support

2007-07-19 Thread Tatsuo Ishii
Can someone enligten me what the usecase for CREATE TABLE LIKE at this moment is? I read the doc and followed the discssion in this thread in pgsql-patches list but it was hard for me to figure out. -- Tatsuo Ishii SRA OSS, Inc. Japan I've applied the latest version of the patch to HEAD. Thanks

Re: [PATCHES] Wrong result with pgbench -C option?

2008-03-18 Thread Tatsuo Ishii
Patch applied. Thanks. -- Tatsuo Ishii SRA OSS, Inc. Japan Hi, I ran pgbench with -C option. Here is an output. % pgbench -C -c 10 -t 100 bench starting vacuum...end. transaction type: TPC-B (sort of) scaling factor: 1 number of clients: 10 number of transactions per client: 100

Re: [PATCHES] Patch for testing query modes on pgbench

2008-03-18 Thread Tatsuo Ishii
in prior). The cause of this is obvious and easy to fix. However I wonder this is because of accidental old or wrong patches. Can you resubmit new patches against CVS Head? -- Tatsuo Ishii SRA OSS, Inc. Japan -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes

Re: [PATCHES] Patch for testing query modes on pgbench

2008-03-18 Thread Tatsuo Ishii
Patches applied. Thanks. -- Tatsuo Ishii SRA OSS, Inc. Japan Tatsuo Ishii [EMAIL PROTECTED] wrote: The cause of this is obvious and easy to fix. However I wonder this is because of accidental old or wrong patches. Can you resubmit new patches against CVS Head? Thanks for your review

[PATCHES] WITH RECURSIVE patch V0.1

2008-05-18 Thread Tatsuo Ishii
with Tatsuo Ishii ([EMAIL PROTECTED]). - prior patches: http://archives.postgresql.org/pgsql-patches/2008-03/msg00327.php The patches include some extentions to the patches above. 2. Design proposales See: http://archives.postgresql.org/pgsql-hackers/2008-02/msg00642.php 3. Implementation details

Re: [PATCHES] WITH RECURSIVE patch V0.1

2008-05-21 Thread Tatsuo Ishii
On Sun, May 18, 2008 at 08:51:29PM +0900, Tatsuo Ishii wrote: WITH RECURSIVE patch V0.1 Here are patches to implement WITH RECURSIVE clause. There are some limitiations and TODO items(see the Current limitations section below). Comments are welcome. 1. Credit These patches

Re: [PATCHES] [HACKERS] WITH RECURSIVE updated to CVS TIP

2008-07-08 Thread Tatsuo Ishii
result - fix inifinit recursion with OUTER JOIN Not yet fixed: - detect certain queries those are not valid acroding to the standard - sort query names acording to the dependency - planner always estimate 0 cost for recursion plans -- Tatsuo Ishii SRA OSS, Inc. Japan - SQL:2008 に規定されているクエリ以外をエラーに

Re: [PATCHES] [HACKERS] WITH RECURSIVE updated to CVS TIP

2008-07-15 Thread Tatsuo Ishii
On Wed, Jul 16, 2008 at 09:37:25AM +0900, Tatsuo Ishii wrote: On Tue, Jul 08, 2008 at 06:01:05PM +0900, Tatsuo Ishii wrote: Here is the patches he made against CVS HEAD (as of today). According to him followings are fixed with the patches: - fix crush with DISTINCT

Re: [PATCHES] [HACKERS] WITH RECURSIVE updated to CVS TIP

2008-07-17 Thread Tatsuo Ishii
On Wed, Jul 16, 2008 at 01:57:04PM +0900, Tatsuo Ishii wrote: No idea. What do you think if we allow only one query name at the moment. I'm not sure I understand what that has to do with sorting. Please find attached a place where I've found some problems sorting by tree

[PATCHES] WITH RECUSIVE patches 0717

2008-07-17 Thread Tatsuo Ishii
Hi, Here is the lastest WITH RECURSIVE patches against CVS HEAD created by Yoshiyuki Asaba and minor corrections by Tatsuo Ishii. (David Fetter's psql help patches are not included. It seems his git repository has gone). This version implements: - detect certain queries those are not valid

Re: [PATCHES] WITH RECUSIVE patches 0717

2008-07-17 Thread Tatsuo Ishii
Here is the lastest WITH RECURSIVE patches against CVS HEAD created by Yoshiyuki Asaba and minor corrections by Tatsuo Ishii. I tried this patch vs. CVS HEAD used my usual configure option with only --with-prefix set, then tried to make, and got: make[3]: *** No rule to make target

Re: [HACKERS] [PATCHES] WITH RECUSIVE patches 0717

2008-07-20 Thread Tatsuo Ishii
This crashes the backend: WITH RECURSIVE t(n) AS ( VALUES (1) UNION ALL SELECT n+1 FROM t WHERE n 5 ORDER BY 1 ) SELECT n FROM t; apparently because of the ORDER BY 1 Thanks for the report. I think ORDER BY in this case is useless anyway. ORDER BY affects (VALUES (1) UNION

Re: [HACKERS] [PATCHES] WITH RECUSIVE patches 0717

2008-07-20 Thread Tatsuo Ishii
SELECT max(n) FROM x) SELECT * FROM x; produces an error. -- Tatsuo Ishii SRA OSS, Inc. Japan -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches

Re: [HACKERS] [PATCHES] WITH RECUSIVE patches 0717

2008-07-20 Thread Tatsuo Ishii
On Mon, Jul 21, 2008 at 08:19:35AM +0900, Tatsuo Ishii wrote: Thus I think we should avoid this kind of ORDER BY. Probably we should avoid LIMIT/OFFSET and FOR UPDATE as well. What of index-optimized SELECT max(...) ? Aggregate functions in a recursive term is prohibited

[PATCHES] WITH RECUSIVE patches 0721

2008-07-21 Thread Tatsuo Ishii
Hi, Here is the lastest WITH RECURSIVE patches against 2007/07/17 CVS (CVS HEAD won't compile for me). This version includes regression tests and is almost ready for commit IMO. -- Tatsuo Ishii SRA OSS, Inc. Japan recursive_query.patch.gz Description: Binary data -- Sent via pgsql-patches

[PATCHES] WITH RECUSIVE patches 0723

2008-07-23 Thread Tatsuo Ishii
CVS HEAD. Reviewers, please let me know if you find problems with the patches. If none, I would like to commit this weekend. -- Tatsuo Ishii SRA OSS, Inc. Japan recursive_query.patch.gz Description: Binary data -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make

Re: [PATCHES] [HACKERS] WITH RECUSIVE patches 0723

2008-07-23 Thread Tatsuo Ishii
Tatsuo Ishii [EMAIL PROTECTED] writes: Reviewers, please let me know if you find problems with the patches. If none, I would like to commit this weekend. Has this patch actually been reviewed yet? The only reports I've seen are from testing; nothing from anyone actually reading the code

Re: [PATCHES] [HACKERS] WITH RECUSIVE patches 0723

2008-07-23 Thread Tatsuo Ishii
On Wed, Jul 23, 2008 at 10:59:20AM -0400, Tom Lane wrote: Tatsuo Ishii [EMAIL PROTECTED] writes: Reviewers, please let me know if you find problems with the patches. If none, I would like to commit this weekend. Has this patch actually been reviewed yet? The only reports I've seen

Re: [PATCHES] [HACKERS] WITH RECUSIVE patches 0723

2008-07-23 Thread Tatsuo Ishii
On Wed, Jul 23, 2008 at 10:59:20AM -0400, Tom Lane wrote: Tatsuo Ishii [EMAIL PROTECTED] writes: Reviewers, please let me know if you find problems with the patches. If none, I would like to commit this weekend. Has this patch actually been reviewed yet? The only reports I've seen

Re: [PATCHES] [HACKERS] WITH RECUSIVE patches 0723

2008-07-24 Thread Tatsuo Ishii
the attached patch to help out with tab completion in psql. Ok, it will appear in the next patches. -- Tatsuo Ishii SRA OSS, Inc. Japan -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches

Re: [PATCHES] [HACKERS] WITH RECUSIVE patches 0723

2008-07-25 Thread Tatsuo Ishii
patches from Yoshiyuki against CVS HEAD. Also I have added your test case to the regression test. Please apply the attached patch to help out with tab completion in psql. Thanks. Your patches has been included. -- Tatsuo Ishii SRA OSS, Inc. Japan recursive_query.patch.gz Description: Binary data

[PATCHES] WITH RECURSIVE patches 0803

2008-08-02 Thread Tatsuo Ishii
. BTW, I'm traveling to the United States from Aug 4 to Aug 12. I'm going to join Linux World, PGDay and pgpool party at Bruce's. I hope to meet many community poeple soon! -- Tatsuo Ishii SRA OSS, Inc. Japan recursive_query.patch.gz Description: Binary data -- Sent via pgsql-patches mailing

Re: [PATCHES] [HACKERS] WITH RECURSIVE patches 0818

2008-08-19 Thread Tatsuo Ishii
to the error-checking code? I know I didn't explain that well, but the above SQL should work and the error appears to stem from the parser's looking at the innermost UNION ALL instead of the outermost. Thanks for the report. I will look into this. -- Tatsuo Ishii SRA OSS, Inc. Japan -- Sent via

Re: [PATCHES] [HACKERS] WITH RECURSIVE patches 0818

2008-08-22 Thread Tatsuo Ishii
added your SQL to the regression test, and now the patches is against CVS HEAD. For your convenience I also include patches against the previous version. -- Tatsuo Ishii SRA OSS, Inc. Japan recursive_query.patch.gz Description: Binary data *** pgsql/src/backend/executor/nodeAppend.c 2008-08-18 16