Re: [PATCHES] --single-transaction doc clarification

2006-10-31 Thread Jim C. Nasby
On Mon, Oct 30, 2006 at 07:18:04PM -0500, Neil Conway wrote: On Mon, 2006-10-30 at 22:56 +, Simon Riggs wrote: The man pages for VACUUM, CREATE TABLESPACE, CLUSTER and REINDEX DATABASE don't mention they are not allowed inside a transaction block at all That should be fixed, I think.

[PATCHES] --single-transaction doc clarification

2006-10-30 Thread Simon Riggs
Clarification of when it's not appropriate to use this option. -- Simon Riggs EnterpriseDB http://www.enterprisedb.com Index: doc/src/sgml/ref/psql-ref.sgml === RCS file:

Re: [PATCHES] --single-transaction doc clarification

2006-10-30 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: Clarification of when it's not appropriate to use this option. I think it's a fairly bad idea to try to enumerate the commands that can't be used in a transaction block here, because there is no way that we will remember to keep such a list up-to-date. Why

Re: [PATCHES] --single-transaction doc clarification

2006-10-30 Thread Simon Riggs
On Mon, 2006-10-30 at 17:32 -0500, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: Clarification of when it's not appropriate to use this option. I think it's a fairly bad idea to try to enumerate the commands that can't be used in a transaction block here, because there is no way

Re: [PATCHES] --single-transaction doc clarification

2006-10-30 Thread Neil Conway
On Mon, 2006-10-30 at 22:56 +, Simon Riggs wrote: The man pages for VACUUM, CREATE TABLESPACE, CLUSTER and REINDEX DATABASE don't mention they are not allowed inside a transaction block at all That should be fixed, I think. Once that is done, I think it's sufficient to just say that

Re: [PATCHES] --single-transaction doc clarification

2006-10-30 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: On Mon, 2006-10-30 at 22:56 +, Simon Riggs wrote: The man pages for VACUUM, CREATE TABLESPACE, CLUSTER and REINDEX DATABASE don't mention they are not allowed inside a transaction block at all That should be fixed, I think. Once that is done, I think

Re: [PATCHES] --single-transaction doc clarification

2006-10-30 Thread Simon Riggs
On Mon, 2006-10-30 at 19:28 -0500, Tom Lane wrote: Neil Conway [EMAIL PROTECTED] writes: On Mon, 2006-10-30 at 22:56 +, Simon Riggs wrote: The man pages for VACUUM, CREATE TABLESPACE, CLUSTER and REINDEX DATABASE don't mention they are not allowed inside a transaction block at all

Re: [PATCHES] --single-transaction doc clarification

2006-10-30 Thread Neil Conway
On Tue, 2006-10-31 at 01:07 +, Simon Riggs wrote: As requested. Applied, thanks for the patch. I didn't apply the ON_ERROR_STOP addition: IMHO it's not very useful to say that doing something is advised without explaining why it is wise/useful/necessary. If we want to include this point,

Re: [PATCHES] --single-transaction doc clarification

2006-10-30 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: On Tue, 2006-10-31 at 01:07 +, Simon Riggs wrote: As requested. Applied, thanks for the patch. This patch converted a correct statement into a lie: there is not anything that will cause begin/commit in a script file to fail just because you wrapped